From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F30F2D41C3E for ; Wed, 13 Nov 2024 12:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=58JNz9wOUNMS/MEofF5Q45pSa4buB20+zdy/zG+25s4=; b=FJvKVhdsbikMzi +N5x3nmr+/A9hq6XqehVoPhPtbQ6UCAq+v9iMx/NJEu/XNR3QNlh9vnepGDXS0S+Edm5KxE3UIBpX AZMPRDcLJvDa7Vl2TY82TQz1d/lO/cQlOL5C77yx+t/UdD2UP7EZN8i6v46il8ULdjPN7NfeWRyQN QjYyTNiJtKhnRcKYAuLi68M7zcv55pNBBmS2uugRvE64tu5q/hpzEAg4TMBjdHK5Ts7NBvDQbfpZb dcb2PxMW3+4u4NI57J7g6nHVVOztTN9/yxAN4tlVZZMv7lR6OTRzgudOYznBLG9HLhVgD5UR3U5mv dHJmamg3iA0ecSeyweEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBCul-00000006qA2-2yTh; Wed, 13 Nov 2024 12:56:07 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBCuf-00000006q9a-0Y8z for kexec@lists.infradead.org; Wed, 13 Nov 2024 12:56:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731502559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wdv+VVxJAX9WwJWxe+bYl+tm5LZyKAbTSEEijJF0+7E=; b=V1FcSVgEE4TOu+qJ4vECHlNFGZwb+3Zk+N10Won6UcHwhjj3vdGjC3IIZbqiStf103jm0Y FCBpq8hEon5eBLKFY2Sd3+8RurAiBlhW1KdIx8D2x/mugq2aroKvvc2nxcdv2Nwcn/zW5I 8QjhOJIDsaeXG6E9ImYXWwmTQSr6zWA= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-LuI3AqNeNcOWjxUiqby2YQ-1; Wed, 13 Nov 2024 07:55:55 -0500 X-MC-Unique: LuI3AqNeNcOWjxUiqby2YQ-1 X-Mimecast-MFC-AGG-ID: LuI3AqNeNcOWjxUiqby2YQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D9B1419541A0; Wed, 13 Nov 2024 12:55:53 +0000 (UTC) Received: from localhost (unknown [10.72.112.83]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 275E330000DF; Wed, 13 Nov 2024 12:55:51 +0000 (UTC) Date: Wed, 13 Nov 2024 20:55:47 +0800 From: Baoquan He To: Borislav Petkov Cc: Tom Lendacky , linux-kernel@vger.kernel.org, dyoung@redhat.com, daniel.kiper@oracle.com, noodles@fb.com, lijiang@redhat.com, kexec@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v3 1/2] x86/mm: rename the confusing local variable in early_memremap_is_setup_data() Message-ID: References: <20240911081615.262202-1-bhe@redhat.com> <20240911081615.262202-2-bhe@redhat.com> <20241029181101.GXZyElNXVuF6596TKG@fat_crate.local> <8c81835b-97fe-a0b3-a860-0bbd5c0341f6@amd.com> <20241101161849.GCZyT_aSMcGIXnGr1-@fat_crate.local> <20241102110618.GAZyYHquhmVJd4yM9O@fat_crate.local> <20241106112052.GCZytRFKTESZI8_3qD@fat_crate.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241106112052.GCZytRFKTESZI8_3qD@fat_crate.local> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241113_045601_269509_71749346 X-CRM114-Status: GOOD ( 33.06 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org T24gMTEvMDYvMjQgYXQgMTI6MjBwbSwgQm9yaXNsYXYgUGV0a292IHdyb3RlOgo+IE9uIFNhdCwg Tm92IDAyLCAyMDI0IGF0IDEyOjA2OjE4UE0gKzAxMDAsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToK PiA+IE9rLCBJJ2xsIHRha2UgeW91ciAyLzIgbmV4dCB3ZWVrIGFuZCB5b3UgY2FuIHRoZW4gc2Vu ZCB0aGUgY2xlYW51cCBvbnRvcC4KPiAKPiBPTUcgd2hhdCBhIG1lc3MgdGhpcyBpcy4gUGxlYXNl IHRlc3QgdGhlIGJlbG93IGJlZm9yZSBJIGFwcGx5IGl0LgoKSSBmaW5hbGx5IGdvdCBhbiBhdmFp bGFibGUgbWFjaGluZSB0byB0ZXN0IGJlbG93IHBhdGNoLCBJIGNhbiBjb25maXJtCnRoYXQgd2l0 aG91dCBpdCB0aGUgYnJlYWthZ2UgY2FuIGJlIHJlcHJvZHVjZWQgc3RhYmx5OyB3aXRoIGJlbG93 IHBhdGNoCmFwcGxpZWQgdGhlIGJyZWFrYWdlIGlzIGdvbmUgYW5kIHZtY29yZSBkdW1waW5nIGlz IHN1Y2Nlc3NmdWwuCgo+IAo+IFRoZW4sIHdoZW4geW91IGRvIHRoZSBjbGVhbnVwLCBkbyB0aGUg Zm9sbG93aW5nOgoKV2lsbCBwb3N0IGNsZWFudXAgcGF0Y2ggbGF0ZXIuIFRoYW5rcy4KCj4gCj4g LSBtZXJnZSBlYXJseV9tZW1yZW1hcF9pc19zZXR1cF9kYXRhKCkgd2l0aCBtZW1yZW1hcF9pc19z ZXR1cF9kYXRhKCkgaW50bwo+ICAgYSBjb21tb24gX19tZW1yZW1hcF9pc19zZXR1cF9kYXRhKCkg YW5kIHRoZW4gYWRkIGEgYm9vbCBlYXJseSB3aGljaAo+ICAgZGV0ZXJtaW5lcyB3aGljaCBtZW1y ZW1hcCB2YXJpYW50IGlzIGNhbGxlZC4KPiAKPiAtIHVuaWZ5IHRoZSBAc2l6ZSBhcmd1bWVudCBi eSBkcm9wcGluZyBpdCBhbmQgdXNpbmcgYSBmdW5jdGlvbiBsb2NhbCBzaXplLgo+ICAgV2hhdCB3 ZSBoYXZlIHRoZXJlIG5vdyBpcyB0aGUgZGVmaW5pdGlvbiBvZiBiaXRyb3QuIDotXAo+IAo+IC0g cmVwbGFjZSBhbGwgc2l6ZW9mKCpkYXRhKSwgc2l6ZW9mKHN0cnVjdCBzZXR1cF9kYXRhKSB3aXRo IGEgbWFjcm8gZGVmaW5pdGlvbgo+ICAgYWJvdmUgdGhlIGZ1bmN0aW9ucyB0byB1bmlmeSBpdCBw cm9wZXJseS4KPiAKPiBXaGF0IGFuIHVnbHkgbWVzcy4uLiA6LVwKPiAKPiAtLS0KPiBGcm9tOiBC YW9xdWFuIEhlIDxiaGVAcmVkaGF0LmNvbT4KPiBEYXRlOiBXZWQsIDExIFNlcCAyMDI0IDE2OjE2 OjE1ICswODAwCj4gU3ViamVjdDogW1BBVENIXSB4ODYvbW06IEZpeCBhIGtkdW1wIGtlcm5lbCBm YWlsdXJlIG9uIFNNRSBzeXN0ZW0gd2hlbgo+ICBDT05GSUdfSU1BX0tFWEVDPXkKPiBNSU1FLVZl cnNpb246IDEuMAo+IENvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOAo+IENv bnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKPiAKPiBUaGUga2R1bXAga2VybmVsIGlzIGJy b2tlbiBvbiBTTUUgc3lzdGVtcyB3aXRoIENPTkZJR19JTUFfS0VYRUM9eSBlbmFibGVkLgo+IERl YnVnZ2luZyB0cmFjZWQgdGhlIGlzc3VlIGJhY2sgdG8KPiAKPiAgIGI2OWEyYWZkNWFmYyAoIng4 Ni9rZXhlYzogQ2FycnkgZm9yd2FyZCBJTUEgbWVhc3VyZW1lbnQgbG9nIG9uIGtleGVjIikuCj4g Cj4gVGVzdGluZyB3YXMgcHJldmlvdXNseSBub3QgY29uZHVjdGVkIG9uIFNNRSBzeXN0ZW1zIHdp dGggQ09ORklHX0lNQV9LRVhFQwo+IGVuYWJsZWQsIHdoaWNoIGxlZCB0byB0aGUgb3ZlcnNpZ2h0 LCB3aXRoIHRoZSBmb2xsb3dpbmcgaW5jYXJuYXRpb246Cj4gCj4gLi4uCj4gICBpbWE6IE5vIFRQ TSBjaGlwIGZvdW5kLCBhY3RpdmF0aW5nIFRQTS1ieXBhc3MhCj4gICBMb2FkaW5nIGNvbXBpbGVk LWluIG1vZHVsZSBYLjUwOSBjZXJ0aWZpY2F0ZXMKPiAgIExvYWRlZCBYLjUwOSBjZXJ0ICdCdWls ZCB0aW1lIGF1dG9nZW5lcmF0ZWQga2VybmVsIGtleTogMThhZTBiYzdlNzliNjQ3MDAxMjJiYjFk NmE5MDRiMDcwZmVmMjY1NicKPiAgIGltYTogQWxsb2NhdGVkIGhhc2ggYWxnb3JpdGhtOiBzaGEy NTYKPiAgIE9vcHM6IGdlbmVyYWwgcHJvdGVjdGlvbiBmYXVsdCwgcHJvYmFibHkgZm9yIG5vbi1j YW5vbmljYWwgYWRkcmVzcyAweGNmYWNmZGZlNjY2MDAwM2U6IDAwMDAgWyMxXSBQUkVFTVBUIFNN UCBOT1BUSQo+ICAgQ1BVOiAwIFVJRDogMCBQSUQ6IDEgQ29tbTogc3dhcHBlci8wIE5vdCB0YWlu dGVkIDYuMTEuMC1yYzIrICMxNAo+ICAgSGFyZHdhcmUgbmFtZTogRGVsbCBJbmMuIFBvd2VyRWRn ZSBSNzQyNS8wMk1KM1QsIEJJT1MgMS4yMC4wIDA1LzAzLzIwMjMKPiAgIFJJUDogMDAxMDppbWFf cmVzdG9yZV9tZWFzdXJlbWVudF9saXN0Cj4gICBDYWxsIFRyYWNlOgo+ICAgIDxUQVNLPgo+ICAg ID8gc2hvd190cmFjZV9sb2dfbHZsCj4gICAgPyBzaG93X3RyYWNlX2xvZ19sdmwKPiAgICA/IGlt YV9sb2FkX2tleGVjX2J1ZmZlcgo+ICAgID8gX19kaWVfYm9keS5jb2xkCj4gICAgPyBkaWVfYWRk cgo+ICAgID8gZXhjX2dlbmVyYWxfcHJvdGVjdGlvbgo+ICAgID8gYXNtX2V4Y19nZW5lcmFsX3By b3RlY3Rpb24KPiAgICA/IGltYV9yZXN0b3JlX21lYXN1cmVtZW50X2xpc3QKPiAgICA/IHZwcmlu dGtfZW1pdAo+ICAgID8gaW1hX2xvYWRfa2V4ZWNfYnVmZmVyCj4gICAgaW1hX2xvYWRfa2V4ZWNf YnVmZmVyCj4gICAgaW1hX2luaXQKPiAgICA/IF9fcGZ4X2luaXRfaW1hCj4gICAgaW5pdF9pbWEK PiAgICA/IF9fcGZ4X2luaXRfaW1hCj4gICAgZG9fb25lX2luaXRjYWxsCj4gICAgZG9faW5pdGNh bGxzCj4gICAgPyBfX3BmeF9rZXJuZWxfaW5pdAo+ICAgIGtlcm5lbF9pbml0X2ZyZWVhYmxlCj4g ICAga2VybmVsX2luaXQKPiAgICByZXRfZnJvbV9mb3JrCj4gICAgPyBfX3BmeF9rZXJuZWxfaW5p dAo+ICAgIHJldF9mcm9tX2ZvcmtfYXNtCj4gICAgPC9UQVNLPgo+ICAgTW9kdWxlcyBsaW5rZWQg aW46Cj4gICAtLS1bIGVuZCB0cmFjZSAwMDAwMDAwMDAwMDAwMDAwIF0tLS0KPiAgIC4uLgo+ICAg S2VybmVsIHBhbmljIC0gbm90IHN5bmNpbmc6IEZhdGFsIGV4Y2VwdGlvbgo+ICAgS2VybmVsIE9m ZnNldDogZGlzYWJsZWQKPiAgIFJlYm9vdGluZyBpbiAxMCBzZWNvbmRzLi4KPiAKPiBBZGRpbmcg ZGVidWcgcHJpbnRrcyBzaG93ZWQgdGhhdCB0aGUgc3RvcmVkIGFkZHIgYW5kIHNpemUgb2YgaW1h X2tleGVjIGJ1ZmZlcgo+IGFyZSBub3QgZGVjcnlwdGVkIGNvcnJlY3RseSBsaWtlOgo+IAo+ICAg aW1hOiBpbWFfbG9hZF9rZXhlY19idWZmZXIsIGJ1ZmZlcjoweGNmYWNmZGZlNjY2MDAwM2UsIHNp emU6MHhlNDgwNjYwNTJkNWRmMzU5Cj4gCj4gVGhyZWUgdHlwZXMgb2Ygc2V0dXBfZGF0YSBpbmZv Cj4gCj4gICDigJQgU0VUVVBfRUZJLAo+ICAgLSBTRVRVUF9JTUEsIGFuZAo+ICAgLSBTRVRVUF9S TkdfU0VFRAo+IAo+IGFyZSBwYXNzZWQgdG8gdGhlIGtleGVjL2tkdW1wIGtlcm5lbC4gT25seSB0 aGUgaW1hX2tleGVjIGJ1ZmZlcgo+IGV4cGVyaWVuY2VkIGluY29ycmVjdCBkZWNyeXB0aW9uLiBE ZWJ1Z2dpbmcgaWRlbnRpZmllZCBhIGJ1ZyBpbgo+IGVhcmx5X21lbXJlbWFwX2lzX3NldHVwX2Rh dGEoKSwgd2hlcmUgYW4gaW5jb3JyZWN0IHJhbmdlIGNhbGN1bGF0aW9uCj4gb2NjdXJyZWQgZHVl IHRvIHRoZSBsZW4gdmFyaWFibGUgaW4gc3RydWN0IHNldHVwX2RhdGEgZW5kZWQgdXAgb25seQo+ IHJlcHJlc2VudGluZyB0aGUgbGVuZ3RoIG9mIHRoZSBkYXRhIGZpZWxkLCBleGNsdWRpbmcgdGhl IHN0cnVjdCdzIHNpemUsCj4gYW5kIHRodXMgbGVhZGluZyB0byBtaXNjYWxjdWxhdGlvbi4KPiAK PiBBZGRyZXNzIGEgc2ltaWxhciBpc3N1ZSBpbiBtZW1yZW1hcF9pc19zZXR1cF9kYXRhKCkgd2hp bGUgYXQgaXQuCj4gCj4gICBbIGJwOiBIZWF2aWx5IG1hc3NhZ2UuIF0KPiAKPiBGaXhlczogYjNj NzJmYzlhNzhlICgieDg2L2Jvb3Q6IEludHJvZHVjZSBzZXR1cF9pbmRpcmVjdCIpCj4gU2lnbmVk LW9mZi1ieTogQmFvcXVhbiBIZSA8YmhlQHJlZGhhdC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQm9y aXNsYXYgUGV0a292IChBTUQpIDxicEBhbGllbjguZGU+Cj4gQWNrZWQtYnk6IFRvbSBMZW5kYWNr eSA8dGhvbWFzLmxlbmRhY2t5QGFtZC5jb20+Cj4gQ2M6IDxzdGFibGVAa2VybmVsLm9yZz4KPiBM aW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMjQwOTExMDgxNjE1LjI2MjIwMi0zLWJo ZUByZWRoYXQuY29tCj4gLS0tCj4gIGFyY2gveDg2L21tL2lvcmVtYXAuYyB8IDYgKysrKy0tCj4g IDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2FyY2gveDg2L21tL2lvcmVtYXAuYyBiL2FyY2gveDg2L21tL2lvcmVtYXAuYwo+ IGluZGV4IDcwYjAyZmM2MWQ5My4uOGQyOTE2MzU2OGE3IDEwMDY0NAo+IC0tLSBhL2FyY2gveDg2 L21tL2lvcmVtYXAuYwo+ICsrKyBiL2FyY2gveDg2L21tL2lvcmVtYXAuYwo+IEBAIC02NTYsNyAr NjU2LDggQEAgc3RhdGljIGJvb2wgbWVtcmVtYXBfaXNfc2V0dXBfZGF0YShyZXNvdXJjZV9zaXpl X3QgcGh5c19hZGRyLAo+ICAJCXBhZGRyX25leHQgPSBkYXRhLT5uZXh0Owo+ICAJCWxlbiA9IGRh dGEtPmxlbjsKPiAgCj4gLQkJaWYgKChwaHlzX2FkZHIgPiBwYWRkcikgJiYgKHBoeXNfYWRkciA8 IChwYWRkciArIGxlbikpKSB7Cj4gKwkJaWYgKChwaHlzX2FkZHIgPiBwYWRkcikgJiYKPiArCQkg ICAgKHBoeXNfYWRkciA8IChwYWRkciArIHNpemVvZihzdHJ1Y3Qgc2V0dXBfZGF0YSkgKyBsZW4p KSkgewo+ICAJCQltZW11bm1hcChkYXRhKTsKPiAgCQkJcmV0dXJuIHRydWU7Cj4gIAkJfQo+IEBA IC03MTgsNyArNzE5LDggQEAgc3RhdGljIGJvb2wgX19pbml0IGVhcmx5X21lbXJlbWFwX2lzX3Nl dHVwX2RhdGEocmVzb3VyY2Vfc2l6ZV90IHBoeXNfYWRkciwKPiAgCQlwYWRkcl9uZXh0ID0gZGF0 YS0+bmV4dDsKPiAgCQlsZW4gPSBkYXRhLT5sZW47Cj4gIAo+IC0JCWlmICgocGh5c19hZGRyID4g cGFkZHIpICYmIChwaHlzX2FkZHIgPCAocGFkZHIgKyBsZW4pKSkgewo+ICsJCWlmICgocGh5c19h ZGRyID4gcGFkZHIpICYmCj4gKwkJICAgIChwaHlzX2FkZHIgPCAocGFkZHIgKyBzaXplb2Yoc3Ry dWN0IHNldHVwX2RhdGEpICsgbGVuKSkpIHsKPiAgCQkJZWFybHlfbWVtdW5tYXAoZGF0YSwgc2l6 ZW9mKCpkYXRhKSk7Cj4gIAkJCXJldHVybiB0cnVlOwo+ICAJCX0KPiAtLSAKPiAyLjQzLjAKPiAK PiAKPiAtLSAKPiBSZWdhcmRzL0dydXNzLAo+ICAgICBCb3Jpcy4KPiAKPiBodHRwczovL3Blb3Bs ZS5rZXJuZWwub3JnL3RnbHgvbm90ZXMtYWJvdXQtbmV0aXF1ZXR0ZQo+IAoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdApr ZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 258A16088F for ; Wed, 13 Nov 2024 12:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731502562; cv=none; b=ZgLxu1LiH3H4nqgoCzs30DHrU1f65Swq60gqJoITmNCFVhA4B7Kag+fygfp00vJPs7jcb9AmhjLb2+31e00U40/vr8mxs1MJ36Dxiz3JUCWvzJ3pKVU8+WK1HIQJNPXV+deiFVdslgp+ESZJhcRkn7p73egJtcSDU8oKoC1gg2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731502562; c=relaxed/simple; bh=Rw1hVZ7d3AKNZexZC/1kRGn4ufOg3lp+pAmxPNd4RPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ym67OVSnO6mQDiThOWi581wGSzUGwRplncAeZbI1m7cSamMzCLPbtm8bsLzfrcYOQzC2ufXqblhhbJ1BYkaQ2J8JhNGuZCp+Az9hdjgT2yIrU7FX76B6POPvxPSsuhX0xsd5Jel5WQv5MfedyORtd1/e4Pp7rFJ9Kfoyfqt3jjc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=V1FcSVgE; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V1FcSVgE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731502559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wdv+VVxJAX9WwJWxe+bYl+tm5LZyKAbTSEEijJF0+7E=; b=V1FcSVgEE4TOu+qJ4vECHlNFGZwb+3Zk+N10Won6UcHwhjj3vdGjC3IIZbqiStf103jm0Y FCBpq8hEon5eBLKFY2Sd3+8RurAiBlhW1KdIx8D2x/mugq2aroKvvc2nxcdv2Nwcn/zW5I 8QjhOJIDsaeXG6E9ImYXWwmTQSr6zWA= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-LuI3AqNeNcOWjxUiqby2YQ-1; Wed, 13 Nov 2024 07:55:55 -0500 X-MC-Unique: LuI3AqNeNcOWjxUiqby2YQ-1 X-Mimecast-MFC-AGG-ID: LuI3AqNeNcOWjxUiqby2YQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D9B1419541A0; Wed, 13 Nov 2024 12:55:53 +0000 (UTC) Received: from localhost (unknown [10.72.112.83]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 275E330000DF; Wed, 13 Nov 2024 12:55:51 +0000 (UTC) Date: Wed, 13 Nov 2024 20:55:47 +0800 From: Baoquan He To: Borislav Petkov Cc: Tom Lendacky , linux-kernel@vger.kernel.org, dyoung@redhat.com, daniel.kiper@oracle.com, noodles@fb.com, lijiang@redhat.com, kexec@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v3 1/2] x86/mm: rename the confusing local variable in early_memremap_is_setup_data() Message-ID: References: <20240911081615.262202-1-bhe@redhat.com> <20240911081615.262202-2-bhe@redhat.com> <20241029181101.GXZyElNXVuF6596TKG@fat_crate.local> <8c81835b-97fe-a0b3-a860-0bbd5c0341f6@amd.com> <20241101161849.GCZyT_aSMcGIXnGr1-@fat_crate.local> <20241102110618.GAZyYHquhmVJd4yM9O@fat_crate.local> <20241106112052.GCZytRFKTESZI8_3qD@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241106112052.GCZytRFKTESZI8_3qD@fat_crate.local> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 11/06/24 at 12:20pm, Borislav Petkov wrote: > On Sat, Nov 02, 2024 at 12:06:18PM +0100, Borislav Petkov wrote: > > Ok, I'll take your 2/2 next week and you can then send the cleanup ontop. > > OMG what a mess this is. Please test the below before I apply it. I finally got an available machine to test below patch, I can confirm that without it the breakage can be reproduced stably; with below patch applied the breakage is gone and vmcore dumping is successful. > > Then, when you do the cleanup, do the following: Will post cleanup patch later. Thanks. > > - merge early_memremap_is_setup_data() with memremap_is_setup_data() into > a common __memremap_is_setup_data() and then add a bool early which > determines which memremap variant is called. > > - unify the @size argument by dropping it and using a function local size. > What we have there now is the definition of bitrot. :-\ > > - replace all sizeof(*data), sizeof(struct setup_data) with a macro definition > above the functions to unify it properly. > > What an ugly mess... :-\ > > --- > From: Baoquan He > Date: Wed, 11 Sep 2024 16:16:15 +0800 > Subject: [PATCH] x86/mm: Fix a kdump kernel failure on SME system when > CONFIG_IMA_KEXEC=y > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The kdump kernel is broken on SME systems with CONFIG_IMA_KEXEC=y enabled. > Debugging traced the issue back to > > b69a2afd5afc ("x86/kexec: Carry forward IMA measurement log on kexec"). > > Testing was previously not conducted on SME systems with CONFIG_IMA_KEXEC > enabled, which led to the oversight, with the following incarnation: > > ... > ima: No TPM chip found, activating TPM-bypass! > Loading compiled-in module X.509 certificates > Loaded X.509 cert 'Build time autogenerated kernel key: 18ae0bc7e79b64700122bb1d6a904b070fef2656' > ima: Allocated hash algorithm: sha256 > Oops: general protection fault, probably for non-canonical address 0xcfacfdfe6660003e: 0000 [#1] PREEMPT SMP NOPTI > CPU: 0 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.11.0-rc2+ #14 > Hardware name: Dell Inc. PowerEdge R7425/02MJ3T, BIOS 1.20.0 05/03/2023 > RIP: 0010:ima_restore_measurement_list > Call Trace: > > ? show_trace_log_lvl > ? show_trace_log_lvl > ? ima_load_kexec_buffer > ? __die_body.cold > ? die_addr > ? exc_general_protection > ? asm_exc_general_protection > ? ima_restore_measurement_list > ? vprintk_emit > ? ima_load_kexec_buffer > ima_load_kexec_buffer > ima_init > ? __pfx_init_ima > init_ima > ? __pfx_init_ima > do_one_initcall > do_initcalls > ? __pfx_kernel_init > kernel_init_freeable > kernel_init > ret_from_fork > ? __pfx_kernel_init > ret_from_fork_asm > > Modules linked in: > ---[ end trace 0000000000000000 ]--- > ... > Kernel panic - not syncing: Fatal exception > Kernel Offset: disabled > Rebooting in 10 seconds.. > > Adding debug printks showed that the stored addr and size of ima_kexec buffer > are not decrypted correctly like: > > ima: ima_load_kexec_buffer, buffer:0xcfacfdfe6660003e, size:0xe48066052d5df359 > > Three types of setup_data info > > — SETUP_EFI, > - SETUP_IMA, and > - SETUP_RNG_SEED > > are passed to the kexec/kdump kernel. Only the ima_kexec buffer > experienced incorrect decryption. Debugging identified a bug in > early_memremap_is_setup_data(), where an incorrect range calculation > occurred due to the len variable in struct setup_data ended up only > representing the length of the data field, excluding the struct's size, > and thus leading to miscalculation. > > Address a similar issue in memremap_is_setup_data() while at it. > > [ bp: Heavily massage. ] > > Fixes: b3c72fc9a78e ("x86/boot: Introduce setup_indirect") > Signed-off-by: Baoquan He > Signed-off-by: Borislav Petkov (AMD) > Acked-by: Tom Lendacky > Cc: > Link: https://lore.kernel.org/r/20240911081615.262202-3-bhe@redhat.com > --- > arch/x86/mm/ioremap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c > index 70b02fc61d93..8d29163568a7 100644 > --- a/arch/x86/mm/ioremap.c > +++ b/arch/x86/mm/ioremap.c > @@ -656,7 +656,8 @@ static bool memremap_is_setup_data(resource_size_t phys_addr, > paddr_next = data->next; > len = data->len; > > - if ((phys_addr > paddr) && (phys_addr < (paddr + len))) { > + if ((phys_addr > paddr) && > + (phys_addr < (paddr + sizeof(struct setup_data) + len))) { > memunmap(data); > return true; > } > @@ -718,7 +719,8 @@ static bool __init early_memremap_is_setup_data(resource_size_t phys_addr, > paddr_next = data->next; > len = data->len; > > - if ((phys_addr > paddr) && (phys_addr < (paddr + len))) { > + if ((phys_addr > paddr) && > + (phys_addr < (paddr + sizeof(struct setup_data) + len))) { > early_memunmap(data, sizeof(*data)); > return true; > } > -- > 2.43.0 > > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette >