From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:7d82:b0:1be9:327d:8ee3 with SMTP id wv2csp437072njc; Wed, 13 Nov 2024 07:15:35 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXDOQhVgHW7KL10PmyWPOQiO4QuuGB9bFKv3hqTn7aocTDLTaKp8zdNQBuKzU9GUJxT5G/gAX2hyZkPxg==@linaro.org X-Google-Smtp-Source: AGHT+IGOX6FO2jkpb3LLB+d79lhTTRw99bHBjIu75RfXJE4Kvz2C6XMytY5CbiiqWv7uP8Xd173c X-Received: by 2002:a05:620a:c4e:b0:7b1:4b48:6fc4 with SMTP id af79cd13be357-7b331eaafadmr2696290985a.15.1731510935711; Wed, 13 Nov 2024 07:15:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731510935; cv=none; d=google.com; s=arc-20240605; b=KwQX5Dn3zMce+HWWZeChjq6jL0a8YEnzAuWZSY8uI5GlmAtr5wfLXZjXXjx9exNtf7 aNwpjDmNNr70pHXDaLLIySNmggu4I8rqGjG9Py9HvXRnxdry3V2MFWeL459vfDXAnEBo R2oiAwRE+3jOlQg3+kPrd5HqVPiRDCysUXj1WPk7b5Y9j4mjzWtr5TVsLCouCOC05Ldl huCreDMYig4un02cPh/4gwxdc8iFqr1SMWEy/Ud516QqVtjWvql6MF/rcwq+eEmnpuv9 WIGk0TEjCeqzWIAiyDV3oFX7pDbS3UChlVP4gHyGl4ooFe23nQJTsmJHrvCuOCH3/9XD 5ZQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5skamxa0qjEIqgFjjXcFyEiinV5QlOKKS5WslP2NvK8=; fh=Yk27xx/y2lnbyowUReaXG41oyKuuRI+IFInrN7kDW4M=; b=l0WYVvH9QlUbHIbXf6KWSKN4X29jgRthnewyNRSRDUWX8mrmgSyAw4Ty5kHkcLqjp5 QMD8u/TwAr9+0D7FMjpKVskdB+10ORUwmpe2cR8WKCGOTHA+gXq3cPlmGfb1q4EyNSAe TsALgtSOeCC+nXqnQ+ZwO0SnUA9C3PxJZqiCB+mcd6FYYzqNNAjPf4bjQzuv0xmqGhGw DGdj8XJkDf2mLbQx3tDYaKVb540QFHcgQ02eyfHjrH09WL2oWPQFDoRxkQ8WoO5nrxeR kRX3WnOrXypkQxqVakymEivwakl5hpvTZ3Q+rAdEPjC1ksDMp8H2e1I2vknCXJYSnmMT JU0Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Oh4+tLOL; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b32ac535e1si1647890685a.154.2024.11.13.07.15.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Nov 2024 07:15:35 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Oh4+tLOL; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBF5c-0002ka-8Z; Wed, 13 Nov 2024 10:15:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBF5L-0002dS-Lk; Wed, 13 Nov 2024 10:15:11 -0500 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBF5J-0006LW-0x; Wed, 13 Nov 2024 10:15:10 -0500 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-53da22c5863so696874e87.0; Wed, 13 Nov 2024 07:15:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731510907; x=1732115707; darn=nongnu.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5skamxa0qjEIqgFjjXcFyEiinV5QlOKKS5WslP2NvK8=; b=Oh4+tLOLfYLyANc35f2bboYXDq3smknqfhrg/WVnF1YWg5qsQfaB7bymbM/r3eKahS wDfItFvlSi65Dh16fWz+D/D1T6NljFXgQL5LMRMeeFDbLPozXu8mH1Vprosj9fi4ECTM 6kW7i0HRR7EmKOZWnhXe/kxSLlxqKcwXF44E3BO06jpfi6Rfm8SZNCUmmaEkjXIwogJa PiyXIecQNgnD/njn+JYuQwfz4Gogl2j8ngFk+f/+Y0zpKfEgpaTYR6ubfeib7dRchPWn g7zBzFAe6p9jUqHfti4nAlgG3irx5r1zZdsYbb7IMZTXUH+78i48KExVwcvjIGY+TWDI NPbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731510907; x=1732115707; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5skamxa0qjEIqgFjjXcFyEiinV5QlOKKS5WslP2NvK8=; b=eALOiJE0zkgz/pC3tV7vv+IwcUZIehceT0yhdnfdxGzYoS2J+L2x6Z7K1zq5RLDRdv lhwyWKypFSPR+0CIWmHa5n0CpOXeAmv9o9e/vOHPYKYUwSeCQs1/w09p1nGmNuRP4OQ6 28SiD2kCNoGzIQsAxZm8wjerdkzmwA78dPBzMfgEDfZfK5bgqRJ25N4dsB8Vot/7tGkJ LkBpqoDJM2cWta/1aqyY7iGd3UTcfihdn/m8dYaygSLhj+utqUBujz9eamC/8fQgOd44 ydvfo99MKQEk26KdOyLA9UMMHul2yMlHcglLY/iKWRDqKa5oEVdDpataxyAYEBnCz+5k xscw== X-Forwarded-Encrypted: i=1; AJvYcCWoHNIPLKFjqHzRVC1GJr6ib7NKB+GVhFFP7ZLY6XIHQC6xjo8PSI4DWPynKc0mP77M/rZj1uIuTg==@nongnu.org X-Gm-Message-State: AOJu0YxrmCpufq/ZJ+4QYdeGu9TiSVuBOMx8hydYb4fZ+7IChTbUGpMm kkUAALzcSXdrtgyCWWftjBIJul55A/lVTjG+Dv4Y2sPBUIippBzw X-Received: by 2002:a05:6512:3b98:b0:539:fbf7:38d1 with SMTP id 2adb3069b0e04-53d9a40701fmr4552031e87.2.1731510906416; Wed, 13 Nov 2024 07:15:06 -0800 (PST) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53d82686327sm2243371e87.102.2024.11.13.07.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 07:15:05 -0800 (PST) Date: Wed, 13 Nov 2024 16:15:04 +0100 From: "Edgar E. Iglesias" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , Peter Maydell , Anton Johansson , Jason Wang , qemu-arm@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Thomas Huth , Alistair Francis , Paolo Bonzini , Gustavo Romero Subject: Re: [PATCH 05/20] hw/net/xilinx_ethlite: Correct maximum RX buffer size Message-ID: References: <20241112181044.92193-1-philmd@linaro.org> <20241112181044.92193-6-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241112181044.92193-6-philmd@linaro.org> User-Agent: Mutt/2.2.12 (2023-09-09) Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=edgar.iglesias@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: KP9qb7SkKpgA On Tue, Nov 12, 2024 at 07:10:29PM +0100, Philippe Mathieu-Daudé wrote: > The current max RX bufsize is set to 0x800. This is > invalid, since it contains the MMIO registers region. > Add the correct definition and use it. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Edgar E. Iglesias > --- > hw/net/xilinx_ethlite.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index 0f59811c78..e6f6179fce 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -46,6 +46,8 @@ > #define R_RX_CTRL1 (0x1ffc / 4) > #define R_MAX (0x2000 / 4) > > +#define RX_BUFSZ_MAX 0x07e0 > + > #define GIE_GIE 0x80000000 > > #define CTRL_I 0x8 > @@ -195,7 +197,7 @@ static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size) > return -1; > } > > - if (size > (R_MAX - R_RX_BUF0 - rxbase) * 4) { > + if (size > RX_BUFSZ_MAX) { > trace_ethlite_pkt_size_too_big(size); > return -1; > } > -- > 2.45.2 >