From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:7d82:b0:1be9:327d:8ee3 with SMTP id wv2csp443815njc; Wed, 13 Nov 2024 07:24:29 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXJLzrv4ZpwZfRhYb2yvD17jfXH36/pBSVyYf3uRoYuk0pnxEUpu6JcoD6Lp+NIRSyoKQziJYwkKR3zvQ==@linaro.org X-Google-Smtp-Source: AGHT+IFq/ipjTH6kVkD2RBymUzGiF9eGHc6RBaGRQHlZDIWdg4ZZjXftwIi9zryvJeJzMekblhZx X-Received: by 2002:a05:6214:5c0a:b0:6d1:9e72:596a with SMTP id 6a1803df08f44-6d3dd073f0bmr46564566d6.37.1731511469733; Wed, 13 Nov 2024 07:24:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731511469; cv=none; d=google.com; s=arc-20240605; b=Yx7E9UOtBQQS0vAa1SxwaNm+DZMTWmlvdguPFF70CELFqYl7TCOfAzt7BhSzFsy/KJ e414OPKhK4aJkUAmdfLpQQAFi++fji9AAI1AU8YoSHdtUAMohuClntgpmwotJ5CmvsEC qY7GXjT6tdFnXUicHjo6QDzH/4MKz79QnHAGskICU/bZ2zcD64T7ICBIABScQ3VyNfSa 3R2rCeJfU/ASuN/IO6YwaxAbDz3g5CltMnfrCrnOl0PewuuDTB/3VRMn1MmHYyHXOWcp /1P2LGhjchaNbMjPR+6i7KfWynONpmwW6ClF3xQ3B8gwhed5D4Oob6DLV6ydGD+qFeAx Bwow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3mlrQINo70fJUvCp3E2to0cyk3dygkBiCxz57FeRoCc=; fh=VSFAhAPyAGhcVb5JiQ67EQ8lCeR/DPpfz4wW/Vd0yoY=; b=HpaXGI51CX3C9cZjGr4/+lqBAHZEwRN/YAw2kAJtO7WODsz+Jo9d7hW2ej2iIbm+ma lIhHUtTYgEFH9V8W0wM1D1zrdUy9o7NKAG46v5HTiSuzrY7aL5PW3PF/hbdLuFml9Sc+ HLhsWr9Zxh86F+j5uTSn1sBQQ76Fsui7477Wxo8cc9WbFQMn+x5zp4+DdHvcU8RCzL+N 8IAHmdTiOoj8NFeofJPlEFwbZzTZ0uq63O9fdFxDwwhqEWTXDVw7+zoArGVQ0ADnQ++P fOfKJrYdSr/gRz3lLPbGNlZlQzUn9DR1DQxzXHEra/QWZ4SHEs/b2XZVxhP2HV76dnGT K9lw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ISBjj33l; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6d39622a53bsi167366276d6.148.2024.11.13.07.24.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Nov 2024 07:24:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ISBjj33l; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBFE3-0005KT-Sb; Wed, 13 Nov 2024 10:24:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBFDy-0005JS-3z; Wed, 13 Nov 2024 10:24:06 -0500 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBFDu-0007Cq-Hi; Wed, 13 Nov 2024 10:24:04 -0500 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-53c78ebe580so947014e87.1; Wed, 13 Nov 2024 07:24:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731511440; x=1732116240; darn=nongnu.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3mlrQINo70fJUvCp3E2to0cyk3dygkBiCxz57FeRoCc=; b=ISBjj33lsZFvV1SadtjzL5RZRU/SzAGRIKX5mpz8cEPA8Cs1iTZjY/roRd/qvzs1H2 ifgpo08S2/rw0ttKgmx0cHe6rbRlAKYLL75nHOt0ZuXmw3pBfwJII32mUD61A8c97jp/ KFsqIaLucpEon4/07nSWLQQIst6NjQ+/7Hd6kXXVIngLj2/syL+XQ4xdXOI5t5CJANqW B/WzNNN98rm0Y7o8gaih5REqhibyjhPYNkrMJaBhecpv2T1yD14hM14kvtOo5jsZVcmB O/aBxKimFO+fup+6W19YYPP41VldSBXRkDOiMpAfNodpEWmlAVfyUui6Bwr2Os1WU4Ob gb3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731511440; x=1732116240; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3mlrQINo70fJUvCp3E2to0cyk3dygkBiCxz57FeRoCc=; b=wEX7ijfFbKF5JKBwfVigz376JxQJEayU0/bKomLcgG1JMGWUEYGeK5sgeTn0Yr3CBD opoA+D2Az9SVBYfQIFZCl+1g9roz+vxDmJaUNiCaiKkN3fORdHn+V2kQSleJ/sJPmNfK NeKJNjNnCOoe8QS9Lg4Nx2HU4jYP7H+i3P2mIXUot//Gg8sFth8BDhTp8+nZMfwOVHjq RoG+p0BuIH8zzlcnxhuWqaFa3LZ2MPylr8zevJmX60H7vKpvXnBem2+2M89BvfHMQqE8 jh6BvVb0RSnWFpfekV7y2/vs0gDuU+rUedxIziG8wgTqBWKF5gP1Sx2se7pH2QZQdeYx Ae1g== X-Forwarded-Encrypted: i=1; AJvYcCXmf2XI2/dRvFr4RidaqA2vUHZIz9kl9mB4RRt5YhS+S0tNf0r4oehMdTjm41sJTfGKeGsRbRQX6A==@nongnu.org X-Gm-Message-State: AOJu0YzpMCV8yGk55p2MxQSY3ddqxfA/3JuRQOH+HVdQ+LI3SlSwVfdK 1sXc+fBijz5gURJve6TKP8ygR+eBwv1Q0v+qDmn1uTk4gPcSoyPn X-Received: by 2002:a05:6512:31c9:b0:53d:a22b:fe7c with SMTP id 2adb3069b0e04-53da22bfff7mr869710e87.0.1731511439886; Wed, 13 Nov 2024 07:23:59 -0800 (PST) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53d826a7248sm2176169e87.127.2024.11.13.07.23.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 07:23:59 -0800 (PST) Date: Wed, 13 Nov 2024 16:23:58 +0100 From: "Edgar E. Iglesias" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , Peter Maydell , Anton Johansson , Jason Wang , qemu-arm@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Thomas Huth , Alistair Francis , Paolo Bonzini , Gustavo Romero Subject: Re: [PATCH 08/20] hw/net/xilinx_ethlite: Add addr_to_port_index() helper Message-ID: References: <20241112181044.92193-1-philmd@linaro.org> <20241112181044.92193-9-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241112181044.92193-9-philmd@linaro.org> User-Agent: Mutt/2.2.12 (2023-09-09) Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=edgar.iglesias@gmail.com; helo=mail-lf1-x133.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: t8CCmaa7CCqY On Tue, Nov 12, 2024 at 07:10:32PM +0100, Philippe Mathieu-Daudé wrote: > For a particular physical address within the EthLite MMIO range, > addr_to_port_index() returns which port is accessed. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/xilinx_ethlite.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index 20919b4f54..fe91891310 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -24,6 +24,7 @@ > > #include "qemu/osdep.h" > #include "qemu/module.h" > +#include "qemu/bitops.h" > #include "qom/object.h" > #include "qapi/error.h" > #include "exec/tswap.h" > @@ -86,6 +87,12 @@ static inline void eth_pulse_irq(XlnxXpsEthLite *s) > } > } > > +__attribute__((unused)) > +static unsigned addr_to_port_index(hwaddr addr) > +{ > + return extract64(addr, 11, 1); > +} > + Shouldn't you add addr_to_port_index in the following patch and avoid the temporary unused attribute? > static uint64_t > eth_read(void *opaque, hwaddr addr, unsigned int size) > { > @@ -190,7 +197,8 @@ static bool eth_can_rx(NetClientState *nc) > static ssize_t eth_rx(NetClientState *nc, const uint8_t *buf, size_t size) > { > XlnxXpsEthLite *s = qemu_get_nic_opaque(nc); > - unsigned int rxbase = s->port_index * (0x800 / 4); > + unsigned int port_index = s->port_index; > + unsigned int rxbase = port_index * (0x800 / 4); Hmm, AFAICT s->port_index is an unsigned int, what is the purpose of this change? > > /* DA filter. */ > if (!(buf[0] & 0x80) && memcmp(&s->conf.macaddr.a[0], buf, 6)) > -- > 2.45.2 >