From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:7d82:b0:1be9:327d:8ee3 with SMTP id wv2csp446403njc; Wed, 13 Nov 2024 07:28:19 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVJqzi0MjGkdax9it+aFYJL8xNkHWFuI1M1LrFZJ8KOsYsBvQD9pHvOrLsL31p/6BwMQBkmTFmTjeK0cA==@linaro.org X-Google-Smtp-Source: AGHT+IFNzb4ETt5/3x3GnqWvhyXUH/4LaLKqVrRP3WFsAahlm09w2PWrV/r3yAbYefTqP4urDXDg X-Received: by 2002:a05:620a:280c:b0:7af:cf07:905b with SMTP id af79cd13be357-7b331e88e91mr2830878485a.2.1731511699282; Wed, 13 Nov 2024 07:28:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1731511699; cv=none; d=google.com; s=arc-20240605; b=YMecSsHwXLN+v6rNoJmtQFNQpqr2eTpOyu5AubPfFwo/v5wyPaNBQDKC9xqFmxZ6WR OSh0DFeUWh8O1QoXqLEagCeX5DGWkruzC2CDCbmfhYFYG1boeP+dJpe0F26aOHei5r/D L/KZ86S4tk5iZ9Y1xxToxK0Ze6GPCftXNygJGqIhjKpKRTSzH/C4vYPaklfURX4FbyP8 AFhnOAwMRcJF6tMkMx6wzKfwxje/jr1zPixjMlteYI6gDbhOoZA2gV2QrbLa6sh6a1pk c0/JxN04KniIci0yI5JsAdT6aghXazt1WNeuL9CVQbe/vJxZCMS/VQTg2tCmnfkThU68 EhyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cW7Z+hSX7tjlqggj2j1/duDIEGUcr5dU9iH7GQHVG1M=; fh=i3GnzAqBFxumJw33N7uS2F4jtQT9xqZyhCL86iPv/A4=; b=OLuFT1nZz/F5x8apck5qfK/2byCUwMJwAkQbMtMwd6BdcuqxRFxwvdQGW/2kzXaiSN 3cjM4fVmOz2Ng27NgHsecHLcZkHdBrhFFt9CObBzQppLwDpHYLHNp/VInyObDujTH3Wq 3RxJHvbkQ37gMIaLdQeJLbWfS3mm5rJBVDhNYON6QNhhizxXdQwoCYSB+75V1hNqmlG4 nopRMImFckraCehDSpMYUsH/AbWWHI3CD9gn7ZWnNx6T/JYM+/KWSPnsqHQGiuXGXIQr +1+g7S7xYaQhq8Ygy3GH+t0Mdxgm5g2DQiMBeFz+4mRDVb+gKwaAhEOam082Wew0lMGV C2QA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OVHgBK5X; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7b32ac3d663si1710614485a.125.2024.11.13.07.28.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Nov 2024 07:28:19 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OVHgBK5X; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tBFI1-00081t-5o; Wed, 13 Nov 2024 10:28:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tBFHt-0007rq-J1; Wed, 13 Nov 2024 10:28:09 -0500 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tBFHs-0007dz-2g; Wed, 13 Nov 2024 10:28:09 -0500 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-539fe02c386so805659e87.0; Wed, 13 Nov 2024 07:28:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731511686; x=1732116486; darn=nongnu.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cW7Z+hSX7tjlqggj2j1/duDIEGUcr5dU9iH7GQHVG1M=; b=OVHgBK5Xv68j7GsMorCCaM/AAy82Qnw2qTAlvrlzb8oT35rm51yj4kVdkEB0Oqz5Eq ppa0CLQr6PRw+HyObe/JJCJXS5nRVQvJ4imjK2F4EP/+WRu/lZHkv8noXcksDcWXYw4m l7IutlHL13y9k7KDR/7eOnt2n/heehV/2iHElS8+MlP5dv8wLdfk7QaBskwNQ+SG9dVb mYF/9jEvn025OyonxUUFAobdEChQumuMN9YX+/baUOdmZ3BUGpHpVUUcx1NBOuFRmZMZ Sz9ri3Vohh5pabTlxTZ9FEPlkncAOJrSZ97QYO+HbJv+W7TrsHo9rGnoBjONFt019agy qumA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731511686; x=1732116486; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cW7Z+hSX7tjlqggj2j1/duDIEGUcr5dU9iH7GQHVG1M=; b=C5LVejjrM32FERk9O7gb8xYymwAqtSr+PBdovRhLOVMexUztDfQ7gRw5rDZlnJlyVb xIgDSpIiH/PRzk4fNbCkckvJMYw4SCTWhvrEZMAeBvbK8z7AQAzyEVzxJ0rUNFNGMJ++ Etc8+sueFhHazu5tyOaZfzqFcygxeH323GLE14Ze9jCX9Pq0MHWIykHVU3JPMu68LKUf MTx4MS4Q0QQ03K2RPUCx9fbh1L7DwQ8fzdyPylUo+D7GmE+fFZuCE5eeepbWhQPnwaOk tDv1n7GYsfy+G3pjuPOfZ4At++YEK/ldIQ32YQhEvAAdQy7StOkgBr8xGa2zDak4FHPQ Ozng== X-Forwarded-Encrypted: i=1; AJvYcCVJNY+lHhS0OlOQqD22fotKQZTe9TgsFT+6p7kopGQyi6BJQkya7fGnlTjjChYkuD9QVdgpRcOYqw==@nongnu.org X-Gm-Message-State: AOJu0YwrDVQh0u+u57e+WfhjO81FBa/5xV15jE4JVehXf9HNKxnww6x0 Yg/IbOovcq8jSkXf6bqqAfA1usCeFtIypgyLiVerRIWzMJexfEL0 X-Received: by 2002:a05:6512:3b99:b0:539:fc1b:36d1 with SMTP id 2adb3069b0e04-53d85ed3b42mr7451519e87.6.1731511685692; Wed, 13 Nov 2024 07:28:05 -0800 (PST) Received: from gmail.com (213-67-3-247-no600.tbcn.telia.com. [213.67.3.247]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53d826a9d9dsm2175032e87.205.2024.11.13.07.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 07:28:04 -0800 (PST) Date: Wed, 13 Nov 2024 16:28:04 +0100 From: "Edgar E. Iglesias" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , Peter Maydell , Anton Johansson , Jason Wang , qemu-arm@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Thomas Huth , Alistair Francis , Paolo Bonzini , Gustavo Romero Subject: Re: [PATCH 12/20] hw/net/xilinx_ethlite: Access TX_GIE register for each port Message-ID: References: <20241112181044.92193-1-philmd@linaro.org> <20241112181044.92193-13-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241112181044.92193-13-philmd@linaro.org> User-Agent: Mutt/2.2.12 (2023-09-09) Received-SPF: pass client-ip=2a00:1450:4864:20::12a; envelope-from=edgar.iglesias@gmail.com; helo=mail-lf1-x12a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: fWbWXgMl4WuI On Tue, Nov 12, 2024 at 07:10:36PM +0100, Philippe Mathieu-Daudé wrote: > Rather than accessing the registers within the mixed RAM/MMIO > region as indexed register, declare a per-port TX_GIE. This > will help to map the RAM as RAM (keeping MMIO as MMIO) in few > commits. > > Previous s->regs[R_TX_GIE0] and s->regs[R_TX_GIE1] are now > unused. Not a concern, this array will soon disappear. Reviewed-by: Edgar E. Iglesias > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/xilinx_ethlite.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index 605451a522..4cb4781e70 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -62,6 +62,8 @@ > typedef struct XlnxXpsEthLitePort > { > struct { > + uint32_t tx_gie; > + > uint32_t rx_ctrl; > } reg; > } XlnxXpsEthLitePort; > @@ -90,7 +92,7 @@ struct XlnxXpsEthLite > static inline void eth_pulse_irq(XlnxXpsEthLite *s) > { > /* Only the first gie reg is active. */ > - if (s->regs[R_TX_GIE0] & GIE_GIE) { > + if (s->port[0].reg.tx_gie & GIE_GIE) { > qemu_irq_pulse(s->irq); > } > } > @@ -126,6 +128,9 @@ eth_read(void *opaque, hwaddr addr, unsigned int size) > switch (addr) > { > case R_TX_GIE0: > + r = s->port[port_index].reg.tx_gie; > + break; > + > case R_TX_LEN0: > case R_TX_LEN1: > case R_TX_CTRL1: > @@ -189,10 +194,13 @@ eth_write(void *opaque, hwaddr addr, > > case R_TX_LEN0: > case R_TX_LEN1: > - case R_TX_GIE0: > s->regs[addr] = value; > break; > > + case R_TX_GIE0: > + s->port[port_index].reg.tx_gie = value; > + break; > + > default: > s->regs[addr] = tswap32(value); > break; > -- > 2.45.2 >