From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Stanislav Fomichev <sdf@fomichev.me>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
horms@kernel.org, donald.hunter@gmail.com, andrew+netdev@lunn.ch,
kory.maincent@bootlin.com, nicolas.dichtel@6wind.com
Subject: Re: [PATCH net-next 4/7] ynl: add missing pieces to ethtool spec to better match uapi header
Date: Wed, 13 Nov 2024 15:48:22 -0800 [thread overview]
Message-ID: <ZzU6xjufvS8wfcPO@mini-arch> (raw)
In-Reply-To: <20241113121445.08cdb25f@kernel.org>
On 11/13, Jakub Kicinski wrote:
> On Wed, 13 Nov 2024 10:10:20 -0800 Stanislav Fomichev wrote:
> > + attr-cnt-name: __ETHTOOL_UDP_TUNNEL_TYPE_CNT
>
> --ethtool-udp-tunnel-type-cnt ?
> or possibly
> __ethtool-udp-tunnel-type-cnt
>
> but let the codegen do the char conversion via c_upper()
The latter (__) seems more like a variable vs the first one that is more
like a flag. I'll try to stick to the __ form, but no strong preference
either.
next prev parent reply other threads:[~2024-11-13 23:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 18:10 [PATCH net-next 0/7] ethtool: generate uapi header from the spec Stanislav Fomichev
2024-11-13 18:10 ` [PATCH net-next 1/7] ynl: support attr-cnt-name attribute in legacy definitions Stanislav Fomichev
2024-11-13 20:03 ` Jakub Kicinski
2024-11-13 23:39 ` Stanislav Fomichev
2024-11-13 18:10 ` [PATCH net-next 2/7] ynl: support render " Stanislav Fomichev
2024-11-13 20:11 ` Jakub Kicinski
2024-11-13 23:40 ` Stanislav Fomichev
2024-11-14 2:33 ` Jakub Kicinski
2024-11-13 18:10 ` [PATCH net-next 3/7] ynl: support directional specs in ynl-gen-c.py Stanislav Fomichev
2024-11-13 20:12 ` Jakub Kicinski
2024-11-13 23:45 ` Stanislav Fomichev
2024-11-14 2:32 ` Jakub Kicinski
2024-11-13 18:10 ` [PATCH net-next 4/7] ynl: add missing pieces to ethtool spec to better match uapi header Stanislav Fomichev
2024-11-13 20:14 ` Jakub Kicinski
2024-11-13 23:48 ` Stanislav Fomichev [this message]
2024-11-13 18:10 ` [PATCH net-next 5/7] ethtool: separate definitions that are gonna be generated Stanislav Fomichev
2024-11-13 18:10 ` [PATCH net-next 6/7] ethtool: remove the comments that are not " Stanislav Fomichev
2024-11-13 18:10 ` [PATCH net-next 7/7] ethtool: regenerate uapi header from the spec Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzU6xjufvS8wfcPO@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.