From: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] systemtap: Add git revision to PV
Date: Thu, 14 Nov 2024 14:11:54 +0100 [thread overview]
Message-ID: <ZzX3GstbGu8K530z@bootlin-mathieu> (raw)
In-Reply-To: <CANNYZj-V=TDuXtWGmukPwDbQLeoowoc3wruG1heDAV0qS_r+yw@mail.gmail.com>
On Thu, Nov 14, 2024 at 01:59:29PM +0100, Alexander Kanavin wrote:
> On Thu, 14 Nov 2024 at 13:49, Mathieu Dubois-Briand via
> lists.openembedded.org
> <mathieu.dubois-briand=bootlin.com@lists.openembedded.org> wrote:
> > -PV = "5.1"
> > +PV = "5.1+git"
>
> I'm not sure I understand the reproducible 'magic' this would trigger
> in systemtap's usage of 'git describe', but if this does fix things,
> you need to leave a comment in the recipe asking people not to remove
> "+git". This is because "+git" suffix is typically used for something
> else: an indication that we're taking a revision that's several
> commits after the tagged version (e.g. containing important fixes).
>
> Alex
Yes, indeed having a comment here would be better, I will make a v2
adding it.
As for the reasoning leading to add +git in the revision, the bug entry
gives some context:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=15288#c10
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2024-11-14 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 12:48 [PATCH] systemtap: Add git revision to PV mathieu.dubois-briand
2024-11-14 12:59 ` [OE-core] " Alexander Kanavin
2024-11-14 13:11 ` Mathieu Dubois-Briand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzX3GstbGu8K530z@bootlin-mathieu \
--to=mathieu.dubois-briand@bootlin.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.