From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe: Mark preempt fence workqueue as reclaim
Date: Thu, 14 Nov 2024 13:27:17 -0500 [thread overview]
Message-ID: <ZzZBBX9pBazOOI16@intel.com> (raw)
In-Reply-To: <20241113171751.1677784-1-matthew.brost@intel.com>
On Wed, Nov 13, 2024 at 09:17:51AM -0800, Matthew Brost wrote:
> Preempt fences are in the path of reclaim, and we signal these fences in
> the preempt workqueue. With that, we need to mark the preempt fence
> workqueue with reclaim so that this workqueue can make forward progress
> during reclaim.
>
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 0e2dd691bdae..06d6db8b50f9 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -350,7 +350,8 @@ struct xe_device *xe_device_create(struct pci_dev *pdev,
> INIT_LIST_HEAD(&xe->pinned.external_vram);
> INIT_LIST_HEAD(&xe->pinned.evicted);
>
> - xe->preempt_fence_wq = alloc_ordered_workqueue("xe-preempt-fence-wq", 0);
> + xe->preempt_fence_wq = alloc_ordered_workqueue("xe-preempt-fence-wq",
> + WQ_MEM_RECLAIM);
> xe->ordered_wq = alloc_ordered_workqueue("xe-ordered-wq", 0);
> xe->unordered_wq = alloc_workqueue("xe-unordered-wq", 0, 0);
> xe->destroy_wq = alloc_workqueue("xe-destroy-wq", 0, 0);
> --
> 2.34.1
>
prev parent reply other threads:[~2024-11-14 19:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 17:17 [PATCH] drm/xe: Mark preempt fence workqueue as reclaim Matthew Brost
2024-11-13 19:13 ` ✓ CI.Patch_applied: success for " Patchwork
2024-11-13 19:13 ` ✓ CI.checkpatch: " Patchwork
2024-11-13 19:15 ` ✓ CI.KUnit: " Patchwork
2024-11-13 19:26 ` ✓ CI.Build: " Patchwork
2024-11-13 19:29 ` ✓ CI.Hooks: " Patchwork
2024-11-13 19:30 ` ✓ CI.checksparse: " Patchwork
2024-11-13 19:54 ` ✓ CI.BAT: " Patchwork
2024-11-14 6:14 ` ✗ CI.FULL: failure " Patchwork
2024-11-14 18:27 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzZBBX9pBazOOI16@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.