Re: [PATCH] cxl/pci: Fix potential bogus return value upon successful probing

[Fan Ni <nifan.cxl@gmail.com>]

On Thu, Nov 14, 2024 at 01:34:39PM -0800, Davidlohr Bueso wrote:
> If cxl_pci_ras_unmask() returns non-zero, cxl_pci_probe() will end up
> returning that value, instead of zero. Found by code inspeaction.
/inspeaction/inspection/

Other than that,

Reviewed-by: Fan Ni <fan.ni@samsung.com>

Fan
> 
> Fixes: 248529edc86 (cxl: add RAS status unmasking for CXL)
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
>  drivers/cxl/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> index 188412d45e0d..01092e5b3b46 100644
> --- a/drivers/cxl/pci.c
> +++ b/drivers/cxl/pci.c
> @@ -948,7 +948,7 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  
>  	pci_save_state(pdev);
>  
> -	return rc;
> +	return 0;
>  }
>  
>  static const struct pci_device_id cxl_mem_pci_tbl[] = {

-- 
Fan Ni