All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: dtrace@lists.linux.dev, dtrace-devel@oss.oracle.com
Subject: Re: [DTrace-devel] [PATCH v2 2/4] runtest: detect coredumps in more cases
Date: Thu, 14 Nov 2024 23:51:11 -0500	[thread overview]
Message-ID: <ZzbTPzfO/to3Khmn@oracle.com> (raw)
In-Reply-To: <20241114220108.95647-2-nick.alcock@oracle.com>

On Thu, Nov 14, 2024 at 10:01:06PM +0000, Nick Alcock via DTrace-devel wrote:
> Exitcode 139 == signal 11 == a coredump that should be reported as such,
> even if we can't find a core file anywhere.
> 
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>

Reviewed-by: Kris Van Hees <kris.van.hees@oracle.com>

> ---
>  runtest.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/runtest.sh b/runtest.sh
> index 46b532d7e161f..94634f80c2ebf 100755
> --- a/runtest.sh
> +++ b/runtest.sh
> @@ -1361,9 +1361,9 @@ for dt in $dtrace; do
>                  want_all_output=t
>              fi
>  
> -            if [[ -f core ]] || [[ "$(find $tmpdir -name core -print)" != "" ]]; then
> +            if [[ -f core ]] || [[ "$(find $tmpdir -name core -print)" != "" ]] || [[ $exitcode = 139 ]]; then
>                  # A coredump in the current directory or under the tmpdir.
> -                # Preserve it in the logdir.
> +                # Preserve it in the logdir, if possible.
>  
>                  mv core $logdir/$(echo $base | tr '/' '-').core 2>/dev/null || true
>                  find $tmpdir -name core -type f -print0 | xargs -0r -I'{}' mv --backup=numbered '{}' $logdir/$(echo $base | tr '/' '-').core
> -- 
> 2.46.0.278.g36e3a12567
> 
> 
> _______________________________________________
> DTrace-devel mailing list
> DTrace-devel@oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/dtrace-devel

  parent reply	other threads:[~2024-11-15  4:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-14 22:01 [PATCH v2 1/4] dtprobed: handle multiple providers in a single piece of DOF Nick Alcock
2024-11-14 22:01 ` [PATCH v2 2/4] runtest: detect coredumps in more cases Nick Alcock
2024-11-15  4:47   ` Eugene Loh
2024-11-15 20:56     ` Nick Alcock
2024-11-15  4:51   ` Kris Van Hees [this message]
2024-11-14 22:01 ` [PATCH v2 3/4] probe: do not try to reify probes from uncooked providers Nick Alcock
2024-11-15  4:53   ` Kris Van Hees
2024-11-15 20:57     ` Nick Alcock
2024-11-14 22:01 ` [PATCH v2 4/4] probe: make it possible to destroy probes in more cases Nick Alcock
2024-11-15  4:56   ` Kris Van Hees
2024-11-15 20:57     ` Nick Alcock
2024-11-15 22:55       ` Nick Alcock
2024-11-15  4:50 ` [PATCH v2 1/4] dtprobed: handle multiple providers in a single piece of DOF Kris Van Hees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzbTPzfO/to3Khmn@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.