From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe: Drop useless d3cold allowed message
Date: Fri, 15 Nov 2024 16:53:04 -0500 [thread overview]
Message-ID: <ZzfCwCZr0byTqGj1@intel.com> (raw)
In-Reply-To: <20241115192155.2050987-1-matthew.brost@intel.com>
On Fri, Nov 15, 2024 at 11:21:55AM -0800, Matthew Brost wrote:
> This message just spams dmesg providing little benefit. Remove it.
I don't believe it is useless, but I also hate the spammers...
perhaps we could bring the status of it in some debugfs form
as a replacement?
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/xe/xe_pm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 40f7c844ed44..80699dbeb2e9 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -738,9 +738,6 @@ void xe_pm_d3cold_allowed_toggle(struct xe_device *xe)
> xe->d3cold.allowed = false;
>
> mutex_unlock(&xe->d3cold.lock);
> -
> - drm_dbg(&xe->drm,
> - "d3cold: allowed=%s\n", str_yes_no(xe->d3cold.allowed));
> }
>
> /**
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-11-15 21:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 19:21 [PATCH] drm/xe: Drop useless d3cold allowed message Matthew Brost
2024-11-15 19:26 ` ✓ CI.Patch_applied: success for " Patchwork
2024-11-15 19:27 ` ✓ CI.checkpatch: " Patchwork
2024-11-15 19:28 ` ✓ CI.KUnit: " Patchwork
2024-11-15 19:37 ` ✗ CI.Build: failure " Patchwork
2024-11-15 20:57 ` ✓ CI.Patch_applied: success for drm/xe: Drop useless d3cold allowed message (rev2) Patchwork
2024-11-15 20:57 ` ✓ CI.checkpatch: " Patchwork
2024-11-15 20:58 ` ✓ CI.KUnit: " Patchwork
2024-11-15 21:16 ` ✓ CI.Build: " Patchwork
2024-11-15 21:17 ` ✗ CI.Hooks: failure " Patchwork
2024-11-15 21:18 ` ✓ CI.checksparse: success " Patchwork
2024-11-15 21:38 ` ✗ CI.BAT: failure " Patchwork
2024-11-15 21:53 ` Rodrigo Vivi [this message]
2024-11-15 23:24 ` [PATCH] drm/xe: Drop useless d3cold allowed message Matthew Brost
2024-11-19 18:50 ` Rodrigo Vivi
2024-11-19 21:01 ` Lucas De Marchi
2024-11-19 22:03 ` Matthew Brost
2024-11-19 23:35 ` Lucas De Marchi
2024-11-16 2:41 ` ✗ CI.FULL: failure for drm/xe: Drop useless d3cold allowed message (rev2) Patchwork
2024-11-18 17:53 ` ✓ CI.Patch_applied: success for drm/xe: Drop useless d3cold allowed message (rev3) Patchwork
2024-11-18 17:53 ` ✓ CI.checkpatch: " Patchwork
2024-11-18 17:54 ` ✓ CI.KUnit: " Patchwork
2024-11-18 18:12 ` ✓ CI.Build: " Patchwork
2024-11-18 18:14 ` ✓ CI.Hooks: " Patchwork
2024-11-18 18:16 ` ✓ CI.checksparse: " Patchwork
2024-11-18 18:46 ` ✗ CI.BAT: failure " Patchwork
2024-11-19 0:06 ` ✗ CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzfCwCZr0byTqGj1@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.