From: Baoquan He <bhe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
linux-kernel@vger.kernel.org, bp@alien8.de, x86@kernel.org
Subject: Re: [PATCH 2/3] x86/ioremap: use helper to implement xxx_is_setup_data()
Date: Sat, 16 Nov 2024 21:28:17 +0800 [thread overview]
Message-ID: <Zzid8dMZHAmfyUI9@MiWiFi-R3L-srv> (raw)
In-Reply-To: <ZzhZinP5QLwHrPYa@gmail.com>
On 11/16/24 at 09:36am, Ingo Molnar wrote:
>
> * Tom Lendacky <thomas.lendacky@amd.com> wrote:
>
> > On 11/14/24 19:21, Baoquan He wrote:
> > > This simplifies codes a lot by removing the duplicated code handling.
> >
> > You should probably squash this with the first patch.
> >
> > >
> > > And also remove the similar code comment above of them.
> > >
> > > While at it, add __ref to memremap_is_setup_data() to avoid
> >
> > The __ref shouldn't be needed if you remove the __init from the helper
> > function.
>
> Yeah.
>
> Baoquan, I've zapped these 3 commits from tip:x86/mm for now, mind resending them the init
> annotations fixed?
Sure, will resend. Thanks.
next prev parent reply other threads:[~2024-11-16 13:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 1:21 [PATCH 0/3] x86/ioremap: clean up the mess in xxx_is_setup_data Baoquan He
2024-11-15 1:21 ` [PATCH 1/3] x86/ioremap: introduce helper to check if physical address is in setup_data Baoquan He
2024-11-15 11:28 ` [tip: x86/mm] x86/ioremap: Introduce " tip-bot2 for Baoquan He
2024-11-15 14:22 ` [PATCH 1/3] x86/ioremap: introduce " Tom Lendacky
2024-11-15 23:25 ` Baoquan He
2024-11-15 1:21 ` [PATCH 2/3] x86/ioremap: use helper to implement xxx_is_setup_data() Baoquan He
2024-11-15 11:28 ` [tip: x86/mm] x86/ioremap: Use " tip-bot2 for Baoquan He
2024-11-15 14:24 ` [PATCH 2/3] x86/ioremap: use " Tom Lendacky
2024-11-16 8:36 ` Ingo Molnar
2024-11-16 13:28 ` Baoquan He [this message]
2024-11-15 1:21 ` [PATCH 3/3] x86/mm: clean up unused parameters of functions Baoquan He
2024-11-15 11:28 ` [tip: x86/mm] x86/mm: Clean " tip-bot2 for Baoquan He
2024-11-15 14:27 ` [PATCH 3/3] x86/mm: clean " Tom Lendacky
2024-11-15 1:23 ` [PATCH 0/3] x86/ioremap: clean up the mess in xxx_is_setup_data Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zzid8dMZHAmfyUI9@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.