From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8315B1B5EA4 for ; Mon, 18 Nov 2024 16:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731949062; cv=none; b=MnISyQwJ8gUXomTc1Teij58RkyvBxKFuJ46ikspNFe+AVN1o7gBUpYMwoVWXV6iYRSj1SP2OjH5GKg7aDC6MiGQgVKA8Rp/y+tdtjpEDb1isUprHI+3VrAJih43Z68jZKpyovpyutxPejpWTx6veGUmcEUhDxrbJz+QMvmAWLlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731949062; c=relaxed/simple; bh=4ifOo5HliVyw7qwcm+9kfBZTDeIkGDadeXt3oI+BDoc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bG42fHH6eyfyXjvqE2bnT9nC6efVGs3TUSFCKhpiMhl5aYsa7aA2NKFEMofco/bLe0ofoMXm4jfSApUb+LuNZAR3xnSzZ2ZtdsbVkVNk5T5bBy4lOURc7FwWXLEN9lIaNULN8/TF2snq346ThWYyBV+1ENWOqISU8wkH7UVsYqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=JRWVdoEL; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="JRWVdoEL" Date: Mon, 18 Nov 2024 08:57:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731949058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NnvzeJ3O9gPeNSZCwNiEkgkNPJiLx/mp4rGBRuic5qA=; b=JRWVdoELd4W5uZS4m8k0rySCUmgr8kw73NEKQaAIu4akIv8GogBCWfI7lt037Dw8HSa+0N I6s5J/U3Xf1uffTPuXaXaEBz6stJDwqxnhBbsl4QMRhhZ7ZWjUyFFLpYZsK036aRgRB8OS XnWqiNUit3fJCa0Yknl5YzBQYY448Ho= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Prabhakar Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Colton Lewis , Geert Uytterhoeven , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Chris Paterson , Andrew Jones Subject: Re: [PATCH v2] riscv: perf: Drop defining `perf_instruction_pointer()` and `perf_misc_flags()` Message-ID: References: <20241116160506.5324-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-perf-users@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241116160506.5324-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Migadu-Flow: FLOW_OUT On Sat, Nov 16, 2024 at 04:05:06PM +0000, Prabhakar wrote: > From: Lad Prabhakar > > With commit 2c47e7a74f44 ("perf/core: Correct perf sampling with guest > VMs"), the perf core now handles the functionality previously requiring > arch-specific definitions of `perf_instruction_pointer()` and > `perf_misc_flags()`. As these definitions are no longer necessary for > RISC-V, this patch removes their implementation and declarations. > > This change also fixes the following build issue on RISC-V: > > ./include/linux/perf_event.h:1679:84: error: macro "perf_misc_flags" passed 2 arguments, but takes just 1 > ./include/linux/perf_event.h:1679:22: error: 'perf_misc_flags' redeclared as different kind of symbol > ./include/linux/perf_event.h:1680:22: error: conflicting types for 'perf_instruction_pointer'; have 'long unsigned int(struct perf_event *, struct pt_regs *)' > > The above errors arise from conflicts between the core definitions in > `linux/perf_event.h` and the RISC-V-specific definitions in > `arch/riscv/include/asm/perf_event.h`. Removing the RISC-V-specific > definitions resolves these issues and aligns the architecture with the > updated perf core. > > Fixes: 2c47e7a74f44 ("perf/core: Correct perf sampling with guest VMs") > Reported-by: Chris Paterson > Signed-off-by: Lad Prabhakar > Reviewed-by: Andrew Jones Reviewed-by: Oliver Upton -- Thanks, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE6FED591A5 for ; Mon, 18 Nov 2024 16:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hLR+OSivakE93csFsFjAYVCj2y1zK0l6ZH/aiyWhoiM=; b=p7QM1NZQxFb8zW jEByY+K74qP26dUl1ZU7qykxriH16jORnrISN9pKFFBq5XTLK6a6RVAF1eRGF0KRxZlJxmdM0cciB wL1wZU36Axh71vBubA81srkklcSfbcgepdS1hMl32DqY67p3+SL+SV/xiC6vUPeshYIKrUe+UQliH zVftv1maHef5B0szObSRwKcGVyFQURDXUlMLYogzRZq6d3bi6IqBkv4ipDt5zO+bpGKUM139Q/Qtq 8MyS5z0+v7g+uSMODhk43YbgC78vSpZ7QCgWS3v/9Ed/ri7T3wuLHz9cH2m0aTRt6x+AEXqOC37qn tlAqwbbuay0drkXE6gVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tD54M-0000000A8cd-3qtZ; Mon, 18 Nov 2024 16:57:46 +0000 Received: from out-170.mta1.migadu.com ([2001:41d0:203:375::aa]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tD54K-0000000A8bk-1aJm for linux-riscv@lists.infradead.org; Mon, 18 Nov 2024 16:57:45 +0000 Date: Mon, 18 Nov 2024 08:57:28 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731949058; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NnvzeJ3O9gPeNSZCwNiEkgkNPJiLx/mp4rGBRuic5qA=; b=JRWVdoELd4W5uZS4m8k0rySCUmgr8kw73NEKQaAIu4akIv8GogBCWfI7lt037Dw8HSa+0N I6s5J/U3Xf1uffTPuXaXaEBz6stJDwqxnhBbsl4QMRhhZ7ZWjUyFFLpYZsK036aRgRB8OS XnWqiNUit3fJCa0Yknl5YzBQYY448Ho= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Prabhakar Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Colton Lewis , Geert Uytterhoeven , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Chris Paterson , Andrew Jones Subject: Re: [PATCH v2] riscv: perf: Drop defining `perf_instruction_pointer()` and `perf_misc_flags()` Message-ID: References: <20241116160506.5324-1-prabhakar.mahadev-lad.rj@bp.renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241116160506.5324-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241118_085744_558052_DB5A4EB0 X-CRM114-Status: GOOD ( 12.12 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Sat, Nov 16, 2024 at 04:05:06PM +0000, Prabhakar wrote: > From: Lad Prabhakar > > With commit 2c47e7a74f44 ("perf/core: Correct perf sampling with guest > VMs"), the perf core now handles the functionality previously requiring > arch-specific definitions of `perf_instruction_pointer()` and > `perf_misc_flags()`. As these definitions are no longer necessary for > RISC-V, this patch removes their implementation and declarations. > > This change also fixes the following build issue on RISC-V: > > ./include/linux/perf_event.h:1679:84: error: macro "perf_misc_flags" passed 2 arguments, but takes just 1 > ./include/linux/perf_event.h:1679:22: error: 'perf_misc_flags' redeclared as different kind of symbol > ./include/linux/perf_event.h:1680:22: error: conflicting types for 'perf_instruction_pointer'; have 'long unsigned int(struct perf_event *, struct pt_regs *)' > > The above errors arise from conflicts between the core definitions in > `linux/perf_event.h` and the RISC-V-specific definitions in > `arch/riscv/include/asm/perf_event.h`. Removing the RISC-V-specific > definitions resolves these issues and aligns the architecture with the > updated perf core. > > Fixes: 2c47e7a74f44 ("perf/core: Correct perf sampling with guest VMs") > Reported-by: Chris Paterson > Signed-off-by: Lad Prabhakar > Reviewed-by: Andrew Jones Reviewed-by: Oliver Upton -- Thanks, Oliver _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv