From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ido Schimmel <idosch@idosch.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] rocker: fix link status detection in rocker_carrier_init()
Date: Tue, 19 Nov 2024 10:28:20 +0100 [thread overview]
Message-ID: <ZzxaNFWQlamJJjFS@nanopsycho.orion> (raw)
In-Reply-To: <20241118184201.3d1e7a13@kernel.org>
Tue, Nov 19, 2024 at 03:42:01AM CET, kuba@kernel.org wrote:
>On Thu, 14 Nov 2024 18:19:46 +0300 Dmitry Antipov wrote:
>> Since '1 << rocker_port->pport' may be undefined for port >= 32,
>> cast the left operand to 'unsigned long long' like it's done in
>> 'rocker_port_set_enable()' above. Compile tested only.
>
>Jiri, random thought - any sense if anyone still uses rocker?
>IIUC the goal was similar to netdevsim - SW testing / modeling
>but we don't really have any upstream tests against it..
Afaik some people are still using it for testing. I got couple emails in
the past. Not sure now. The thing is, rocker has real datapath,
comparing to netdevsim.
>
>Unrelated to the patch, so dropping the author from CC.
next prev parent reply other threads:[~2024-11-19 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 15:19 [PATCH] rocker: fix link status detection in rocker_carrier_init() Dmitry Antipov
2024-11-19 2:42 ` Jakub Kicinski
2024-11-19 9:28 ` Jiri Pirko [this message]
2024-11-19 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzxaNFWQlamJJjFS@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.