From: Benjamin Marzinski <bmarzins@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>,
dm-devel@lists.linux.dev, Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH v3 1/1] multipathd: move systemd watchdog handling into daemon
Date: Tue, 19 Nov 2024 12:08:19 -0500 [thread overview]
Message-ID: <ZzzGAyrIvujCOMG6@redhat.com> (raw)
In-Reply-To: <20241119161218.708117-2-mwilck@suse.com>
On Tue, Nov 19, 2024 at 05:12:18PM +0100, Martin Wilck wrote:
> Only multipathd needs to take care of notifying systemd. There's
> no need to track this information in struct config, or to limit our
> checker interval to it, as checkerloop() wakes up every second anyway.
>
> While at it, fix the watchdog enablement logic:
>
> - the watchdog should only be active if WATCHDOG_PID is either unset,
> or matches the daemon's PID, and if WATCHDOG_USEC is not 0.
> - the watchdog should trigger twice per systemd-set interval.
> - if WatchdogSec= is set to an unreasonable value, make a smarter
> choice than just disabling the watchdog, and print a more meaningful
> error message.
>
> Use timestamp comparison to make sure the watchdog is triggered even
> if a checkerloop iteration takes more than a second.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
prev parent reply other threads:[~2024-11-19 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 16:12 [PATCH v3 0/1] multipath-tools: fixes for systemd watchdog Martin Wilck
2024-11-19 16:12 ` [PATCH v3 1/1] multipathd: move systemd watchdog handling into daemon Martin Wilck
2024-11-19 17:08 ` Benjamin Marzinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzzGAyrIvujCOMG6@redhat.com \
--to=bmarzins@redhat.com \
--cc=christophe.varoqui@opensvc.com \
--cc=dm-devel@lists.linux.dev \
--cc=martin.wilck@suse.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.