From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: UNGLinuxDriver@microchip.com, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
jacob.e.keller@intel.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 4/8] net: sparx5: use phy_interface_mode_is_rgmii()
Date: Tue, 19 Nov 2024 20:08:21 +0000 [thread overview]
Message-ID: <ZzzwNci1cHqsfHm4@shell.armlinux.org.uk> (raw)
In-Reply-To: <20241118-sparx5-lan969x-switch-driver-4-v3-4-3cefee5e7e3a@microchip.com>
Hi,
On Mon, Nov 18, 2024 at 02:00:50PM +0100, Daniel Machon wrote:
> diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c b/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c
> index f8562c1a894d..cb55e05e5611 100644
> --- a/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c
> +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_phylink.c
> @@ -32,6 +32,9 @@ sparx5_phylink_mac_select_pcs(struct phylink_config *config,
> {
> struct sparx5_port *port = netdev_priv(to_net_dev(config->dev));
>
> + if (phy_interface_mode_is_rgmii(interface))
> + return NULL;
> +
> return &port->phylink_pcs;
Maybe turn this into positive logic - return the PCS only when the
interface mode requires the PCS?
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-11-19 20:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 13:00 [PATCH net-next v3 0/8] net: lan969x: add RGMII support Daniel Machon
2024-11-18 13:00 ` [PATCH net-next v3 1/8] net: sparx5: do some preparation work Daniel Machon
2024-11-18 13:00 ` [PATCH net-next v3 2/8] net: sparx5: add function for RGMII port check Daniel Machon
2024-11-18 13:00 ` [PATCH net-next v3 3/8] net: sparx5: use is_port_rgmii() throughout Daniel Machon
2024-11-18 13:00 ` [PATCH net-next v3 4/8] net: sparx5: use phy_interface_mode_is_rgmii() Daniel Machon
2024-11-19 20:08 ` Russell King (Oracle) [this message]
2024-11-20 10:57 ` Daniel Machon
2024-11-18 13:00 ` [PATCH net-next v3 5/8] net: sparx5: verify RGMII speeds Daniel Machon
2024-11-18 13:00 ` [PATCH net-next v3 6/8] net: lan969x: add RGMII registers Daniel Machon
2024-11-18 13:00 ` [PATCH net-next v3 7/8] net: lan969x: add RGMII implementation Daniel Machon
2024-11-18 13:00 ` [PATCH net-next v3 8/8] dt-bindings: net: sparx5: document RGMII delays Daniel Machon
2024-11-19 18:22 ` Rob Herring
2024-11-20 10:53 ` Daniel Machon
2024-11-19 3:04 ` [PATCH net-next v3 0/8] net: lan969x: add RGMII support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzzwNci1cHqsfHm4@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=jacob.e.keller@intel.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.