From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EB723F482E for ; Thu, 16 Jul 2026 11:10:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784200249; cv=none; b=nWrp+LjyYCcr+Cq9OntcB/Qa/M1pKa35B/yYZcGLVOTmgi28p2ypmZWN7NTGRqyCYVjAbo1w2kH0Tm58ww+TxKas6V4qL24mH84NeIsC1f1ra/K3zki3pxlHSKGZGYJU7isWOGocogQgrr2gHOhpa8ZGN01rgUa22NjwZpA4GH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784200249; c=relaxed/simple; bh=9m3dtFy3lnWgLLwvZA3yYksPHu7QLIWIjY5n+08rVH4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZXqbI752+9GRtcfVmeMSlgBgqPLSxfyWQclCnZLzErcuD9wPOtwVI21QGz33hTk/GkIc96LIW3zvONjMEFGDI27gGNd96/r2lF2ZwXbxR3vlWnPxNHmh77s4yFwnTHSjsUBL4R6pp0T/GDttqqzEgOWQVidI1C+wjYyjs0xC2yk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IME58BGp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IME58BGp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED5D21F000E9; Thu, 16 Jul 2026 11:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784200243; bh=jmPPDuiYXTng8WxmgDueZEPnjNUhF5XqoTiTiA+PltM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=IME58BGp+4VoXUsAiKFtPTar/BWz6xqDCOl6H1G++hdJbXGomex8JvqFdnl5AYWFh IKpFdkzzBQx42d2q4Z+wbhDbCy79GFK99CluePEU7ywNJHcs3iah/x54b0GZzrFKA6 1LdhWEoh3Ik9uf0BpFV+iVoEQR9u0FE12zRLCZKj+pRFVmoofGNKe6zSdVNQsS4I0r BrHvm1togaouelHFOds5Xi8U5JLcI2xfLBWOVRWk1RcIAQm9iXx8/sfXOZ61WojUcw 4HV1+wsEeRB3pKr1+0GYembo0QynfBRkXlOlMvYWCqr81dtu4ucVmIMz0yQoW0xQX/ BBlIH1IZu4sfg== Message-ID: Date: Thu, 16 Jul 2026 13:10:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mm: mglru: promote mapped executable folios after first usage To: Baolin Wang , akpm@linux-foundation.org, ljs@kernel.org, hannes@cmpxchg.org Cc: riel@surriel.com, liam@infradead.org, vbabka@kernel.org, harry@kernel.org, jannh@google.com, lance.yang@linux.dev, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, mhocko@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <7e3a5f6bdf70e0237027025f4593a3874d411f65.1784197559.git.baolin.wang@linux.alibaba.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <7e3a5f6bdf70e0237027025f4593a3874d411f65.1784197559.git.baolin.wang@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/16/26 12:46, Baolin Wang wrote: > Classical LRU protects mapped executable file folios through commit > 8cab4754d24a0 ("vmscan: make mapped executable pages the first class > citizen") and commit c909e99364c8 ("vmscan: activate executable pages > after first usage"), giving executable code a better chance to stay in > memory, avoiding IO thrashing and improving workload performance. > > However, MGLRU's protection of mapped executable file folios is less > reliable. Although shrink_folio_list() checks references, the access flag > of mapped executable file folios may have already been checked and > cleared by lru_gen_look_around() or walk_mm(). Additionally, > folio_update_gen() or lru_gen_set_refs() only sets the 'PG_referenced' > flag for mapped executable file folios, which causes shrink_folio_list() > to ignore the first usage of these mapped executable file folios and > reclaim them easily. > > Follow the classical LRU's logic, promoting mapped executable file folios > after their first usage in folio_update_gen() and lru_gen_set_refs(), > giving executable code a better chance to stay in memory. > > On my 32-core Arm machine, with the memcg limit set to 2G, running > 'make -j32' to build kernel showed some improvement in sys time. > > base patched > 9248.543s 7861.579s > > Signed-off-by: Baolin Wang > --- > include/linux/mm_inline.h | 6 ++++++ > mm/vmscan.c | 41 ++++++++++++++++++++++++--------------- > 2 files changed, 31 insertions(+), 16 deletions(-) > > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > index b5c4dc0f3fe3..30fdf1056312 100644 > --- a/include/linux/mm_inline.h > +++ b/include/linux/mm_inline.h > @@ -30,6 +30,12 @@ static inline int folio_is_file_lru(const struct folio *folio) > return !folio_test_swapbacked(folio); > } > > +static inline bool folio_is_exec_file(const struct folio *folio, > + const vma_flags_t *vma_flags) > +{ > + return vma_flags_test(vma_flags, VMA_EXEC_BIT) && folio_is_file_lru(folio); > +} I don't quite like a generic folio_is* helper to consume vma flags. Whether it is executable depends on the VMA. When called from a non-exec VMA it would just give a wrong answer. Not sure if something like "is_executable_file_folio()"/"is_exec_file_folio" would be better, to distinguish from the actualy folio_is* helpers that are independent of context. Also, can this helper just go to vmscan.c? -- Cheers, David