From: Qingfang Deng <qingfang.deng@linux.dev>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] ppp: annotate concurrent dev->stats accesses
Date: Thu, 16 Jul 2026 15:55:35 +0800 [thread overview]
Message-ID: <a0100b31-d961-4f5d-ba42-31fb126481ea@linux.dev> (raw)
In-Reply-To: <20260715055541.1147542-1-edumazet@google.com>
On 2026/7/15 13:55, Eric Dumazet wrote:
> dev->stats fields can be updated concurrently from multiple CPUs
> without synchronization.
>
> Use DEV_STATS_INC() for stats increments and DEV_STATS_READ()
> when reading dev->stats in ppp_get_stats64() and ppp_get_stats()
> to avoid data races.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> drivers/net/ppp/ppp_generic.c | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Qingfang Deng <qingfang.deng@linux.dev>
prev parent reply other threads:[~2026-07-16 7:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 5:55 [PATCH net] ppp: annotate concurrent dev->stats accesses Eric Dumazet
2026-07-16 7:55 ` Qingfang Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0100b31-d961-4f5d-ba42-31fb126481ea@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.