From: Florian Fainelli <f.fainelli@gmail.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv
Date: Tue, 30 May 2017 12:59:23 -0700 [thread overview]
Message-ID: <a01d88e5-5bb2-dd83-e416-daa6ebe0fb66@gmail.com> (raw)
In-Reply-To: <87shjmyv9m.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
On 05/30/2017 12:55 PM, Vivien Didelot wrote:
> Hi Florian,
>
> Florian Fainelli <f.fainelli@gmail.com> writes:
>
>> I actually have a patch pending that adds support for HW
>> insertion/extraction of switch tags (broadcom HW supports that) which
>> require the orig_dev to be there so we know what features are supported
>> by the master network device.
>
> Is orig_dev really needed in the tagging implementation, or only in the
> layer above? (dsa_slave_xmit and dsa_switch_rcv.)
It's needed:
https://github.com/ffainelli/linux/commits/switch-tag
https://github.com/ffainelli/linux/commit/61f9ca70dd21bb8c1615f959934cd0ce80a2f3ce
>
>> Do you mind dropping this one from your patch series?
>
> I don't mind if they are actually needed in taggers. I'd wait for
> reviews of the other patches before respinning though.
>
> Thanks,
>
> Vivien
>
--
Florian
next prev parent reply other threads:[~2017-05-30 19:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 18:33 [PATCH net-next v2 0/6] net: dsa: tagger simplification Vivien Didelot
2017-05-30 18:33 ` [PATCH net-next v2 1/6] net: dsa: comment hot path requirements Vivien Didelot
2017-05-30 20:34 ` Florian Fainelli
2017-05-30 18:33 ` [PATCH net-next v2 2/6] net: dsa: do not cast dst Vivien Didelot
2017-05-30 20:34 ` Florian Fainelli
2017-05-30 18:33 ` [PATCH net-next v2 3/6] net: dsa: remove dsa_uses_tagged_protocol Vivien Didelot
2017-05-30 20:47 ` Florian Fainelli
2017-05-30 18:33 ` [PATCH net-next v2 4/6] net: dsa: remove unused arguments of tagger rcv Vivien Didelot
2017-05-30 19:03 ` Florian Fainelli
2017-05-30 19:55 ` Vivien Didelot
2017-05-30 19:59 ` Florian Fainelli [this message]
2017-05-30 20:03 ` Vivien Didelot
2017-05-30 18:33 ` [PATCH net-next v2 5/6] net: dsa: remove out_drop label in taggers rcv Vivien Didelot
2017-05-30 20:48 ` Florian Fainelli
2017-05-30 18:33 ` [PATCH net-next v2 6/6] net: dsa: factor skb freeing on xmit Vivien Didelot
2017-05-30 20:59 ` Florian Fainelli
2017-05-31 18:18 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a01d88e5-5bb2-dd83-e416-daa6ebe0fb66@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.