From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "Varghese, Vipin" <Vipin.Varghese@amd.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <Ferruh.Yigit@amd.com>
Subject: RE: [PATCH] usertools: suggest use of hwloc for new cpu
Date: Mon, 14 Aug 2023 09:25:36 +0000 [thread overview]
Message-ID: <a0307e96ecc548f2b4d1a7c41b1bcc52@huawei.com> (raw)
In-Reply-To: <ZNnrR42sSNYqx8Uh@bricha3-MOBL.ger.corp.intel.com>
> On Sun, Aug 13, 2023 at 08:52:01AM -0700, Stephen Hemminger wrote:
> > On Sun, 13 Aug 2023 02:12:03 +0000
> > "Varghese, Vipin" <Vipin.Varghese@amd.com> wrote:
> >
> > > >
> > > > On Sat, 12 Aug 2023 06:27:20 +0530
> > > > Vipin Varghese <vipin.varghese@amd.com> wrote:
> > > >
> > > > > Most modern processor now supports numa by partitioning NUMA based on
> > > > > CPU-IO & Last Level Cache within the same socket.
> > > > > As per the discussion in mailing list, suggesting the make use of
> > > > > hw-loc for such scenarios.
> > > > >
> > > > > Signed-off-by: Vipin Varghese <vipin.varghese@amd.com>
> > > >
> > > > NAK, no scripting hwloc, it is ugly and creates a dependency that is not listed
> > > > in DPDK packaging.
> > >
> > > There is no calls to hwloc within in thescript. Hence not clear what does ` NAK, no scripting hwloc it is ugly and creates a
> dependency that is not listed in DPDK packaging.`.
> > >
> > > Requesting to cross check why NAK is shared for `print` as suggestion. Hence, I have disagree to this.
> >
> > Sorry, I misinterpreted what the print's were doing.
> > Better off not to list exact flags, the lstopo may change and user may want different
> > format anyway.
> >
> > How about something like this?
> >
> >
> > doc/guides/rel_notes/deprecation.rst | 5 +++++
> > usertools/cpu_layout.py | 5 +++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index 317875c5054b..25a116900dfb 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -185,3 +185,8 @@ Deprecation Notices
> > will be deprecated and subsequently removed in DPDK 24.11 release.
> > Before this, the new port library API (functions rte_swx_port_*)
> > will gradually transition from experimental to stable status.
> > +
> > +* cpulayout: The CPU layout script is unable to deal with all the possible
> > + complexities of modern CPU topology. Other existing tools offer more
> > + features and do a better job with keeping up with innovations.
> > + Therefore it will be deprecated and removed in a future release.
>
> Does the script really do that bad a job? While I can understand us looking
> to recommend alternatives, I actually find the script in it's current form
> really handy - much more so than working out the exact flags for lstopo
> etc. Since it's not a large maintenance burden, I'd request we keep it
> around - while still recommending lstopo to users.
+1
I do use it on regular basis.
It would be a pity if it will be gone.
Konstantin
next prev parent reply other threads:[~2023-08-14 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 0:57 [PATCH] usertools: suggest use of hwloc for new cpu Vipin Varghese
2023-08-12 15:00 ` Stephen Hemminger
2023-08-13 2:12 ` Varghese, Vipin
2023-08-13 15:52 ` Stephen Hemminger
2023-08-13 16:35 ` Varghese, Vipin
2023-08-14 8:52 ` Bruce Richardson
2023-08-14 9:13 ` Morten Brørup
2023-08-14 9:25 ` Konstantin Ananyev [this message]
2023-09-04 10:11 ` Ferruh Yigit
2023-09-04 10:20 ` Bruce Richardson
2023-09-04 13:22 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2023-08-12 0:37 Vipin Varghese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0307e96ecc548f2b4d1a7c41b1bcc52@huawei.com \
--to=konstantin.ananyev@huawei.com \
--cc=Ferruh.Yigit@amd.com \
--cc=Vipin.Varghese@amd.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.