From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiubo Li Subject: Re: [RFC PATCH] ceph: fix the debug message for calc_layout Date: Mon, 3 Feb 2020 18:46:50 +0800 Message-ID: References: <20200203040133.39319-1-xiubli@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29611 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727309AbgBCKrF (ORCPT ); Mon, 3 Feb 2020 05:47:05 -0500 In-Reply-To: Content-Language: en-US Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Ilya Dryomov Cc: Jeff Layton , "Yan, Zheng" , Sage Weil , Patrick Donnelly , Ceph Development On 2020/2/3 18:25, Ilya Dryomov wrote: > On Mon, Feb 3, 2020 at 5:02 AM wrote: >> From: Xiubo Li >> >> Signed-off-by: Xiubo Li >> --- >> net/ceph/osd_client.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c >> index 108c9457d629..6afe36ffc1ba 100644 >> --- a/net/ceph/osd_client.c >> +++ b/net/ceph/osd_client.c >> @@ -113,10 +113,11 @@ static int calc_layout(struct ceph_file_layout *layout, u64 off, u64 *plen, >> if (*objlen < orig_len) { >> *plen = *objlen; >> dout(" skipping last %llu, final file extent %llu~%llu\n", >> - orig_len - *plen, off, *plen); >> + orig_len - *plen, off, off + *plen); >> } >> >> - dout("calc_layout objnum=%llx %llu~%llu\n", *objnum, *objoff, *objlen); >> + dout("calc_layout objnum=%llx, object extent %llu~%llu\n", *objnum, >> + *objoff, *objoff + *objlen); > Hi Xiubo, > > offset~length is how extents are printed both on the OSD side and > elsewhere in the kernel client. Okay, so my understanding is not correct then. Thanks. > Thanks, > > Ilya >