From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC63568 for ; Thu, 2 Dec 2021 07:34:41 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="234155641" X-IronPort-AV: E=Sophos;i="5.87,281,1631602800"; d="scan'208";a="234155641" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 23:34:41 -0800 X-IronPort-AV: E=Sophos;i="5.87,281,1631602800"; d="scan'208";a="597051542" Received: from rongch2-desk.sh.intel.com (HELO [10.239.159.175]) ([10.239.159.175]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 23:34:38 -0800 Message-ID: Date: Thu, 2 Dec 2021 15:34:36 +0800 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [kbuild-all] Re: [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack' Content-Language: en-US To: Ard Biesheuvel , kernel test robot Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Kernel Mailing List References: <202111250918.ErFZktQF-lkp@intel.com> From: Rong Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/30/21 21:12, Ard Biesheuvel wrote: > On Thu, 25 Nov 2021 at 02:35, kernel test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for-kernelci >> head: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 >> commit: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 [25/25] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems >> config: arm-randconfig-r024-20211124 (https://download.01.org/0day-ci/archive/20211125/202111250918.ErFZktQF-lkp@intel.com/config) >> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c) >> reproduce (this is a W=1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install arm cross compiling tool for clang build >> # apt-get install binutils-arm-linux-gnueabi >> # https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 >> git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git >> git fetch --no-tags ardb for-kernelci >> git checkout 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 >> # save the config file to linux build tree >> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> > This is yet another false positive. asmlinkage routines don't need a > prototype because they are called from assembler. This is not going to > get fixed, so please don't report this error anymore. Hi Ard, Sorry for the noise, we'll ignore the warnings in the future. Best Regards, Rong Chen > > >> arch/arm/kernel/traps.c:95:6: warning: no previous prototype for function 'dump_backtrace_stm' [-Wmissing-prototypes] >> void dump_backtrace_stm(u32 *stack, u32 instruction, const char *loglvl) >> ^ >> arch/arm/kernel/traps.c:95:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >> void dump_backtrace_stm(u32 *stack, u32 instruction, const char *loglvl) >> ^ >> static >> arch/arm/kernel/traps.c:446:17: warning: no previous prototype for function 'do_undefinstr' [-Wmissing-prototypes] >> asmlinkage void do_undefinstr(struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:446:12: note: declare 'static' if the function is not intended to be used outside of this translation unit >> asmlinkage void do_undefinstr(struct pt_regs *regs) >> ^ >> static >> arch/arm/kernel/traps.c:511:39: warning: no previous prototype for function 'handle_fiq_as_nmi' [-Wmissing-prototypes] >> asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:511:12: note: declare 'static' if the function is not intended to be used outside of this translation unit >> asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_regs *regs) >> ^ >> static >> arch/arm/kernel/traps.c:530:17: warning: no previous prototype for function 'bad_mode' [-Wmissing-prototypes] >> asmlinkage void bad_mode(struct pt_regs *regs, int reason) >> ^ >> arch/arm/kernel/traps.c:530:12: note: declare 'static' if the function is not intended to be used outside of this translation unit >> asmlinkage void bad_mode(struct pt_regs *regs, int reason) >> ^ >> static >> arch/arm/kernel/traps.c:603:16: warning: no previous prototype for function 'arm_syscall' [-Wmissing-prototypes] >> asmlinkage int arm_syscall(int no, struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:603:12: note: declare 'static' if the function is not intended to be used outside of this translation unit >> asmlinkage int arm_syscall(int no, struct pt_regs *regs) >> ^ >> static >> arch/arm/kernel/traps.c:729:1: warning: no previous prototype for function 'baddataabort' [-Wmissing-prototypes] >> baddataabort(int code, unsigned long instr, struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:728:12: note: declare 'static' if the function is not intended to be used outside of this translation unit >> asmlinkage void >> ^ >> static >> arch/arm/kernel/traps.c:769:17: warning: no previous prototype for function '__div0' [-Wmissing-prototypes] >> asmlinkage void __div0(void) >> ^ >> arch/arm/kernel/traps.c:769:12: note: declare 'static' if the function is not intended to be used outside of this translation unit >> asmlinkage void __div0(void) >> ^ >> static >>>> arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack' [-Wmissing-prototypes] >> asmlinkage void handle_bad_stack(struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:865:12: note: declare 'static' if the function is not intended to be used outside of this translation unit >> asmlinkage void handle_bad_stack(struct pt_regs *regs) >> ^ >> static >> 8 warnings generated. >> >> >> vim +/handle_bad_stack +865 arch/arm/kernel/traps.c >> >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 864 >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 @865 asmlinkage void handle_bad_stack(struct pt_regs *regs) >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 866 { >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 867 unsigned long tsk_stk = (unsigned long)current->stack; >> 5da04a8b705043 Ard Biesheuvel 2021-11-24 868 #ifdef CONFIG_IRQSTACKS >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 869 unsigned long irq_stk = (unsigned long)this_cpu_read(irq_stack_ptr); >> 5da04a8b705043 Ard Biesheuvel 2021-11-24 870 #endif >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 871 unsigned long ovf_stk = (unsigned long)this_cpu_read(overflow_stack_ptr); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 872 >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 873 console_verbose(); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 874 pr_emerg("Insufficient stack space to handle exception!"); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 875 >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 876 pr_emerg("Task stack: [0x%08lx..0x%08lx]\n", >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 877 tsk_stk, tsk_stk + THREAD_SIZE); >> 5da04a8b705043 Ard Biesheuvel 2021-11-24 878 #ifdef CONFIG_IRQSTACKS >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 879 pr_emerg("IRQ stack: [0x%08lx..0x%08lx]\n", >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 880 irq_stk - THREAD_SIZE, irq_stk); >> 5da04a8b705043 Ard Biesheuvel 2021-11-24 881 #endif >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 882 pr_emerg("Overflow stack: [0x%08lx..0x%08lx]\n", >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 883 ovf_stk - OVERFLOW_STACK_SIZE, ovf_stk); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 884 >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 885 die("kernel stack overflow", regs, 0); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 886 } >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 887 >> >> :::::: The code at line 865 was first introduced by commit >> :::::: adc7d753de62f220505f528106a6d618104302c5 ARM: implement support for vmap'ed stacks >> >> :::::: TO: Ard Biesheuvel >> :::::: CC: Ard Biesheuvel >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > _______________________________________________ > kbuild-all mailing list -- kbuild-all@lists.01.org > To unsubscribe send an email to kbuild-all-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4904961815215378079==" MIME-Version: 1.0 From: Rong Chen To: kbuild-all@lists.01.org Subject: Re: [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack' Date: Thu, 02 Dec 2021 15:34:36 +0800 Message-ID: In-Reply-To: List-Id: --===============4904961815215378079== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 11/30/21 21:12, Ard Biesheuvel wrote: > On Thu, 25 Nov 2021 at 02:35, kernel test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for= -kernelci >> head: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 >> commit: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 [25/25] ARM: implement = THREAD_INFO_IN_TASK for uniprocessor systems >> config: arm-randconfig-r024-20211124 (https://download.01.org/0day-ci/ar= chive/20211125/202111250918.ErFZktQF-lkp(a)intel.com/config) >> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a= 1c45def8a75061203461ab0060c75c864df1c) >> reproduce (this is a W=3D1 build): >> wget https://raw.githubusercontent.com/intel/lkp-tests/master/s= bin/make.cross -O ~/bin/make.cross >> chmod +x ~/bin/make.cross >> # install arm cross compiling tool for clang build >> # apt-get install binutils-arm-linux-gnueabi >> # https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.gi= t/commit/?id=3D5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 >> git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/g= it/ardb/linux.git >> git fetch --no-tags ardb for-kernelci >> git checkout 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 >> # save the config file to linux build tree >> COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dclang make.cross = W=3D1 ARCH=3Darm >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All warnings (new ones prefixed by >>): >> > This is yet another false positive. asmlinkage routines don't need a > prototype because they are called from assembler. This is not going to > get fixed, so please don't report this error anymore. Hi Ard, Sorry for the noise, we'll ignore the warnings in the future. Best Regards, Rong Chen > > >> arch/arm/kernel/traps.c:95:6: warning: no previous prototype for fun= ction 'dump_backtrace_stm' [-Wmissing-prototypes] >> void dump_backtrace_stm(u32 *stack, u32 instruction, const char *log= lvl) >> ^ >> arch/arm/kernel/traps.c:95:1: note: declare 'static' if the function= is not intended to be used outside of this translation unit >> void dump_backtrace_stm(u32 *stack, u32 instruction, const char *log= lvl) >> ^ >> static >> arch/arm/kernel/traps.c:446:17: warning: no previous prototype for f= unction 'do_undefinstr' [-Wmissing-prototypes] >> asmlinkage void do_undefinstr(struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:446:12: note: declare 'static' if the functi= on is not intended to be used outside of this translation unit >> asmlinkage void do_undefinstr(struct pt_regs *regs) >> ^ >> static >> arch/arm/kernel/traps.c:511:39: warning: no previous prototype for f= unction 'handle_fiq_as_nmi' [-Wmissing-prototypes] >> asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_re= gs *regs) >> ^ >> arch/arm/kernel/traps.c:511:12: note: declare 'static' if the functi= on is not intended to be used outside of this translation unit >> asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_re= gs *regs) >> ^ >> static >> arch/arm/kernel/traps.c:530:17: warning: no previous prototype for f= unction 'bad_mode' [-Wmissing-prototypes] >> asmlinkage void bad_mode(struct pt_regs *regs, int reason) >> ^ >> arch/arm/kernel/traps.c:530:12: note: declare 'static' if the functi= on is not intended to be used outside of this translation unit >> asmlinkage void bad_mode(struct pt_regs *regs, int reason) >> ^ >> static >> arch/arm/kernel/traps.c:603:16: warning: no previous prototype for f= unction 'arm_syscall' [-Wmissing-prototypes] >> asmlinkage int arm_syscall(int no, struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:603:12: note: declare 'static' if the functi= on is not intended to be used outside of this translation unit >> asmlinkage int arm_syscall(int no, struct pt_regs *regs) >> ^ >> static >> arch/arm/kernel/traps.c:729:1: warning: no previous prototype for fu= nction 'baddataabort' [-Wmissing-prototypes] >> baddataabort(int code, unsigned long instr, struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:728:12: note: declare 'static' if the functi= on is not intended to be used outside of this translation unit >> asmlinkage void >> ^ >> static >> arch/arm/kernel/traps.c:769:17: warning: no previous prototype for f= unction '__div0' [-Wmissing-prototypes] >> asmlinkage void __div0(void) >> ^ >> arch/arm/kernel/traps.c:769:12: note: declare 'static' if the functi= on is not intended to be used outside of this translation unit >> asmlinkage void __div0(void) >> ^ >> static >>>> arch/arm/kernel/traps.c:865:17: warning: no previous prototype for fun= ction 'handle_bad_stack' [-Wmissing-prototypes] >> asmlinkage void handle_bad_stack(struct pt_regs *regs) >> ^ >> arch/arm/kernel/traps.c:865:12: note: declare 'static' if the functi= on is not intended to be used outside of this translation unit >> asmlinkage void handle_bad_stack(struct pt_regs *regs) >> ^ >> static >> 8 warnings generated. >> >> >> vim +/handle_bad_stack +865 arch/arm/kernel/traps.c >> >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 864 >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 @865 asmlinkage void handle_ba= d_stack(struct pt_regs *regs) >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 866 { >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 867 unsigned long tsk_stk = =3D (unsigned long)current->stack; >> 5da04a8b705043 Ard Biesheuvel 2021-11-24 868 #ifdef CONFIG_IRQSTACKS >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 869 unsigned long irq_stk = =3D (unsigned long)this_cpu_read(irq_stack_ptr); >> 5da04a8b705043 Ard Biesheuvel 2021-11-24 870 #endif >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 871 unsigned long ovf_stk = =3D (unsigned long)this_cpu_read(overflow_stack_ptr); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 872 >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 873 console_verbose(); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 874 pr_emerg("Insufficient s= tack space to handle exception!"); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 875 >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 876 pr_emerg("Task stack: = [0x%08lx..0x%08lx]\n", >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 877 tsk_stk, tsk_st= k + THREAD_SIZE); >> 5da04a8b705043 Ard Biesheuvel 2021-11-24 878 #ifdef CONFIG_IRQSTACKS >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 879 pr_emerg("IRQ stack: = [0x%08lx..0x%08lx]\n", >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 880 irq_stk - THREA= D_SIZE, irq_stk); >> 5da04a8b705043 Ard Biesheuvel 2021-11-24 881 #endif >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 882 pr_emerg("Overflow stack= : [0x%08lx..0x%08lx]\n", >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 883 ovf_stk - OVERF= LOW_STACK_SIZE, ovf_stk); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 884 >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 885 die("kernel stack overfl= ow", regs, 0); >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 886 } >> adc7d753de62f2 Ard Biesheuvel 2021-09-23 887 >> >> :::::: The code at line 865 was first introduced by commit >> :::::: adc7d753de62f220505f528106a6d618104302c5 ARM: implement support f= or vmap'ed stacks >> >> :::::: TO: Ard Biesheuvel >> :::::: CC: Ard Biesheuvel >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > _______________________________________________ > kbuild-all mailing list -- kbuild-all(a)lists.01.org > To unsubscribe send an email to kbuild-all-leave(a)lists.01.org --===============4904961815215378079==--