All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gao,Shiyuan" via <qemu-devel@nongnu.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"imammedo@redhat.com" <imammedo@redhat.com>
Subject: Re: [PATCH 1/1] hw/i386/acpi-build: add OSHP method support for SHPC driver load
Date: Mon, 24 Jun 2024 14:40:48 +0000	[thread overview]
Message-ID: <a048130a668d44aa955599fc5c5e84cf@baidu.com> (raw)
In-Reply-To: <20240624094556-mutt-send-email-mst@kernel.org>

> > > > +static Aml *build_oshp_method(void)
> > > > +{
> > > > +    Aml *method;
> > > > +
> > > > +    /*
> > > > +     * Request control of SHPC hotplug via OSHP method,
> > > > +     * no need parameter and return value in acpi_pcihp.
> > > > +     */
> > >
> > > Quote spec and earliest version documenting this, please.
> >
> > I cann't find document describe this, only find in the kernel code
> > and describe it in the commit message.
>
> Hrrm you really should read the spec not just go by the fact things
> happen to work.  Look up PCI Firmware Specification


Thanks and I will quote it.

  reply	other threads:[~2024-06-24 14:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 13:14 [PATCH 1/1] hw/i386/acpi-build: add OSHP method support for SHPC driver load Shiyuan Gao via
2024-06-24 13:18 ` Michael S. Tsirkin
2024-06-24 13:34   ` Gao,Shiyuan via
2024-06-24 13:51     ` Michael S. Tsirkin
2024-06-24 14:40       ` Gao,Shiyuan via [this message]
2024-06-24 15:26         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a048130a668d44aa955599fc5c5e84cf@baidu.com \
    --to=qemu-devel@nongnu.org \
    --cc=gaoshiyuan@baidu.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.