From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Ida Delphine <idadelm@gmail.com>
Cc: Peter Kjellerstedt <peter.kjellerstedt@axis.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [poky-contrib][RFC PATCH 4/5] license.bbclass: Add functions to split and canonicalise license strings
Date: Wed, 17 Feb 2021 20:51:34 +0000 [thread overview]
Message-ID: <a04c7bcd2ac63ea7a9971f011c4755f741deaaed.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAN7sTgsoLjsnao0ijuidAP_hjTQyibeU7MWHXybbROTU0k290g@mail.gmail.com>
On Wed, 2021-02-17 at 17:55 +0100, Ida Delphine wrote:
> Thanks for the feedback. I will get rid of the logic to take care of
> those licenses with "or-later" and move the functions to license.py.
> Does this also mean I shouldn't try removing "WITH-Linux-syscall-note"
> from the licences?
I think the idea of what you're looking at is to remove "noise" from the
output and see if we can identify real licence issues. Removing the
"XXX WITH-Linux-syscall-note" where XXX is removed is key to that but
XXX must me removed too.
> The point of me doing that was for there to be more matches and the
> number of warnings reduced.
> Also there is more license-related logic in package.bbclass. Will it
> be okay if I move it as well to meta/lib/oe/license.py putting it
> in functions?
Possibly, but please do it in a separate patch which we can evaluate
on its own merit, I haven't looked at which code you mean so its hard
to tell offhand.
Cheers,
Richard
next prev parent reply other threads:[~2021-02-17 20:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 4:00 [poky-contrib][RFC PATCH 0/5] Suggestions for improvements? Meh Mbeh Ida Delphine
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 1/5] package: Remove false positive lic warnings Meh Mbeh Ida Delphine
2021-02-17 10:42 ` [OE-core] " Richard Purdie
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 2/5] " Meh Mbeh Ida Delphine
2021-02-17 10:39 ` [OE-core] " Richard Purdie
2021-02-17 14:55 ` Peter Kjellerstedt
2021-02-17 15:04 ` Richard Purdie
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 3/5] " Meh Mbeh Ida Delphine
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 4/5] license.bbclass: Add functions to split and canonicalise license strings Meh Mbeh Ida Delphine
2021-02-17 10:45 ` [OE-core] " Richard Purdie
2021-02-17 15:04 ` Peter Kjellerstedt
2021-02-17 16:36 ` Richard Purdie
2021-02-17 16:55 ` Meh Mbeh Ida Delphine
2021-02-17 20:51 ` Richard Purdie [this message]
2021-02-21 3:04 ` Meh Mbeh Ida Delphine
2021-02-21 11:21 ` Richard Purdie
2021-02-17 4:00 ` [poky-contrib][RFC PATCH 5/5] package.bbclass: Remove false positive license warnings Meh Mbeh Ida Delphine
2021-02-17 15:50 ` [OE-core] [poky-contrib][RFC PATCH 0/5] Suggestions for improvements? Peter Kjellerstedt
2021-02-17 16:58 ` Meh Mbeh Ida Delphine
2021-02-18 11:17 ` Peter Kjellerstedt
2021-02-18 12:21 ` Meh Mbeh Ida Delphine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a04c7bcd2ac63ea7a9971f011c4755f741deaaed.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=idadelm@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.