Re: [Qemu-devel] [for-4.0 PATCH v3 7/9] vfio/pci: Remove PCIe Link Status emulation

[Auger Eric <eric.auger@redhat.com>]

Hi
On 12/4/18 5:27 PM, Alex Williamson wrote:
> Now that the downstream port will virtually negotiate itself to the
> link status of the downstream devie, we can remove this emulation.
s/devie/device
> It's not clear that it was every terribly useful anyway.
> 
> Tested-by: Geoffrey McRae <geoff@hostfission.com>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

> ---
>  hw/vfio/pci.c |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 74f9a46b4be0..c0cb1ec28908 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -1901,12 +1901,6 @@ static int vfio_setup_pcie_cap(VFIOPCIDevice *vdev, int pos, uint8_t size,
>                             QEMU_PCI_EXP_LNKCAP_MLS(QEMU_PCI_EXP_LNK_2_5GT), ~0);
>              vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKCTL, 0, ~0);
>          }
> -
> -        /* Mark the Link Status bits as emulated to allow virtual negotiation */
> -        vfio_add_emulated_word(vdev, pos + PCI_EXP_LNKSTA,
> -                               pci_get_word(vdev->pdev.config + pos +
> -                                            PCI_EXP_LNKSTA),
> -                               PCI_EXP_LNKCAP_MLW | PCI_EXP_LNKCAP_SLS);

Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric
>      }
>  
>      /*
> 
>