From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH 2/7] block: Document more locking requirements
Date: Thu, 30 Nov 2017 20:03:31 -0700 [thread overview]
Message-ID: <a057d4ab-ddfd-9461-4086-e6f9ec83bb07@kernel.dk> (raw)
In-Reply-To: <20171201000848.2656-3-bart.vanassche@wdc.com>
On 11/30/2017 05:08 PM, Bart Van Assche wrote:
> This patch does not change any functionality.
Unless these actually found real bugs, I think it's pointless.
Add a comment. And this:
> @@ -1003,9 +1007,14 @@ bool blk_mq_get_driver_tag(struct request *rq, struct blk_mq_hw_ctx **hctx,
> static int blk_mq_dispatch_wake(wait_queue_entry_t *wait, unsigned mode,
> int flags, void *key)
> {
> - struct blk_mq_hw_ctx *hctx;
> + struct blk_mq_hw_ctx *hctx =
> + container_of(wait, struct blk_mq_hw_ctx, dispatch_wait);
> +
> +#ifdef CONFIG_LOCKDEP
> + struct sbq_wait_state *ws = bt_wait_ptr(&hctx->tags->bitmap_tags, hctx);
>
> - hctx = container_of(wait, struct blk_mq_hw_ctx, dispatch_wait);
> + lockdep_assert_held(&ws->wait.lock);
> +#endif
we're definitely not doing.
--
Jens Axboe
next prev parent reply other threads:[~2017-12-01 3:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 0:08 [PATCH 0/7] blk-mq: Queue running fixes Bart Van Assche
2017-12-01 0:08 ` [PATCH 1/7] blk-mq: Fix spelling in a source code comment Bart Van Assche
2017-12-01 0:08 ` [PATCH 2/7] block: Document more locking requirements Bart Van Assche
2017-12-01 3:03 ` Jens Axboe [this message]
2017-12-01 17:05 ` Bart Van Assche
2017-12-01 0:08 ` [PATCH 3/7] blk-mq: Make blk_mq_mark_tag_wait() easier to read Bart Van Assche
2017-12-01 0:08 ` [PATCH 4/7] blk-mq: Avoid that request processing stalls when sharing tags Bart Van Assche
2017-12-01 2:58 ` Ming Lei
2017-12-01 19:52 ` Bart Van Assche
2017-12-02 0:36 ` Ming Lei
2017-12-02 0:48 ` Bart Van Assche
2017-12-02 1:00 ` Ming Lei
2017-12-02 1:05 ` Bart Van Assche
2017-12-02 1:14 ` Ming Lei
2017-12-02 1:20 ` Ming Lei
2017-12-01 0:08 ` [PATCH 5/7] blk-mq: Avoid that blk_mq_mark_tag_wait() triggers a queue stall Bart Van Assche
2017-12-01 3:51 ` Ming Lei
2017-12-01 0:08 ` [PATCH 6/7] blk-mq: Rerun hardware queues after having called .put_budget() Bart Van Assche
2017-12-01 3:23 ` Ming Lei
2017-12-01 0:08 ` [PATCH 7/7] blk-mq: Fix another queue stall Bart Van Assche
2017-12-01 3:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a057d4ab-ddfd-9461-4086-e6f9ec83bb07@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.