From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3322177255858082675==" MIME-Version: 1.0 From: Stojaczyk, Dariusz Subject: [SPDK] Re: Running SPDK without app framework Date: Fri, 27 Mar 2020 12:52:25 +0000 Message-ID: In-Reply-To: 26203033ee3e4e4bb44b58ed73e31917@intel.com List-ID: To: spdk@lists.01.org --===============3322177255858082675== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Bump. This is actually kicking me in the ass now. :) I would like to utiliz= e spdk_app_opts->json_config_ignore_errors in fio_plugin, but there are no = spdk_app_opts there. We must get this straight. Let's put in the planning. D. _____________________________________________ From: Stojaczyk, Dariusz Sent: Monday, February 3, 2020 1:17 PM To: Zawadzki, Tomasz Cc: Storage Performance Development Kit Subject: Running SPDK without app framework Tomek, I'm looking through your patch example/fio: add option to load= json_config [1] and have some concerns to the overall design of applicatio= ns utilizing SPDK without the app framework. First of all, we seem to use s= pdk_app_json_config_load() to load a JSON config in fio_plugin. The spdk_ap= p_ prefix in that function suggests it's the app framework API, which we do= n't use in fio_plugin. I'm guessing it should be at least renamed? spdk_jso= n_config_load() maybe? spdk_app_json_config_load() is defined in spdk_internal/event.h. Why = is this internal anyway? This practically forces external SPDK users to sti= ck with either legacy json config files, or spdk_app_start(). The question = is where should we move it? lib/event.h is currently specific to the app fr= amework. Do you have any plans for SPDK app design without the app framewor= k? I'm guessing we do want to support it (see fio_plugin), but currently it= 's messy. D. [1] https://review.gerrithub.io/c/spdk/spdk/+/463979/ --===============3322177255858082675==--