From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 23/31] net/ice: support RSS
Date: Mon, 17 Dec 2018 22:47:46 +0000
Message-ID: <a065067c-e489-ceb9-ed98-493474dfba0d@intel.com>
References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com>
 <1545032259-77179-1-git-send-email-wenzhuo.lu@intel.com>
 <1545032259-77179-24-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Qiming Yang <qiming.yang@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id E23991B9DE
 for <dev@dpdk.org>; Mon, 17 Dec 2018 23:47:50 +0100 (CET)
In-Reply-To: <1545032259-77179-24-git-send-email-wenzhuo.lu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> Add below ops,
> reta_update
> reta_query
> rss_hash_update
> rss_hash_conf_get
> 
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
>  doc/guides/nics/features/ice.ini |   3 +
>  drivers/net/ice/ice_ethdev.c     | 242 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 245 insertions(+)
> 
> diff --git a/doc/guides/nics/features/ice.ini b/doc/guides/nics/features/ice.ini
> index 5ac8e56..953a869 100644
> --- a/doc/guides/nics/features/ice.ini
> +++ b/doc/guides/nics/features/ice.ini
> @@ -12,6 +12,9 @@ MTU update           = Y
>  Jumbo frame          = Y
>  Unicast MAC filter   = Y
>  Multicast MAC filter = Y
> +RSS hash             = Y
> +RSS key update       = Y
> +RSS reta update      = Y

Similar comment here, to claim RSS support data path also needs to be updated,
to set proper mbuf fields.

Perhaps it can be simpler to move RSS and VLAN patches after basic Rx/Tx support
patch and update data path for those features added, what do you think?