From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15212C433FE for ; Mon, 13 Dec 2021 22:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243803AbhLMWp4 (ORCPT ); Mon, 13 Dec 2021 17:45:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243760AbhLMWp4 (ORCPT ); Mon, 13 Dec 2021 17:45:56 -0500 Received: from mx3.securetransport.de (mx3.securetransport.de [IPv6:2a01:4f8:c0c:92be::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EF5C0C061748; Mon, 13 Dec 2021 14:45:55 -0800 (PST) Received: from mail.dh-electronics.com (business-24-134-97-169.pool2.vodafone-ip.de [24.134.97.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx3.securetransport.de (Postfix) with ESMTPSA id 122725DE01; Mon, 13 Dec 2021 23:45:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1639435511; bh=3GIEGVZf8PcJSm90lGLvZpIfiXIcdns1+xNUaJEcEvA=; h=From:To:CC:Subject:Date:References:From; b=QqRtoqWc7bvSDXo8OXJKJFS2sHQsRiSH8G2cG9aV8rsgb+DakuVBxpq3v4wiSKzTl W/7g7sJg9tzGnfbiCS/IcUDyUILGMQWGNCaytDu5uKQ5lAV07bRQS1xJa/H7y81amO cMF40M7OcErwwjx/kTi69otwyZ+uNZGd7gaxjf4OYflpwm+7ccfYpflgedrSfzY46g k0LTTVcWEOE2QztHBpdaTe/5y2Uhyl4/OA9Q9vMnJ37QYtHsZbOUGwhwMSJ6ySSZ5Z OH3p+ahuPtBaIohqQ2ErWQQa53v1D/H6RRemgeyM0Jj1DP4K9eLtuqWNvG9vp3TQbR xw3MBsPwo1eeg== Received: from DHPWEX01.DH-ELECTRONICS.ORG (2001:470:76a7:2::30) by DHPWEX01.DH-ELECTRONICS.ORG (2001:470:76a7:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Mon, 13 Dec 2021 23:44:59 +0100 Received: from DHPWEX01.DH-ELECTRONICS.ORG ([fe80::6ced:fa7f:9a9c:e579]) by DHPWEX01.DH-ELECTRONICS.ORG ([fe80::6ced:fa7f:9a9c:e579%6]) with mapi id 15.02.0986.014; Mon, 13 Dec 2021 23:44:59 +0100 From: Christoph Niedermaier To: Guenter Roeck , Adam Thomson , Andrej Picej , "linux-arm-kernel@lists.infradead.org" CC: Support Opensource , Wim Van Sebroeck , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC PATCH] watchdog: da9062: Correct the timeout values [Klartext] Thread-Topic: [RFC PATCH] watchdog: da9062: Correct the timeout values [Klartext] Thread-Index: AdfwANztWgHN3oJ0TZqwlPeCV8dlmAAIEJYAAALaKlAAD68ZMA== Date: Mon, 13 Dec 2021 22:44:59 +0000 Message-ID: References: <4254747d8cde4c5dbcbfdd00a3ecf701@dh-electronics.com> <03871bd3-ea78-52e1-f57b-3e35724c8934@roeck-us.net> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.51.18] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-watchdog@vger.kernel.org RnJvbTogQ2hyaXN0b3BoIE5pZWRlcm1haWVyDQpTZW50OiBNb25kYXksIERlY2VtYmVyIDEzLCAy MDIxIDU6MTYgUE0NCj4+Pj4+IFRoYW5rcyBhbnl3YXksIHNvIG5vdyBJIGtub3cgaXQgbXVzdCBi ZQ0KPj4+Pj4gcHJvYmxlbSB3aXRoIG15IERBOTA2MSBjaGlwLg0KPj4+Pj4NCj4+Pj4+IEBBZGFt DQo+Pj4+PiBXaGVyZSBjYW4gaXQgY29tZSBmcm9tPw0KPj4+Pj4gQ2FuIHlvdSBnaXZlIHdlIGEg aGludCB3aGF0IHRvIGNoZWNrPw0KPj4+Pg0KPj4+PiBJJ3ZlIHNwb2tlbiBpbnRlcm5hbGx5IGFu ZCBoYXZlIGJlZW4gaW5mb3JtZWQgdGhhdCB0aGlzIGlzIGRvd24gdG8gdGhlIGZhY3QgdGhhdA0K Pj4+PiBEQTkwNjEgcnVucyBvbmx5IGZyb20gYW4gaW50ZXJuYWwgb3NjaWxsYXRvciB3aGljaCBt YXkgYmUgc2xvd2VyLiBUaGUgaW5kaWNhdGlvbg0KPj4+PiBpcyB0aGF0IHRoZSB2YWx1ZXMgZm9y IFRXRFNDQUxFIGRlc2NyaWJlIHRoZSB3aW5kb3cgd2hlcmUgaWYgYSBraWNrL3Bpbmcgb2NjdXJz DQo+Pj4+IHdpdGhpbiB0aGF0IHBlcmlvZCB0aGVuIHRoZSB3YXRjaGRvZyBpcyBndWFyYW50ZWVk ICpub3QqIHRvIHRpbWVvdXQuIFRoZSBhY3R1YWwNCj4+Pj4gdGltZW91dCB3b3VsZCBiZSBhdCBz b21lIHBvaW50IGFmdGVyIHRoZSBzZWxlY3RlZCB0aW1lb3V0IHBlcmlvZCwgYXNzdW1pbmcgbm8N Cj4+Pj4gcGluZy9raWNrIG9jY3VycmVkLg0KPj4+Pg0KPj4+PiBUYWJsZSA4IGluIHRoZSBkYXRh c2hlZXQgc3BlY2lmaWVzIGEgbWluaW11bSB3YXRjaGRvZyB0aW1lb3V0IG9mIDIuNXMgKHRXRE1B WCkNCj4+Pj4gdW5kZXIgc3BlY2lmaWMgb3BlcmF0aW5nIGNvbmRpdGlvbnMsIHNvIGlmIHRoZSBt aW5pbXVtIDJzIHdpbmRvdyB3YXMgY2hvc2VuDQo+Pj4+IChUV0RTQ0FMRSA9IDEpIHRoZW4gZWFy bGllc3QgdGhlIHdhdGNoZG9nIHdvdWxkIGFjdHVhbGx5IHRpbWVvdXQsIGZvbGxvd2luZyBhDQo+ Pj4+IHBpbmcsIGlzIDIuNXMsIGFzc3VtaW5nIHRoZSBjb25kaXRpb25zIG1hdGNoZWQgdGhvc2Ug ZGVzY3JpYmVkLg0KPj4+Pg0KPj4+PiBJZiB5b3UgaGF2ZSBmdXJ0aGVyIHF1ZXN0aW9ucyBpdCBw cm9iYWJseSBtYWtlcyBzZW5zZSB0byBjb250YWN0IERpYWxvZy9SZW5lc2FzDQo+Pj4+IHN1cHBv cnQgYXMgdGhleSB3aWxsIGJlIGFibGUgdG8gcHJvdmlkZSBtb3JlIGRldGFpbGVkIGluZm8gb24g dGhpcy4NCj4+Pg0KPj4+IFNvIGEgREE5MDYxIHJ1bnMgb25seSBmcm9tIGFuIGludGVybmFsIG9z Y2lsbGF0b3IsIHdoZXJlYXMgYSBEQTkwNjINCj4+PiBjYW4gcnVuIG9uIGVpdGhlciBhbiBpbnRl cm5hbCBvciBhbiBleHRlcm5hbCBvc2NpbGxhdG9yLiBTbyB0aGlzDQo+Pj4gbWVhbnMgdGhhdCB0 aGUgREE5MDYxIHRpbWVvdXQgdmFsdWVzIGFyZSBkaWZmZXIgZnJvbSB0aGUgREE5MDYyDQo+Pj4g d2l0aCBhbiBleHRlcm5hbCBvc2NpbGxhdG9yIG5vdCBvbmx5IG9uIG15IGRldmljZSBidXQgb24g YWxsIERBOTA2MQ0KPj4+IGRldmljZXMuDQo+Pj4NCj4+PiBUaGlzIGFyZSB0aGUgdmFsdWVzIChp biBzZWNvbmRzKSBpbiBjb21wYXJpc29uOg0KPj4+IERBOTA2MiAoZnJvbSBkcml2ZXIpOiAwICAy ICA0ICAgOCAgMTYgIDMyICA2NSAxMzENCj4+PiBEQTkwNjEgKG1lYXN1cmVkKTogICAgMCAgMyAg NiAgMTIgIDI1ICA1MSAxMDIgMjA0DQo+Pj4gPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQ0KPj4+IERpZmZlcmVuY2U6ICAgICAgICAgICAwICsxICsyICAr NCAgKzkgKzE5ICszNyArNzMNCj4+Pg0KPj4+IEluIG15IG9waW5pb24sIHRoZSBkaWZmZXJlbmNl cyBpbiB0aGUgaGlnaGVyIHZhbHVlcyBhcmUgdmVyeSBodWdlLg0KPj4+IElmIEkgZXhwZWN0IHRo YXQgdGhlIHdhdGNoZG9nIHRyaWdnZXJzIGFuZCBJIGhhdmUgdG8gd2FpdCBtb3JlIHRoYW4NCj4+ PiBhIG1pbnV0ZSBmb3IgdGhhdCB0byBoYXBwZW4gSSBhc2sgbXlzZWxmIGlzIHRoZXJlIHNvbWV0 aGluZyB3cm9uZy4NCj4+Pg0KPj4+IEBBbmRyZWoNCj4+PiBJIGd1ZXNzLCB5b3UgYXJlIHVzaW5n IGFuIGV4dGVybmFsIG9zY2lsbGF0b3IsIGFyZW4ndCB5b3U/DQo+Pj4NCj4+PiBAQWRhbQ0KPj4+ IElzIHRoZXJlIGEgd2F5IHRvIGNoZWNrIGluIHRoZSBkcml2ZXIgd2hpY2ggb3NjaWxsYXRvciBp cyBpbiB1c2U/DQo+Pj4NCj4+PiBATWFpbnRhaW5lcnMNCj4+PiBJcyBpbiB0aGUgZHJpdmVyIGEg bmVlZCB0byBkaXN0aW5ndWlzaCBiZXR3ZWVuIGFuIGV4dGVybmFsIGFuZCBhbg0KPj4+IGludGVy bmFsIG9zY2lsbGF0b3IgdG8gZ2V0IHRoZSB0aW1lb3V0IHZhbHVlcyBtb3JlIGFjY3VyYXRlPw0K Pj4+DQo+Pg0KPj4gSXQgd291bGQgYmUgdmVyeSBkZXNpcmFibGUgdG8gZ2V0IHRpbWVvdXQgdmFs dWVzIG1vcmUgYWNjdXJhdGUuDQo+PiBJIHdvdWxkIG5vdCB3YW50IHRvIGRpY3RhdGUgaG93IHRv IGltcGxlbWVudCBpdCwgdGhvdWdoLg0KPj4gSXQgY291bGQgYmUgYXV0b21hdGljYWxseSBkZXRl Y3RlZCBpZiB0aGF0IGlzIHBvc3NpYmxlLCB0aGVyZQ0KPj4gY291bGQgYmUgYSBkZXZpY2V0cmVl IGNsb2NrIHByb3BlcnR5IHByb3ZpZGluZyB0aGUgY2xvY2sNCj4+IGZyZXF1ZW5jeSwgb3IgbWF5 YmUgdGhlcmUgaXMgc29tZSBvdGhlciBzb2x1dGlvbi4NCj4+DQo+PiBHdWVudGVyDQo+IA0KPiBJ IGFtIG9wZW4gZm9yIGEgZ29vZCBzb2x1dGlvbi4NCj4gTWVhbndoaWxlIEkgbWVhc3VyZWQgdGhl IHRpbWVvdXQgdmFsdWVzIG9mIG15IDggYXZhaWxhYmxlIERBOTA2MQ0KPiB3YXRjaGRvZ3MuIEkg ZGVyaXZlZCB0aGUgZm9sbG93aW5nIGZvcm11bGEgZnJvbSB0aGUgZ2l2ZW4gZm9ybXVsYQ0KPiBh dCB0aGUgZGF0YSBzaGVldCBhbmQgdGhlIGNsb2NrIGRpdmlkZXIgb2YgMl4xNjoNCj4gDQo+IGYg PSAyXigxNStUV0RTQ0FMRSkgLyB0DQo+IA0KPiBGb3JtdWxhIGNoZWNrIHdpdGggdGhlIGV4dGVy bmFsIG9zY2lsbGF0b3IgKDMya0h6KSBUV0RTQ0FMRT03IEAgMTMxczoNCj4gZiA9IDJeKDE1Kzcp IC8gMTMxID0gMzIwMTdIeiAoPT4gc2hvdWxkIGJlIE9LKQ0KPiANCj4gVGhlIHRpbWVvdXRzIG9m IG15IDggd2F0Y2hkb2dzICg5MDYxLUFBKSB3aXRoIFRXRFNDQUxFPTc6DQo+IHQ3ID0gMjExcyA9 PiAxOTg3OEh6DQo+IHQ3ID0gMTk3cyA9PiAyMTI5MUh6DQo+IHQ3ID0gMjAzcyA9PiAyMDY2Mkh6 DQo+IHQ3ID0gMjA0cyA9PiAyMDU2MEh6DQo+IHQ3ID0gMjA2cyA9PiAyMDM2MUh6DQo+IHQ3ID0g MTk4cyA9PiAyMTY2Mkh6DQo+IHQ3ID0gMjAwcyA9PiAyMDk3Mkh6DQo+IA0KPiBBY2NvcmRpbmcg dG8gdGhlIGRhdGEgc2hlZXQgdGhlIGludGVybmFsIG9zY2lsbGF0b3Igc2hvdWxkIHJ1biBhdCAy NWtIei4NCj4gVGhlIGF2ZXJhZ2UgZnJlcXVlbmN5IG9mIG15IDggZGV2aWNlcyBpcyAyMC42a0h6 LiBNYXliZSB0aGUgZGF0YSBzaGVldA0KPiBDbG9jayB2YWx1ZSBpcyBhIG1heCB2YWx1ZS4gVGhl IHRpbWVvdXQgZGlmZmVyZW5jZSBvbiBteSA4IGRldmljZXMgYXJlDQo+IDE0cy4gU28gdGhlIHZh bHVlcyB2YXJ5IGZyb20gZGV2aWNlIHRvIGRldmljZSwgYW5kIG1heWJlIHRoZXJlIGlzIGFsc28g YQ0KPiB0ZW1wZXJhdHVyZSBjb21wb25lbnQuDQo+IA0KPiBAQWRhbQ0KPiBJcyB0aGVyZSBhIHdh eSB0byBjaGVjayB3aGljaCBvc2NpbGxhdG9yIGlzIGluIHVzZT8NCj4gSXMgdGhlcmUgYSB3YXkg dG8gZmluZCB0aGUgY3VycmVudCBvc2NpbGxhdG9yIGZyZXF1ZW5jeT8NCj4gQXJlIHRoZXJlIGFu eSBvdGhlciBpZGVhcy9zb2x1dGlvbnMgdG8gZ2V0IHRoZSB0aW1lb3V0IHZhbHVlcyBtb3JlIGFj Y3VyYXRlPw0KDQpBcyBJIHNlbnQgbXkgRS1NYWlsIEkgZGlkbid0IHNlZSB5b3VyIGFuc3dlciwg c28gaGVyZSBpdCBpczoNCg0KPiBBIHF1aWNrIHNjYW4gb2YgdGhlIERBOTA2MiBkYXRhc2hlZXQg c2hvd3MgdGhhdCByZWcvZmllbGQgRU5fMzJLL0NSWVNUQUwgd2lsbA0KPiBpbmRpY2F0ZSB0aGUg cHJlc2VuY2Ugb2YgYSAzMktIeiBjcnlzdGFsIG9zY2lsbGF0b3IuIE9idmlvdXNseSBvbiBEQTkw NjEgdGhhdA0KPiBvcHRpb24gaXNuJ3QgYXZhaWxhYmxlLg0KPg0KPiBJIHRoaW5rIHRoZSBwcm9i bGVtIHNlZW1zIHRvIGxpZSBhcm91bmQgZGV0ZXJtaW5pbmcgdGhlIGludGVybmFsIG9zY2lsbGF0 b3Incw0KPiBmcmVxdWVuY3kuIERhdGFzaGVldCByZWZlcmVuY2VzIDI1TWh6IGluIFRhYmxlIDkg KFdhdGNoZG9nIEVsZWN0cmljYWwNCj4gQ2hhcmFjdGVyaXN0aWNzKSwgYnV0IHRoYXQgZG9lc24n dCBzZWVtIHRvIHRhbGx5IHdpdGggeW91ciB0aW1pbmdzIGFuZCBJIGRvbid0DQo+IHNlZSBhbiBv YnZpb3VzIHdheSBpbiB0aGUgcmVnbWFwIHRvIGNhbGN1bGF0ZSB0aGlzIGF0IHJ1biB0aW1lLiAq SWYqIHRoZQ0KPiBvc2NpbGxhdG9yIGZyZXF1ZW5jeSB2YXJpZXMgZnJvbSBwYXJ0IHRvIHBhcnQs IG9yIHVuZGVyIGRpZmZlcmVudCBlbnZpcm9ubWVudGFsDQo+IGNvbmRpdGlvbnMsIHRoZW4gaXQn cyBnb2luZyB0byBiZSB0b3VnaCB0byB0aWUgdGhpcyBkb3duLCBhbmQgeW91IHdvdWxkbid0IHdh bnQNCj4gdG8gc3RhdGUgYSB0aW1lb3V0IHZhbHVlIHRoYXQncyBsb25nZXIgdGhhbiByZWFsaXR5 Lg0KDQpAQWRhbQ0KV2hhdCBkbyB5b3UgdGhpbmsgaWYgSSBhZGQgYWxzbyB0aGUgdGltZW91dCB2 YWx1ZXMgZm9yIHRoZSBpbnRlcm5hbCBvc2NpbGxhdG9yPw0KVGhhbiB0aGUgdmFsdWVzIHdvdWxk IGJlOg0KDQp0ID0gMl4oMTUrVFdEU0NBTEUpIC8gZg0KDQpJbnRlcm5hbCAyNWtIeiBvc2NpbGxh dG9yOiAwICAyICA1ICAxMCAgMjAgIDQxICA4MyAxNjcNCg0KSW4gY29tcGFyaXNvbiB0byB0aGUN CmV4dGVybmFsIDMya0h6IG9zY2lsbGF0b3I6IDAgIDIgIDQgICA4ICAxNiAgMzIgIDY1IDEzMQ0K DQpTbyB0aGUgZGlmZmVyZW5jZSB0byBteSBtZWFzdXJlZCB2YWx1ZXMgd2lsbCBkZWNyZWFzZSBh bmQgaXQgd2lsbCBpbXByb3ZlIHRoZQ0KY3VycmVudCBkcml2ZXIgdG93YXJkcyBtb3JlIGFjY3Vy YXRlIHZhbHVlcy4NCg0KQnR3IGlmIEkgY2FsY3VsYXRlIHRoZSB2YWx1ZXMgd2l0aCAzMjc2OEh6 ICh0aGUgdHlwaWNhbCAzMmtIeiBvc2NpbGxhdG9yKSwgSSBnZXQgdGhlDQpmb2xsb3dpbmcgdmFs dWVzOg0KMzI3NjhIeiBvc2NpbGxhdG9yOiAgICAgICAgMCAgMiAgNCAgIDggIDE2ICAzMiAgNjQg MTI4DQoNClJlZ2FyZHMNCkNocmlzdG9waA0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBF16C433EF for ; Mon, 13 Dec 2021 22:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: List-Owner; bh=LvMq2MiLladEy7y8PXWD1g04hrTUYavwPzSaI3gYSy4=; b=uYsTF5iGYfjji+ 2yTrykPHerVy5xvOcu3zFcoAYt1wRL0K3rvu7b5OleoPQ7jFV6YMrz63Z3DaeKpQy8xn/iO8HGiMf ZR5abQTMiYIYFfsOo/tdsZt/l3E2lFeWp9U/QOjS6Q5GNeeM5p9v7Om1IRfoT5R2ynJWuIMYyaLTA uaelBQmowsJSxu9DRiZyKmFJ1STMVN9D7+TP8S0BUacnITfuWK+CfyN0ezkzyMw/euuvfBPRQcexH uFACMh32YxyNz12Gtefci3UaI70n87oA47TO7Lq0En7mbZ6D01G2VmR+xMVUhUnlTPIR7T0bw4pgv Gz+LnuoZIh4yFa8J2y3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwuAX-00BrxK-Va; Mon, 13 Dec 2021 22:51:44 +0000 Received: from mx3.securetransport.de ([2a01:4f8:c0c:92be::1]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwu4Q-00Bq8T-Tv for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 22:45:25 +0000 Received: from mail.dh-electronics.com (business-24-134-97-169.pool2.vodafone-ip.de [24.134.97.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx3.securetransport.de (Postfix) with ESMTPSA id 122725DE01; Mon, 13 Dec 2021 23:45:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1639435511; bh=3GIEGVZf8PcJSm90lGLvZpIfiXIcdns1+xNUaJEcEvA=; h=From:To:CC:Subject:Date:References:From; b=QqRtoqWc7bvSDXo8OXJKJFS2sHQsRiSH8G2cG9aV8rsgb+DakuVBxpq3v4wiSKzTl W/7g7sJg9tzGnfbiCS/IcUDyUILGMQWGNCaytDu5uKQ5lAV07bRQS1xJa/H7y81amO cMF40M7OcErwwjx/kTi69otwyZ+uNZGd7gaxjf4OYflpwm+7ccfYpflgedrSfzY46g k0LTTVcWEOE2QztHBpdaTe/5y2Uhyl4/OA9Q9vMnJ37QYtHsZbOUGwhwMSJ6ySSZ5Z OH3p+ahuPtBaIohqQ2ErWQQa53v1D/H6RRemgeyM0Jj1DP4K9eLtuqWNvG9vp3TQbR xw3MBsPwo1eeg== Received: from DHPWEX01.DH-ELECTRONICS.ORG (2001:470:76a7:2::30) by DHPWEX01.DH-ELECTRONICS.ORG (2001:470:76a7:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Mon, 13 Dec 2021 23:44:59 +0100 Received: from DHPWEX01.DH-ELECTRONICS.ORG ([fe80::6ced:fa7f:9a9c:e579]) by DHPWEX01.DH-ELECTRONICS.ORG ([fe80::6ced:fa7f:9a9c:e579%6]) with mapi id 15.02.0986.014; Mon, 13 Dec 2021 23:44:59 +0100 From: Christoph Niedermaier To: Guenter Roeck , Adam Thomson , Andrej Picej , "linux-arm-kernel@lists.infradead.org" CC: Support Opensource , Wim Van Sebroeck , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC PATCH] watchdog: da9062: Correct the timeout values [Klartext] Thread-Topic: [RFC PATCH] watchdog: da9062: Correct the timeout values [Klartext] Thread-Index: AdfwANztWgHN3oJ0TZqwlPeCV8dlmAAIEJYAAALaKlAAD68ZMA== Date: Mon, 13 Dec 2021 22:44:59 +0000 Message-ID: References: <4254747d8cde4c5dbcbfdd00a3ecf701@dh-electronics.com> <03871bd3-ea78-52e1-f57b-3e35724c8934@roeck-us.net> Accept-Language: de-DE, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.16.51.18] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_144523_241916_EAFE63B3 X-CRM114-Status: GOOD ( 40.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Christoph Niedermaier Sent: Monday, December 13, 2021 5:16 PM >>>>> Thanks anyway, so now I know it must be >>>>> problem with my DA9061 chip. >>>>> >>>>> @Adam >>>>> Where can it come from? >>>>> Can you give we a hint what to check? >>>> >>>> I've spoken internally and have been informed that this is down to the fact that >>>> DA9061 runs only from an internal oscillator which may be slower. The indication >>>> is that the values for TWDSCALE describe the window where if a kick/ping occurs >>>> within that period then the watchdog is guaranteed *not* to timeout. The actual >>>> timeout would be at some point after the selected timeout period, assuming no >>>> ping/kick occurred. >>>> >>>> Table 8 in the datasheet specifies a minimum watchdog timeout of 2.5s (tWDMAX) >>>> under specific operating conditions, so if the minimum 2s window was chosen >>>> (TWDSCALE = 1) then earliest the watchdog would actually timeout, following a >>>> ping, is 2.5s, assuming the conditions matched those described. >>>> >>>> If you have further questions it probably makes sense to contact Dialog/Renesas >>>> support as they will be able to provide more detailed info on this. >>> >>> So a DA9061 runs only from an internal oscillator, whereas a DA9062 >>> can run on either an internal or an external oscillator. So this >>> means that the DA9061 timeout values are differ from the DA9062 >>> with an external oscillator not only on my device but on all DA9061 >>> devices. >>> >>> This are the values (in seconds) in comparison: >>> DA9062 (from driver): 0 2 4 8 16 32 65 131 >>> DA9061 (measured): 0 3 6 12 25 51 102 204 >>> ================================================= >>> Difference: 0 +1 +2 +4 +9 +19 +37 +73 >>> >>> In my opinion, the differences in the higher values are very huge. >>> If I expect that the watchdog triggers and I have to wait more than >>> a minute for that to happen I ask myself is there something wrong. >>> >>> @Andrej >>> I guess, you are using an external oscillator, aren't you? >>> >>> @Adam >>> Is there a way to check in the driver which oscillator is in use? >>> >>> @Maintainers >>> Is in the driver a need to distinguish between an external and an >>> internal oscillator to get the timeout values more accurate? >>> >> >> It would be very desirable to get timeout values more accurate. >> I would not want to dictate how to implement it, though. >> It could be automatically detected if that is possible, there >> could be a devicetree clock property providing the clock >> frequency, or maybe there is some other solution. >> >> Guenter > > I am open for a good solution. > Meanwhile I measured the timeout values of my 8 available DA9061 > watchdogs. I derived the following formula from the given formula > at the data sheet and the clock divider of 2^16: > > f = 2^(15+TWDSCALE) / t > > Formula check with the external oscillator (32kHz) TWDSCALE=7 @ 131s: > f = 2^(15+7) / 131 = 32017Hz (=> should be OK) > > The timeouts of my 8 watchdogs (9061-AA) with TWDSCALE=7: > t7 = 211s => 19878Hz > t7 = 197s => 21291Hz > t7 = 203s => 20662Hz > t7 = 204s => 20560Hz > t7 = 206s => 20361Hz > t7 = 198s => 21662Hz > t7 = 200s => 20972Hz > > According to the data sheet the internal oscillator should run at 25kHz. > The average frequency of my 8 devices is 20.6kHz. Maybe the data sheet > Clock value is a max value. The timeout difference on my 8 devices are > 14s. So the values vary from device to device, and maybe there is also a > temperature component. > > @Adam > Is there a way to check which oscillator is in use? > Is there a way to find the current oscillator frequency? > Are there any other ideas/solutions to get the timeout values more accurate? As I sent my E-Mail I didn't see your answer, so here it is: > A quick scan of the DA9062 datasheet shows that reg/field EN_32K/CRYSTAL will > indicate the presence of a 32KHz crystal oscillator. Obviously on DA9061 that > option isn't available. > > I think the problem seems to lie around determining the internal oscillator's > frequency. Datasheet references 25Mhz in Table 9 (Watchdog Electrical > Characteristics), but that doesn't seem to tally with your timings and I don't > see an obvious way in the regmap to calculate this at run time. *If* the > oscillator frequency varies from part to part, or under different environmental > conditions, then it's going to be tough to tie this down, and you wouldn't want > to state a timeout value that's longer than reality. @Adam What do you think if I add also the timeout values for the internal oscillator? Than the values would be: t = 2^(15+TWDSCALE) / f Internal 25kHz oscillator: 0 2 5 10 20 41 83 167 In comparison to the external 32kHz oscillator: 0 2 4 8 16 32 65 131 So the difference to my measured values will decrease and it will improve the current driver towards more accurate values. Btw if I calculate the values with 32768Hz (the typical 32kHz oscillator), I get the following values: 32768Hz oscillator: 0 2 4 8 16 32 64 128 Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel