From mboxrd@z Thu Jan 1 00:00:00 1970 From: stefan@agner.ch (Stefan Agner) Date: Wed, 17 Feb 2016 13:52:07 -0800 Subject: [PATCH v2 2/3] ARM: dts: vf-colibri: add basic supply regulators In-Reply-To: References: <1455668317-15728-1-git-send-email-stefan@agner.ch> <1455668317-15728-2-git-send-email-stefan@agner.ch> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016-02-16 16:28, Fabio Estevam wrote: > On Tue, Feb 16, 2016 at 10:18 PM, Stefan Agner wrote: > >> + reg_module_3v3: regulator-module-3v3 { >> + compatible = "regulator-fixed"; >> + regulator-name = "+V3.3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > This 'regulator-always-on' property can be removed. > >> + }; >> + >> + reg_module_3v3_avdd: regulator-module-3v3-avdd { >> + compatible = "regulator-fixed"; >> + regulator-name = "+V3.3_AVDD_AUDIO"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > Same here. Hm, should I remove them also in Patch 1/3? It's a fixed regulator too, hence I guess regulator-always-on is pointless there too...? -- Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Agner Subject: Re: [PATCH v2 2/3] ARM: dts: vf-colibri: add basic supply regulators Date: Wed, 17 Feb 2016 13:52:07 -0800 Message-ID: References: <1455668317-15728-1-git-send-email-stefan@agner.ch> <1455668317-15728-2-git-send-email-stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: Shawn Guo , Sascha Hauer , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel , Marcel Ziswiler List-Id: devicetree@vger.kernel.org On 2016-02-16 16:28, Fabio Estevam wrote: > On Tue, Feb 16, 2016 at 10:18 PM, Stefan Agner wrote: > >> + reg_module_3v3: regulator-module-3v3 { >> + compatible = "regulator-fixed"; >> + regulator-name = "+V3.3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > This 'regulator-always-on' property can be removed. > >> + }; >> + >> + reg_module_3v3_avdd: regulator-module-3v3-avdd { >> + compatible = "regulator-fixed"; >> + regulator-name = "+V3.3_AVDD_AUDIO"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > Same here. Hm, should I remove them also in Patch 1/3? It's a fixed regulator too, hence I guess regulator-always-on is pointless there too...? -- Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161894AbcBQVyq (ORCPT ); Wed, 17 Feb 2016 16:54:46 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:56385 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030346AbcBQVyo (ORCPT ); Wed, 17 Feb 2016 16:54:44 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 17 Feb 2016 13:52:07 -0800 From: Stefan Agner To: Fabio Estevam Cc: Shawn Guo , Sascha Hauer , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel , Marcel Ziswiler Subject: Re: [PATCH v2 2/3] ARM: dts: vf-colibri: add basic supply regulators In-Reply-To: References: <1455668317-15728-1-git-send-email-stefan@agner.ch> <1455668317-15728-2-git-send-email-stefan@agner.ch> Message-ID: User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-02-16 16:28, Fabio Estevam wrote: > On Tue, Feb 16, 2016 at 10:18 PM, Stefan Agner wrote: > >> + reg_module_3v3: regulator-module-3v3 { >> + compatible = "regulator-fixed"; >> + regulator-name = "+V3.3"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > This 'regulator-always-on' property can be removed. > >> + }; >> + >> + reg_module_3v3_avdd: regulator-module-3v3-avdd { >> + compatible = "regulator-fixed"; >> + regulator-name = "+V3.3_AVDD_AUDIO"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > Same here. Hm, should I remove them also in Patch 1/3? It's a fixed regulator too, hence I guess regulator-always-on is pointless there too...? -- Stefan