From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sagar Cheluvegowda <quic_scheluve@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Andrew Halaney <ahalaney@redhat.com>,
Vinod Koul <vkoul@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: kernel@quicinc.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: net: qcom: ethernet: Allow dma-coherent
Date: Wed, 8 May 2024 09:01:03 +0200 [thread overview]
Message-ID: <a0a89cd8-9604-4a75-a358-2974a0f70e54@kernel.org> (raw)
In-Reply-To: <20240507-mark_ethernet_devices_dma_coherent-v3-2-dbe70d0fa971@quicinc.com>
On 08/05/2024 03:31, Sagar Cheluvegowda wrote:
> On SA8775P, Ethernet DMA controller is coherent with the CPU.
> allow specifying that.
>
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
> ---
> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index 69a337c7e345..44028987ef92 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -66,6 +66,8 @@ properties:
> phy-names:
> const: serdes
>
> + dma-coherent: true
Do not add properties to the end of the list. That's downstream
practice... Keep it next to iommus, for example.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-08 7:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 1:30 [PATCH v3 0/2] Mark Ethernet devices on sa8775p as DMA-coherent Sagar Cheluvegowda
2024-05-08 1:31 ` [PATCH v3 1/2] arm64: dts: qcom: sa8775p: mark ethernet devices " Sagar Cheluvegowda
2024-05-08 18:39 ` Konrad Dybcio
2024-05-08 1:31 ` [PATCH v3 2/2] dt-bindings: net: qcom: ethernet: Allow dma-coherent Sagar Cheluvegowda
2024-05-08 7:01 ` Krzysztof Kozlowski [this message]
2024-05-08 18:45 ` [PATCH v3 0/2] Mark Ethernet devices on sa8775p as DMA-coherent Konrad Dybcio
2024-05-14 14:21 ` Andrew Halaney
2024-05-14 14:41 ` Jakub Kicinski
2024-05-14 15:11 ` Andrew Halaney
2024-05-14 16:05 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0a89cd8-9604-4a75-a358-2974a0f70e54@kernel.org \
--to=krzk@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhupesh.sharma@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_scheluve@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.