From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AA9C433F5 for ; Wed, 6 Oct 2021 14:26:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 153B3600CD for ; Wed, 6 Oct 2021 14:26:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 153B3600CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=o6b8s9s/2GY/C4jH7kKu2JbAb88AnorqNFH9CHItMEo=; b=PMxDZ9+B1dVlfwufBPzZNwtkTY ygcpf3JjSIE7efbLZ8PijLbzhHO5sYDueeRQkBxqosLAo7Op5aaMjNVF+iYwtVlnoG9CRySC3Fwjj T97jYKyOOUcfZuKWDkR8j5l1JRGRik8yCl15wktG7KSH1UB98eiWGYMCkdQ1OAeKk67gOGcwV7Lj8 yY2p75LDZ2DiAcDv7ORBgoElUTuKfy+4aLMNrDojkx8OuyKZ6zhm52KYST2xGsPK/tZp1y+3FBKbX JVhDpTo53SIWv35cCQmeYj8I+UzBDJIyWnENe7rINGjwSm5QVo2eVJnZ1RxHoiUEJuZBxrNuc72oQ 1D6yjmAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY7qv-00Edm4-93; Wed, 06 Oct 2021 14:25:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY7qp-00EdjM-Ro for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 14:24:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F5EC6D; Wed, 6 Oct 2021 07:24:54 -0700 (PDT) Received: from [10.57.43.152] (unknown [10.57.43.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 378173F66F; Wed, 6 Oct 2021 07:24:51 -0700 (PDT) Subject: Re: [PATCH v2 5/5] kasan: Extend KASAN mode kernel parameter To: Andrey Konovalov Cc: Linux ARM , LKML , kasan-dev , Andrew Morton , Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Lorenzo Pieralisi References: <20211004202253.27857-1-vincenzo.frascino@arm.com> <20211004202253.27857-6-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Wed, 6 Oct 2021 16:25:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_072455_983204_312D9560 X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/6/21 2:19 PM, Andrey Konovalov wrote: >> +static inline bool kasan_sync_fault_possible(void) >> +{ >> + return !kasan_flag_async | kasan_flag_asymm; > This should be just !kasan_flag_async. > > It seems that choosing one exclusive option out of 3 via two bools is > confusing. How about an enum? > > enum kasan_mode { > KASAN_MODE_SYNC, > KASAN_MODE_ASYNC, > KASAN_MODE_ASYMM, > }; > > enum kasan_mode kasan_mode __ro_after_init; > EXPORT_SYMBOL_GPL(kasan_mode); Fine by me. I will change the code in v3. Thanks! -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33599C433F5 for ; Wed, 6 Oct 2021 14:24:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1942761184 for ; Wed, 6 Oct 2021 14:24:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238868AbhJFO0s (ORCPT ); Wed, 6 Oct 2021 10:26:48 -0400 Received: from foss.arm.com ([217.140.110.172]:57154 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231600AbhJFO0q (ORCPT ); Wed, 6 Oct 2021 10:26:46 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4F5EC6D; Wed, 6 Oct 2021 07:24:54 -0700 (PDT) Received: from [10.57.43.152] (unknown [10.57.43.152]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 378173F66F; Wed, 6 Oct 2021 07:24:51 -0700 (PDT) Subject: Re: [PATCH v2 5/5] kasan: Extend KASAN mode kernel parameter To: Andrey Konovalov Cc: Linux ARM , LKML , kasan-dev , Andrew Morton , Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Lorenzo Pieralisi References: <20211004202253.27857-1-vincenzo.frascino@arm.com> <20211004202253.27857-6-vincenzo.frascino@arm.com> From: Vincenzo Frascino Message-ID: Date: Wed, 6 Oct 2021 16:25:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/21 2:19 PM, Andrey Konovalov wrote: >> +static inline bool kasan_sync_fault_possible(void) >> +{ >> + return !kasan_flag_async | kasan_flag_asymm; > This should be just !kasan_flag_async. > > It seems that choosing one exclusive option out of 3 via two bools is > confusing. How about an enum? > > enum kasan_mode { > KASAN_MODE_SYNC, > KASAN_MODE_ASYNC, > KASAN_MODE_ASYMM, > }; > > enum kasan_mode kasan_mode __ro_after_init; > EXPORT_SYMBOL_GPL(kasan_mode); Fine by me. I will change the code in v3. Thanks! -- Regards, Vincenzo