All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
To: Matthew Brost <matthew.brost@intel.com>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe: Reorder 'Get pages failed' message
Date: Tue, 10 Jun 2025 10:27:05 +0530	[thread overview]
Message-ID: <a0d9ee8a-4c9d-42ba-a09e-ce005802b759@intel.com> (raw)
In-Reply-To: <20250610045649.3149801-1-matthew.brost@intel.com>



On 10-06-2025 10:26, Matthew Brost wrote:
> Print the error from get pages failing, not the cast to -ENODATA.

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_vm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 18f967ce1f1a..d18807b92b18 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2924,10 +2924,10 @@ static int prefetch_ranges(struct xe_vm *vm, struct xe_vma_op *op)
>   
>   		err = xe_svm_range_get_pages(vm, svm_range, &ctx);
>   		if (err) {
> -			if (err == -EOPNOTSUPP || err == -EFAULT || err == -EPERM)
> -				err = -ENODATA;
>   			drm_dbg(&vm->xe->drm, "Get pages failed, asid=%u, gpusvm=%p, errno=%pe\n",
>   				vm->usm.asid, &vm->svm.gpusvm, ERR_PTR(err));
> +			if (err == -EOPNOTSUPP || err == -EFAULT || err == -EPERM)
> +				err = -ENODATA;
>   			return err;
>   		}
>   		xe_svm_range_debug(svm_range, "PREFETCH - RANGE GET PAGES DONE");


  reply	other threads:[~2025-06-10  4:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10  4:56 [PATCH] drm/xe: Reorder 'Get pages failed' message Matthew Brost
2025-06-10  4:57 ` Ghimiray, Himal Prasad [this message]
2025-06-10  5:01 ` ✓ CI.Patch_applied: success for " Patchwork
2025-06-10  5:01 ` ✓ CI.checkpatch: " Patchwork
2025-06-10  5:02 ` ✓ CI.KUnit: " Patchwork
2025-06-10  5:13 ` ✓ CI.Build: " Patchwork
2025-06-10  5:15 ` ✓ CI.Hooks: " Patchwork
2025-06-10  5:17 ` ✓ CI.checksparse: " Patchwork
2025-06-10  6:05 ` ✓ Xe.CI.BAT: " Patchwork
2025-06-10  7:00 ` ✗ Xe.CI.Full: failure " Patchwork
2025-06-11 18:54 ` [PATCH] " Summers, Stuart
2025-06-11 19:24 ` Maarten Lankhorst

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0d9ee8a-4c9d-42ba-a09e-ce005802b759@intel.com \
    --to=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.