From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 218E3CD6E57 for ; Thu, 4 Jun 2026 10:31:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wV5MC-0006TA-7K; Thu, 04 Jun 2026 06:31:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wV5M1-0006QT-4L for qemu-riscv@nongnu.org; Thu, 04 Jun 2026 06:31:14 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wV5Lz-0001OS-Js for qemu-riscv@nongnu.org; Thu, 04 Jun 2026 06:31:12 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6549xgnF1994316 for ; Thu, 4 Jun 2026 10:31:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FkfQG2WMLVGhh3lScAYNiUngeU3+aha52uzRutFQJNA=; b=PHfDfMqO4sx7Rcw5 otrw+PMU9XGlLQZDA9qvwCngtc7rqYRJDLuBZZupxLOcZADhvarOYe6qYloaZckg 0BgZBLhU0QNbdLPY89epo5aNKweXvDyJI2VdD4vwYj+4wSnZMvQrZktK/3ymNDpP CumBOEf16vRs9vA+0R4NQYNwUSmxmb95udFOdvDGXIjqfo2rrPjEdLRboa1+Bqad F0ywsXA+/aDN7yOQWAJx2XuP3X3bKVvbNhNj/1cVE+BVkxP/CHBBC9OpdqSJp5VX FRunzjEbcC9Ipc9kZUOUMtxOXfR/yRDp4yhy8iFlwE6cx8qdgp/PGyI2SyOV5v/S Fhzw0g== Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ejs8pu6a9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 04 Jun 2026 10:31:10 +0000 (GMT) Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-7dcd01ca614so7152007b3.0 for ; Thu, 04 Jun 2026 03:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780569070; x=1781173870; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FkfQG2WMLVGhh3lScAYNiUngeU3+aha52uzRutFQJNA=; b=VhuvuUVL7mpsnlsooYPesKXH0gIct+Fwkb6lJ+KFnNE6X4IZEv2bw1OOAj04zSb+RE c/KQe4EClTeGx+NbU73X8O1T+vpZs9Nj8SH9J0nqEOaumWGdeZrV+e5oFbRPCsCAibJZ mUFFRb2VmXU11oIZJbINkLmliHZ8xv/6oTaev7MRtnfP2j1tmSaOnARuJ3Ktwfg95fxz ElkP91lmJBSfg5GF6Jh8IzijD0OSsf3HkGv1T3v3nuYaXWZTxG9+eW5v5jMwMukHlqJT y+kkan5U5prnWBNSFSv9tfvuiixCLKLVHZrSbpAfFxhXAiTL4B/sDPWntQ1DyBqLUaLv hgpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780569070; x=1781173870; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FkfQG2WMLVGhh3lScAYNiUngeU3+aha52uzRutFQJNA=; b=OzEEe94064hTN4I287GrGtMsA3Lzf2xKkmvlG7WTkfSk8BAJLq8JbsWm3GjzGHNh1G M3eKKIk0mCxa663XvPBZJuojUr+eXVLjK8/Ic2EjrjEHgm0XN/+OuvJQu6yHb5ek6aSt bWMkVj5dojSa5v9+KQe2/zIHcrlrXlF0Fv3ox+fZ2HeoCtH9jM4ynybbc/HgBGdHVqhS iJh6ug+vDKmk4GUwf6PYrd9EDvdHgwFhczJwmoxnwUIG24BXZYrsZBymU6CiH0mGgd5I Qz09eLRh0uAlfIrH14rx8h8CqWYq4JFuB7dlGmN0NV62dF1Jt1UJiZzDW37mPhFasQ50 ZCqQ== X-Forwarded-Encrypted: i=1; AFNElJ+eytKzSIWsnZp0CZIxhXrF8TiqP50zols26jfQtORitFgXSre0Flv25ZEkOcnfy72jJi9JRLR3Dpze@nongnu.org X-Gm-Message-State: AOJu0YwMB8oYMGAX4/9+vgvLg+qXpIInsUTIP20h9W9RXdGR6DZxb1XB 37SFjXCdsVw0w4yuI8FwvqEwOISHTxRPg95TxdklG0n155f2mQnu02qCUMYplNfZ5lPjAz8yL1F 1RnLQtE8LMfXz+PnE4nKknmCSJWXC4bpg+rUqk90TzZM3CoAXXN9mOy6a7g== X-Gm-Gg: Acq92OFUKY1L6MoxYIfajcElPMw2nZUd4TgHoMlh659Q+gFE1Ye+g/gCJ1gRNVTdkG1 CP3I+2F5QL5hQ2f7b4UpSF6aa8YXC/ehgPA9cDo7vD+oOSlP/JOYkGbAzglz1x+WD2PWi0aOXHb xkFNuf9IG4IEI2bOHZI13ByN/lcE2JUug9gaY+BX+z4qSyEe72nepkExSdQgDhT6NMehAqE47+1 gCCCO3MnCgshV0ytnquOs35DRBXTISSL2VFSdpcKA0cXcD61dhuknslg3DmtaETtGLZzCYai66G /QBVJ7HEeiXaiFhTrUfAFix0ybRRgzgYM6wfcjnpSv0vp4hXodnd2zSjdlX6PNYMSINIs6Z0Ur0 wpVa1x7GkB/07V+srPxYSZEFw95n79r8uC1x16nvh789QHQWuZfmvtt904csjJ+Gzf+82 X-Received: by 2002:a05:690c:4b83:b0:7bd:5579:185a with SMTP id 00721157ae682-7ea49e6749amr68322367b3.25.1780569070098; Thu, 04 Jun 2026 03:31:10 -0700 (PDT) X-Received: by 2002:a05:690c:4b83:b0:7bd:5579:185a with SMTP id 00721157ae682-7ea49e6749amr68321927b3.25.1780569069719; Thu, 04 Jun 2026 03:31:09 -0700 (PDT) Received: from [192.168.68.106] ([177.170.117.62]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7ea20ea986bsm31791287b3.9.2026.06.04.03.31.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jun 2026 03:31:09 -0700 (PDT) Message-ID: Date: Thu, 4 Jun 2026 07:31:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 09/25] target/riscv/debug: Implement icount trigger textra matching To: Nicholas Piggin , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , bin.meng@windriver.com, vivahavey@gmail.com, Alvin Chang , Yu-Ming Chang , Joel Stanley References: <20260114044701.1173347-1-npiggin@gmail.com> <20260114044701.1173347-10-npiggin@gmail.com> From: Daniel Henrique Barboza Content-Language: en-US In-Reply-To: <20260114044701.1173347-10-npiggin@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: LvYJWn_chkW9UoMBBXFCbSsQHHW11QiT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA0MDEwMCBTYWx0ZWRfX1JXPkQohH4Si X6Gd6IBblQ4Rkov2DZhdzY7banpablv+YRDC/UDEb8ZsBMpbILkjffaRuWn5OqP7ESUUHDzYOFn qTYUliymzl+iSl1dJfzbUd4r1f6aiP2ngxUIEad25+GM0YLTYO4al5twts5z5VDdmhn+ACGM3Xf Pf8ybwteEuiIRu9W+RTrXOwe6L/FQQ3E94PY2YW7rnSm2RW7sJYOWRf85PhgDLZQyJvg2yvZAT6 z/BvwZxQs6bKFYVRXMEyiWn5mmvZCYGBVABPRcVLUJrd0eCGGF3Qc4AIOz49yqC63orgL6Ozior brFeCaaxgf9bHqJkn7ClbsOvwUftSIDOGt/dfK0eAgLP4HIqrm4A0Gr/UOKZyhuDAVmSDMJvR0y iDqovOftrhgnpO8zwgabOA5QqzlO3q2OMLJug6T/HX3MCIk2MD+g3e//E3Nm1NQY3uX1fk77T3c KRsEm9XqI8iu7Esc6Jg== X-Authority-Analysis: v=2.4 cv=E779Y6dl c=1 sm=1 tr=0 ts=6a2153ee cx=c_pps a=NMvoxGxYzVyQPkMeJjVPKg==:117 a=gdiugJE53z4H+vvYeRBHqw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=JvLbQTfvwFkklDSfm4gA:9 a=QEXdDO2ut3YA:10 a=kLokIza1BN8a-hAJ3hfR:22 X-Proofpoint-GUID: LvYJWn_chkW9UoMBBXFCbSsQHHW11QiT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-04_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 adultscore=0 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606040100 Received-SPF: pass client-ip=205.220.180.131; envelope-from=daniel.barboza@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On 1/14/2026 1:46 AM, Nicholas Piggin wrote: > icount triggers are subject to textra checks, per spec. > > Signed-off-by: Nicholas Piggin > --- Reviewed-by: Daniel Henrique Barboza > target/riscv/debug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/debug.c b/target/riscv/debug.c > index ecedffd3b9..d835c0e79a 100644 > --- a/target/riscv/debug.c > +++ b/target/riscv/debug.c > @@ -675,11 +675,12 @@ static bool check_itrigger_priv(CPURISCVState *env, int index) > bool riscv_itrigger_enabled(CPURISCVState *env) > { > int count; > + > for (int i = 0; i < RV_MAX_TRIGGERS; i++) { > if (get_trigger_type(env, i) != TRIGGER_TYPE_INST_CNT) { > continue; > } > - if (!check_itrigger_priv(env, i)) { > + if (!trigger_common_match(env, TRIGGER_TYPE_INST_CNT, i)) { > continue; > } > count = itrigger_get_count(env, i);