From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org,
linux-wireless-owner@vger.kernel.org
Subject: Re: [RFC 3/3] mac80211: add ieee80211_reorder_txq
Date: Tue, 28 Aug 2018 16:54:43 -0700 [thread overview]
Message-ID: <a0fa5a1bb754b56b6d076afa71d14c57@codeaurora.org> (raw)
In-Reply-To: <87d0u24wsw.fsf@toke.dk>
On 2018-08-28 03:20, Toke Høiland-Jørgensen wrote:
> Rajkumar Manoharan <rmanohar@codeaurora.org> writes:
>
> Ah, excellent; then it should be no problem to enforce the head node
> access; worst case the pull mechanism will be at a different point in
> the round-robin, which will sync up quickly.
>
>> Will fix it and rename as ieee80211_txq_can_transmit().
>
> Cool. If you send an updated patchset I can fold it into an updated
> version of my RFC and send it as a proper patch once I've verified
> everything works with ath9k :)
>
Sure. Found an issue in txq pause change. The drivers assume that
ieee80211_tx_dequeue() returns NULL only when txq is empty. Adding a
IEEE80211_TXQ_PAUSE check in tx_dequeue() breaks this assumption.
Moreover
once txq is paused, it should be queued to tail not at head.
Will send updated version ASAP.
-Rajkumar
prev parent reply other threads:[~2018-08-29 3:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 23:13 [RFC 0/3] mac80211: handle push-pull path in ATF Rajkumar Manoharan
2018-08-13 23:13 ` [RFC 1/3] mac80211: make airtime txq list per ac Rajkumar Manoharan
2018-08-13 23:13 ` [RFC 2/3] mac80211: pause txq transmission on negative airtime deficit Rajkumar Manoharan
2018-08-13 23:13 ` [RFC 3/3] mac80211: add ieee80211_reorder_txq Rajkumar Manoharan
2018-08-21 12:24 ` Toke Høiland-Jørgensen
2018-08-21 21:25 ` Rajkumar Manoharan
2018-08-22 11:10 ` Toke Høiland-Jørgensen
2018-08-27 18:34 ` Rajkumar Manoharan
2018-08-28 10:20 ` Toke Høiland-Jørgensen
2018-08-28 23:54 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0fa5a1bb754b56b6d076afa71d14c57@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.