All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: larsxschneider@gmail.com
Cc: git@vger.kernel.org, luke@diamand.org
Subject: Re: [PATCH v2 1/4] Add Travis CI support
Date: Mon, 05 Oct 2015 11:43:42 +0200	[thread overview]
Message-ID: <a10d494741e1252eb0d55d9120d00a07@dscho.org> (raw)
In-Reply-To: <1443981977-64604-2-git-send-email-larsxschneider@gmail.com>

Hi Lars,

On 2015-10-04 20:06, larsxschneider@gmail.com wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
> 
> The tests are executed on "Ubuntu 12.04 LTS Server Edition 64 bit" and
> on "OS X Mavericks" using gcc and clang.

I think that the word "currently" is missing from this description, as it is not something this patch controls (but Travis CI's infrastructure).

> Perforce and Git-LFS are installed and therefore available for the
> respective tests.

This is *the* bonus of using Travis CI over BuildHive (which is enabled in Git for Windows' fork of git/git): you can install additional dependencies for more extensive testing. Oh, and it tests with clang and on MacOSX, too, which would reduce the number of fixer-upper patches when git/git introduced yet Another Change That Works Only On Linux.

> +before_script:
> +  - >
> +    if [ ${TRAVIS_OS_NAME:-'linux'} = 'linux' ]; then

Maybe for readability use

    case "${TRAVIS_OS_NAME:-linux}" in
    linux)
        ...

?

Thanks,
Dscho

  reply	other threads:[~2015-10-05  9:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-04 18:06 [PATCH v2 0/4] Add Travis CI support larsxschneider
2015-10-04 18:06 ` [PATCH v2 1/4] " larsxschneider
2015-10-05  9:43   ` Johannes Schindelin [this message]
2015-10-04 18:06 ` [PATCH v2 2/4] Add prereq to detect OS X larsxschneider
2015-10-04 18:28   ` Junio C Hamano
2015-10-04 18:46     ` Lars Schneider
2015-10-04 18:06 ` [PATCH v2 3/4] git-p4: Fix t9815 git-p4-submit-fail test case on " larsxschneider
2015-10-04 18:23   ` Junio C Hamano
2015-10-04 18:44     ` Lars Schneider
2015-10-04 20:18       ` Pete Wyckoff
2015-10-05  3:08   ` Torsten Bögershausen
2015-10-04 18:06 ` [PATCH v2 4/4] git-p4: Disable t9819 git-p4-case-folding test " larsxschneider
2015-10-04 18:26   ` Junio C Hamano
2015-10-04 18:38     ` Lars Schneider
2015-10-04 18:49       ` Junio C Hamano
2015-10-05  9:55 ` [PATCH v2 0/4] Add Travis CI support Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a10d494741e1252eb0d55d9120d00a07@dscho.org \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=larsxschneider@gmail.com \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.