From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20BE7C433E2 for ; Fri, 28 Aug 2020 08:30:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F23712078A for ; Fri, 28 Aug 2020 08:30:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sdCwCAI9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728444AbgH1Iab (ORCPT ); Fri, 28 Aug 2020 04:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728269AbgH1Ia3 (ORCPT ); Fri, 28 Aug 2020 04:30:29 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4BB5C061264; Fri, 28 Aug 2020 01:30:28 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id j15so276766lfg.7; Fri, 28 Aug 2020 01:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LflMgJmibSpFeOHc4WL2YJ+POCyG0pEvbGVH5SBOv0E=; b=sdCwCAI9GltezF0rEB2fLfVxKx/8qRdfoKbbiRoFKxvVCYIkR3/N1t+zeTEEbig46m +Kyj/BDTYw6OGVtSPlqNjGOO+fv9AYhJPWBogZ4zZlmC2yxHp+dH2Ko7FVvt1wfQtAEJ C3EGMetrjmTC/sV3gobl9IyF5UkoeKSYqq3m2hVHVbaEPYOGuzFFd5jgWMxslMdgQGer 9+UFDbyhkm+yhdM7yCy9ywuHycOSmJv+CRYhHhUfXf/FoN7mgRZ9eqL8dvW5VmgrW/Oe mvL9YOYm9HUrthueMnVNdX9U8x9oc0gEqLz7mTAFACitArMxyd1dGhLSQEfC89ew0Qql tX3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LflMgJmibSpFeOHc4WL2YJ+POCyG0pEvbGVH5SBOv0E=; b=gCsHhKqohe0/MSCkH+0iFeWo2ANHY2pdneE5uK8GqO9Tbsr3R8wef5psDc4g5nwfjw iWBRHA0dxxQ1wJjYX+iQ6MTPpz767pDdzSQJ5D6FA3wteboI8Y6GCoPQ8BRuLBmG0q1J XEZABPxA14rT9Hx9lYY4EmV8HTtIyRd586HXQ+xv9FvGe46S7m6e8SPPXUsmAnJBKIXt 9bXGSt5Xxqu1oevArpUghSGEPU6lL1a5iq3sepx3G4bnsDEjzD6klEcpDjkPziULV1MC /743Z72sx6etFDifID3tr4yBCdhkfFn2zTLxMLhjBbRDXYv0sOr84aD9nWSMXx0VyCku Wyzw== X-Gm-Message-State: AOAM532+vJoP3yOfEk5DfzLdFC45gD4DMO8c6Xhh2QkH5Az26l5Qfts9 P/cM65bHlEosFoK17lVAsoKjO+Z91co= X-Google-Smtp-Source: ABdhPJzLnvqVFe/sNW/j+lmpEBM4x5/CZ5x6tV+zcsDznlhemeqh60v+eDDBRVDdroYZaI53iNUCkA== X-Received: by 2002:a19:24c2:: with SMTP id k185mr276673lfk.120.1598603426636; Fri, 28 Aug 2020 01:30:26 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id h6sm130676lfc.84.2020.08.28.01.30.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2020 01:30:25 -0700 (PDT) Subject: Re: [PATCH v5 13/36] PM / devfreq: tegra30: Use MC timings for building OPP table To: Chanwoo Choi , Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Mikko Perttunen Cc: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org References: <20200814000621.8415-1-digetx@gmail.com> <20200814000621.8415-14-digetx@gmail.com> <1b0d75fe-79af-70eb-8450-999a3bc72bac@samsung.com> <1de8aa41-8001-cf46-026c-b00f8df0b9a3@gmail.com> <2a255211-5426-d78f-d266-cdb958f4c658@samsung.com> From: Dmitry Osipenko Message-ID: Date: Fri, 28 Aug 2020 11:30:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2a255211-5426-d78f-d266-cdb958f4c658@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org 28.08.2020 04:47, Chanwoo Choi пишет: > Hi, ... >> Hence the NULL-checking is unnecessary. >> >> When I first encountered the of_device_get_match_data(), I was also >> thinking that adding the NULL-checks is a good idea, but later on >> somebody pointed out to me (maybe Thierry) that it's unnecessary to do. > > OK. Thanks. > >> >>>> + >>>> + mc = tegra_get_memory_controller(soc_data->mc_compatible); >>>> + if (IS_ERR(mc)) >>>> + return PTR_ERR(mc); >>> >>> You better to add error log. >> >> In practice we should get only -EPROBE_DEFER here ever. I'll consider >> adding the message in the next revision, at least just for consistency. > > In order to handle -EPROBE_DEFER, recommend the using of dev_err_probe(). Hello, Chanwoo! Thank you for the suggestion! I wasn't aware about the dev_err_probe() until recently and will use this new helper in the v6! Thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6AE4C433E6 for ; Sat, 29 Aug 2020 09:22:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC37420825 for ; Sat, 29 Aug 2020 09:22:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sdCwCAI9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC37420825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CD8E6EC14; Sat, 29 Aug 2020 09:22:04 +0000 (UTC) Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54E4F89AAD for ; Fri, 28 Aug 2020 08:30:28 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id k10so277126lfm.5 for ; Fri, 28 Aug 2020 01:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LflMgJmibSpFeOHc4WL2YJ+POCyG0pEvbGVH5SBOv0E=; b=sdCwCAI9GltezF0rEB2fLfVxKx/8qRdfoKbbiRoFKxvVCYIkR3/N1t+zeTEEbig46m +Kyj/BDTYw6OGVtSPlqNjGOO+fv9AYhJPWBogZ4zZlmC2yxHp+dH2Ko7FVvt1wfQtAEJ C3EGMetrjmTC/sV3gobl9IyF5UkoeKSYqq3m2hVHVbaEPYOGuzFFd5jgWMxslMdgQGer 9+UFDbyhkm+yhdM7yCy9ywuHycOSmJv+CRYhHhUfXf/FoN7mgRZ9eqL8dvW5VmgrW/Oe mvL9YOYm9HUrthueMnVNdX9U8x9oc0gEqLz7mTAFACitArMxyd1dGhLSQEfC89ew0Qql tX3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LflMgJmibSpFeOHc4WL2YJ+POCyG0pEvbGVH5SBOv0E=; b=a/AsGrcTAksaKHATkc6hiY3kHDkTyEHOHaPhQ8B6XymWs+s6xtBTM6GxXUGSDtve5N 4YfDzGMUcCWQ9CUUvAv37GNtFonh53rfpbEL7UldauLtdZee9FXEPHHtuO8i7Ilvme5B juwhHgPsJCqeEgizosOCZToP2qS82L0y+N7Y3W7nLRfBgJNrwfytUkgoQTbDusJyEhAF zh3lFITyhdqYRwLUeOD1KoXeqLRJJTAWbCNU+gwqR6AUCZHYezpXbDQmcTv7sesThGaj QiVHYCFoh4VbqxHp6RtRvG57taHVZIqM+j5QjdVuY4K+tiflmwGHLpyLf126wRA/OyY/ waag== X-Gm-Message-State: AOAM533QvJ9MI8XsD+kaNUpVeU9VMNvZaaPRX6vjQ00C91MNOA/+tR+H Pl7mEVn4KZ4QKf/QrcqXOAo= X-Google-Smtp-Source: ABdhPJzLnvqVFe/sNW/j+lmpEBM4x5/CZ5x6tV+zcsDznlhemeqh60v+eDDBRVDdroYZaI53iNUCkA== X-Received: by 2002:a19:24c2:: with SMTP id k185mr276673lfk.120.1598603426636; Fri, 28 Aug 2020 01:30:26 -0700 (PDT) Received: from [192.168.2.145] (109-252-170-211.dynamic.spd-mgts.ru. [109.252.170.211]) by smtp.googlemail.com with ESMTPSA id h6sm130676lfc.84.2020.08.28.01.30.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2020 01:30:25 -0700 (PDT) Subject: Re: [PATCH v5 13/36] PM / devfreq: tegra30: Use MC timings for building OPP table To: Chanwoo Choi , Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Mikko Perttunen References: <20200814000621.8415-1-digetx@gmail.com> <20200814000621.8415-14-digetx@gmail.com> <1b0d75fe-79af-70eb-8450-999a3bc72bac@samsung.com> <1de8aa41-8001-cf46-026c-b00f8df0b9a3@gmail.com> <2a255211-5426-d78f-d266-cdb958f4c658@samsung.com> From: Dmitry Osipenko Message-ID: Date: Fri, 28 Aug 2020 11:30:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2a255211-5426-d78f-d266-cdb958f4c658@samsung.com> Content-Language: en-US X-Mailman-Approved-At: Sat, 29 Aug 2020 09:21:18 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjguMDguMjAyMCAwNDo0NywgQ2hhbndvbyBDaG9pINC/0LjRiNC10YI6Cj4gSGksCi4uLgo+PiBI ZW5jZSB0aGUgTlVMTC1jaGVja2luZyBpcyB1bm5lY2Vzc2FyeS4KPj4KPj4gV2hlbiBJIGZpcnN0 IGVuY291bnRlcmVkIHRoZSBvZl9kZXZpY2VfZ2V0X21hdGNoX2RhdGEoKSwgSSB3YXMgYWxzbwo+ PiB0aGlua2luZyB0aGF0IGFkZGluZyB0aGUgTlVMTC1jaGVja3MgaXMgYSBnb29kIGlkZWEsIGJ1 dCBsYXRlciBvbgo+PiBzb21lYm9keSBwb2ludGVkIG91dCB0byBtZSAobWF5YmUgVGhpZXJyeSkg dGhhdCBpdCdzIHVubmVjZXNzYXJ5IHRvIGRvLgo+IAo+IE9LLiBUaGFua3MuCj4gCj4+Cj4+Pj4g Kwo+Pj4+ICsJbWMgPSB0ZWdyYV9nZXRfbWVtb3J5X2NvbnRyb2xsZXIoc29jX2RhdGEtPm1jX2Nv bXBhdGlibGUpOwo+Pj4+ICsJaWYgKElTX0VSUihtYykpCj4+Pj4gKwkJcmV0dXJuIFBUUl9FUlIo bWMpOwo+Pj4KPj4+IFlvdSBiZXR0ZXIgdG8gYWRkIGVycm9yIGxvZy4KPj4KPj4gSW4gcHJhY3Rp Y2Ugd2Ugc2hvdWxkIGdldCBvbmx5IC1FUFJPQkVfREVGRVIgaGVyZSBldmVyLiBJJ2xsIGNvbnNp ZGVyCj4+IGFkZGluZyB0aGUgbWVzc2FnZSBpbiB0aGUgbmV4dCByZXZpc2lvbiwgYXQgbGVhc3Qg anVzdCBmb3IgY29uc2lzdGVuY3kuCj4gCj4gSW4gb3JkZXIgdG8gaGFuZGxlIC1FUFJPQkVfREVG RVIsIHJlY29tbWVuZCB0aGUgdXNpbmcgb2YgZGV2X2Vycl9wcm9iZSgpLgoKSGVsbG8sIENoYW53 b28hCgpUaGFuayB5b3UgZm9yIHRoZSBzdWdnZXN0aW9uISBJIHdhc24ndCBhd2FyZSBhYm91dCB0 aGUgZGV2X2Vycl9wcm9iZSgpCnVudGlsIHJlY2VudGx5IGFuZCB3aWxsIHVzZSB0aGlzIG5ldyBo ZWxwZXIgaW4gdGhlIHY2IQoKVGhhbmtzIQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK