From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAFB9C433E0 for ; Mon, 11 Jan 2021 20:30:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEFDF21BE5 for ; Mon, 11 Jan 2021 20:30:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEFDF21BE5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 00E361743; Mon, 11 Jan 2021 21:29:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 00E361743 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610397047; bh=9Pm4rCC+sqUb4lyvDSk8VEmesWovQ/lZhQLOo9ano0A=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YpXGfVHM453Nz/miyk3TQjlz/O8Y6evZyVNxP67Lq6ke+3GqtU1+alqzpEYHWPTqf AJoSSr2VjtA/p/+bcKDGyvWOzFSBEdZ2WsFKlnmI7LYTOW7vyVMQwJ+Kl2qu4vtR6g ChXdBPEF1a52BqJHmxu7L5sliEh7tq6n+Yx/ikQA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 24175F804C3; Mon, 11 Jan 2021 21:29:03 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AD6C1F8026D; Mon, 11 Jan 2021 21:28:56 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6D880F800BE for ; Mon, 11 Jan 2021 21:28:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6D880F800BE IronPort-SDR: JIXwqjwvH+IcNBpSOe3Tq2zi2TgKfC2Z9A08Lg/3OLdiEcOqbBFueToq9AHbOirIEcRSAZ5PjY Ycx3pTofSdnA== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="262712514" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="262712514" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 12:28:39 -0800 IronPort-SDR: v9xqixeOBz2f8oC/DhiwiKLZhaoneHTa9DPlR/LcDCVlgenEO/nzD/c1u5c6muexJAQwe9xvY9 fGYHtIf781LQ== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="344995381" Received: from gkbech1x-mobl.amr.corp.intel.com (HELO [10.212.87.85]) ([10.212.87.85]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 12:28:37 -0800 Subject: Re: [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control support To: Perry Yuan , oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com References: <20201228133831.17464-1-Perry_Yuan@Dell.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 11 Jan 2021 12:07:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201228133831.17464-1-Perry_Yuan@Dell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com, Limonciello Mario X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > @@ -268,6 +269,7 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol, > unsigned int reg2 = mc->rreg; > unsigned int reg = mc->reg; > unsigned int max = mc->max; > + unsigned int val0, val1; > int err; > > val = ucontrol->value.integer.value[0]; > @@ -286,7 +288,22 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol, > if (err < 0) > return err; > } > - > +#if IS_ENABLED(CONFIG_DELL_PRIVACY) > + /* Privacy LED Trigger State Changed by muted/unmute switch */ > + if (mc->invert) { > + val0 = ucontrol->value.integer.value[0]; > + val1 = ucontrol->value.integer.value[1]; > + if (val0 == 1 && val1 == 1) { > + rt715->micmute_led = LED_OFF; > + ledtrig_audio_set(LED_AUDIO_MICMUTE, > + rt715->micmute_led ? LED_ON : LED_OFF); > + } else if (val0 == 0 && val1 == 0) { > + rt715->micmute_led = LED_ON; > + ledtrig_audio_set(LED_AUDIO_MICMUTE, > + rt715->micmute_led ? LED_ON : LED_OFF); > + } > + } > +#endif Should this be activated for specific DMI quirks? This driver is used in non-Dell platforms (I am thinking of Intel RVPs or Realtek daughterboards), I am not sure if a build-time behavior change makes sense. Or conversely could we just set the LEDs unconditionally if doing so is harmless? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42613C433DB for ; Mon, 11 Jan 2021 20:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D7A522CE3 for ; Mon, 11 Jan 2021 20:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388760AbhAKUbi (ORCPT ); Mon, 11 Jan 2021 15:31:38 -0500 Received: from mga12.intel.com ([192.55.52.136]:38637 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731050AbhAKUbi (ORCPT ); Mon, 11 Jan 2021 15:31:38 -0500 IronPort-SDR: LhpIy6rZdfNdQuwhnElWmxuLObsJCQ9PCggrA+362RJcovh6t74xSJD3mQ2/L4CNfHkFro//+p 721vc45rvuVw== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="157110623" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="157110623" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 12:28:39 -0800 IronPort-SDR: v9xqixeOBz2f8oC/DhiwiKLZhaoneHTa9DPlR/LcDCVlgenEO/nzD/c1u5c6muexJAQwe9xvY9 fGYHtIf781LQ== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="344995381" Received: from gkbech1x-mobl.amr.corp.intel.com (HELO [10.212.87.85]) ([10.212.87.85]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 12:28:37 -0800 Subject: Re: [PATCH v2 2/2] ASoC: rt715:add Mic Mute LED control support To: Perry Yuan , oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com Cc: alsa-devel@alsa-project.org, Limonciello Mario , lgirdwood@gmail.com, linux-kernel@vger.kernel.org, broonie@kernel.org References: <20201228133831.17464-1-Perry_Yuan@Dell.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 11 Jan 2021 12:07:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201228133831.17464-1-Perry_Yuan@Dell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -268,6 +269,7 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol, > unsigned int reg2 = mc->rreg; > unsigned int reg = mc->reg; > unsigned int max = mc->max; > + unsigned int val0, val1; > int err; > > val = ucontrol->value.integer.value[0]; > @@ -286,7 +288,22 @@ static int rt715_sdca_put_volsw(struct snd_kcontrol *kcontrol, > if (err < 0) > return err; > } > - > +#if IS_ENABLED(CONFIG_DELL_PRIVACY) > + /* Privacy LED Trigger State Changed by muted/unmute switch */ > + if (mc->invert) { > + val0 = ucontrol->value.integer.value[0]; > + val1 = ucontrol->value.integer.value[1]; > + if (val0 == 1 && val1 == 1) { > + rt715->micmute_led = LED_OFF; > + ledtrig_audio_set(LED_AUDIO_MICMUTE, > + rt715->micmute_led ? LED_ON : LED_OFF); > + } else if (val0 == 0 && val1 == 0) { > + rt715->micmute_led = LED_ON; > + ledtrig_audio_set(LED_AUDIO_MICMUTE, > + rt715->micmute_led ? LED_ON : LED_OFF); > + } > + } > +#endif Should this be activated for specific DMI quirks? This driver is used in non-Dell platforms (I am thinking of Intel RVPs or Realtek daughterboards), I am not sure if a build-time behavior change makes sense. Or conversely could we just set the LEDs unconditionally if doing so is harmless?