From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fxQRP-0002Rx-7n for ath10k@lists.infradead.org; Wed, 05 Sep 2018 05:33:24 +0000 MIME-Version: 1.0 Date: Wed, 05 Sep 2018 13:33:12 +0800 From: Carl Huang Subject: Re: [PATCH 3/3] ath10k: download firmware via diag Copy Engine for QCA6174 and QCA9377. In-Reply-To: <87musw7dh2.fsf@kamboji.qca.qualcomm.com> References: <1535596182-18038-1-git-send-email-cjhuang@codeaurora.org> <1535596182-18038-4-git-send-email-cjhuang@codeaurora.org> <87musw7dh2.fsf@kamboji.qca.qualcomm.com> Message-ID: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org On 2018-09-05 12:52, Kalle Valo wrote: > Carl Huang writes: > >> Downloading firmware via BMI protocol takes too long time. For >> example, >> a ~700K bytes firmware takes about 500ms to download via BMI protocol. >> This is too long especially in suspend and resume scenario where >> firmware >> is re-downloaded unless WoWLAN is enabled. Downloading firmware via >> diag CE >> can reduce the time to ~40ms for a ~700K bytes firmware binary. >> >> Ath10k driver parses the firmware to segments and downloads the >> segments >> to the specified address directly. If the firmware is compressed or >> has >> unsupported segments, ath10k driver will try BMI download again. >> >> It's tested with QCA6174 hw3.2 and >> firmware-6.bin_WLAN.RM.4.4.1-00111-QCARMSWP-1. QCA9377 is also >> affected. >> >> Signed-off-by: Carl Huang > > There were new warnings: > > drivers/net/wireless/ath/ath10k/hw.c:1029:16: warning: restricted > __le32 degrades to integer > drivers/net/wireless/ath/ath10k/hw.c:1047:27: warning: incorrect type > in assignment (different base types) > drivers/net/wireless/ath/ath10k/hw.c:1047:27: expected unsigned int > [unsigned] [usertype] base_addr > drivers/net/wireless/ath/ath10k/hw.c:1047:27: got restricted __le32 > [usertype] addr > drivers/net/wireless/ath/ath10k/hw.c:1048:26: warning: incorrect type > in assignment (different base types) > drivers/net/wireless/ath/ath10k/hw.c:1048:26: expected unsigned int > [unsigned] [usertype] base_len > drivers/net/wireless/ath/ath10k/hw.c:1048:26: got restricted __le32 > [usertype] length > > I fixed those in the pending branch, please review: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=f6f6f597654693ab122ecd950b56343489b91e59 Kalle, Thank you for fixing the warnings. I don't see any issues with this warning fix. Thanks, Carl _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:46562 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727606AbeIEKBk (ORCPT ); Wed, 5 Sep 2018 06:01:40 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Date: Wed, 05 Sep 2018 13:33:12 +0800 From: Carl Huang To: Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 3/3] ath10k: download firmware via diag Copy Engine for QCA6174 and QCA9377. In-Reply-To: <87musw7dh2.fsf@kamboji.qca.qualcomm.com> References: <1535596182-18038-1-git-send-email-cjhuang@codeaurora.org> <1535596182-18038-4-git-send-email-cjhuang@codeaurora.org> <87musw7dh2.fsf@kamboji.qca.qualcomm.com> Message-ID: (sfid-20180905_073315_381630_C8587248) Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2018-09-05 12:52, Kalle Valo wrote: > Carl Huang writes: > >> Downloading firmware via BMI protocol takes too long time. For >> example, >> a ~700K bytes firmware takes about 500ms to download via BMI protocol. >> This is too long especially in suspend and resume scenario where >> firmware >> is re-downloaded unless WoWLAN is enabled. Downloading firmware via >> diag CE >> can reduce the time to ~40ms for a ~700K bytes firmware binary. >> >> Ath10k driver parses the firmware to segments and downloads the >> segments >> to the specified address directly. If the firmware is compressed or >> has >> unsupported segments, ath10k driver will try BMI download again. >> >> It's tested with QCA6174 hw3.2 and >> firmware-6.bin_WLAN.RM.4.4.1-00111-QCARMSWP-1. QCA9377 is also >> affected. >> >> Signed-off-by: Carl Huang > > There were new warnings: > > drivers/net/wireless/ath/ath10k/hw.c:1029:16: warning: restricted > __le32 degrades to integer > drivers/net/wireless/ath/ath10k/hw.c:1047:27: warning: incorrect type > in assignment (different base types) > drivers/net/wireless/ath/ath10k/hw.c:1047:27: expected unsigned int > [unsigned] [usertype] base_addr > drivers/net/wireless/ath/ath10k/hw.c:1047:27: got restricted __le32 > [usertype] addr > drivers/net/wireless/ath/ath10k/hw.c:1048:26: warning: incorrect type > in assignment (different base types) > drivers/net/wireless/ath/ath10k/hw.c:1048:26: expected unsigned int > [unsigned] [usertype] base_len > drivers/net/wireless/ath/ath10k/hw.c:1048:26: got restricted __le32 > [usertype] length > > I fixed those in the pending branch, please review: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=f6f6f597654693ab122ecd950b56343489b91e59 Kalle, Thank you for fixing the warnings. I don't see any issues with this warning fix. Thanks, Carl