From: Ping-Ke Shih <pkshih@realtek.com>
To: Luka Gejak <luka.gejak@linux.dev>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michael Straube" <straube.linux@gmail.com>,
Peter Robinson <pbrobinson@gmail.com>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: RE: [PATCH rtw-next v7 1/6] wifi: rtw88: move the 88xxa CCK power detect setter to phy.c
Date: Mon, 5 Oct 2026 03:52:31 +0000 [thread overview]
Message-ID: <a1348f5983584cd1a80a27d408825fe5@realtek.com> (raw)
In-Reply-To: <20261002073845.31486-2-luka.gejak@linux.dev>
Luka Gejak <luka.gejak@linux.dev> wrote:
> The CCK power detect setter in rtw88xxa.c programs values that are not
> specific to that chip family. The RTL8723B wants the same setter, but
> pulling in the whole rtw88_88xxa module for one helper is not worth it.
>
> Move it to phy.c as rtw_phy_cck_pd_set(), where the rest of the CCK power
> detect code and the level enum already live. rtw8812a and rtw8821a call
> the core version, so rtw88xxa.c no longer provides it.
Like this patch, you just move the function, no change logic.
Please add "no logic change at all" to commit message.
>
> Signed-off-by: Luka Gejak <luka.gejak@linux.dev>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2026-10-05 3:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 7:38 [PATCH rtw-next v7 0/6] wifi: rtw88: add RTL8723B/RTL8723BS support Luka Gejak
2026-10-02 7:38 ` [PATCH rtw-next v7 1/6] wifi: rtw88: move the 88xxa CCK power detect setter to phy.c Luka Gejak
2026-10-05 3:52 ` Ping-Ke Shih [this message]
2026-10-02 7:38 ` [PATCH rtw-next v7 2/6] wifi: rtw88: 8723b: add the RTL8723B register definitions Luka Gejak
2026-10-05 3:54 ` Ping-Ke Shih
2026-10-02 7:38 ` [PATCH rtw-next v7 3/6] wifi: rtw88: 8723b: add the RTL8723B BB, RF and AGC tables Luka Gejak
2026-10-05 3:58 ` Ping-Ke Shih
2026-10-02 7:38 ` [PATCH rtw-next v7 4/6] wifi: rtw88: 8723b: add the RTL8723B chip driver Luka Gejak
2026-10-05 6:08 ` Ping-Ke Shih
2026-10-05 13:30 ` Luka Gejak
2026-10-06 0:39 ` Ping-Ke Shih
2026-10-06 4:30 ` Luka Gejak
2026-10-06 5:29 ` Ping-Ke Shih
2026-10-06 7:07 ` Luka Gejak
2026-10-06 9:05 ` Luka Gejak
2026-10-06 10:41 ` Luka Gejak
2026-10-06 12:38 ` Ping-Ke Shih
2026-10-06 11:18 ` Bitterblue Smith
2026-10-06 12:19 ` Luka Gejak
2026-10-02 7:38 ` [PATCH rtw-next v7 5/6] wifi: rtw88: 8723bs: add the RTL8723BS SDIO bind Luka Gejak
2026-10-05 6:09 ` Ping-Ke Shih
2026-10-02 7:38 ` [PATCH rtw-next v7 6/6] wifi: rtw88: 8723bs: enable building the RTL8723BS driver Luka Gejak
2026-10-05 6:10 ` Ping-Ke Shih
2026-10-03 21:26 ` [PATCH rtw-next v7 0/6] wifi: rtw88: add RTL8723B/RTL8723BS support Bitterblue Smith
2026-10-03 21:46 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1348f5983584cd1a80a27d408825fe5@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=pbrobinson@gmail.com \
--cc=rtl8821cerfe2@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.