From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net v2 3/5] mptcp: fix status reset on disconnect()
Date: Tue, 8 Jul 2025 17:43:19 +0200 [thread overview]
Message-ID: <a165fd13-3f27-41de-8a51-77ca6838cd72@kernel.org> (raw)
In-Reply-To: <a5a1798e9f474cf8f8c518ce1b47aebf4b7d5528.1751700000.git.pabeni@redhat.com>
Hi Paolo,
On 05/07/2025 09:24, Paolo Abeni wrote:
> disconnect() can still race with subflow fallback leaving the msk in
> inconsistent status. To avoid such race, disconnect() must be blocking,
> error out if the argument prevent such wait: the socket will linger
> in SS_DISCONNECT state forever.
Good idea!
Just to be sure, this is not really a behaviour change compared to TCP,
right?
No risks of breaking some cases? (io_uring, etc.?)
In which cases is this MSG_DONTWAIT flag set with disconnect()?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-07-08 15:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-05 7:24 [PATCH mptcp-net v2 0/5] mptcp: fix fallback-related races Paolo Abeni
2025-07-05 7:24 ` [PATCH mptcp-net v2 1/5] mptcp: make fallback action and fallback decision atomic Paolo Abeni
2025-07-08 14:54 ` Matthieu Baerts
2025-07-08 15:13 ` Matthieu Baerts
2025-07-09 9:09 ` Paolo Abeni
2025-07-05 7:24 ` [PATCH mptcp-net v2 2/5] mptcp: plug races between subflow fail and subflow creation Paolo Abeni
2025-07-08 15:42 ` Matthieu Baerts
2025-07-09 9:14 ` Paolo Abeni
2025-07-09 9:18 ` Matthieu Baerts
2025-07-05 7:24 ` [PATCH mptcp-net v2 3/5] mptcp: fix status reset on disconnect() Paolo Abeni
2025-07-08 15:43 ` Matthieu Baerts [this message]
2025-07-09 9:27 ` Paolo Abeni
2025-07-09 10:39 ` Matthieu Baerts
2025-07-09 10:49 ` Paolo Abeni
2025-07-09 10:55 ` Matthieu Baerts
2025-07-09 12:33 ` Paolo Abeni
2025-07-05 7:24 ` [PATCH mptcp-net v2 4/5] mptcp: track fallbacks accurately via mibs Paolo Abeni
2025-07-08 15:56 ` Matthieu Baerts
2025-07-09 9:55 ` Paolo Abeni
2025-07-09 10:23 ` Paolo Abeni
2025-07-09 10:42 ` Matthieu Baerts
2025-07-09 10:55 ` Matthieu Baerts
2025-07-05 7:24 ` [PATCH mptcp-net v2 5/5] mptcp: remove pr_fallback() Paolo Abeni
2025-07-05 18:04 ` kernel test robot
2025-07-08 15:57 ` Matthieu Baerts
2025-07-07 7:43 ` [PATCH mptcp-net v2 0/5] mptcp: fix fallback-related races MPTCP CI
2025-07-07 8:47 ` MPTCP CI
2025-07-08 15:41 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a165fd13-3f27-41de-8a51-77ca6838cd72@kernel.org \
--to=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.