From: Tejun Heo <tj@kernel.org>
To: Emil Tsalapatis <emil@etsalapatis.com>
Cc: sched-ext@lists.linux.dev, changwoo@igalia.com,
arighi@nvidia.com, void@manifault.com
Subject: Re: [PATCH v3 3/3] tools/sched_ext: add arena based scheduler
Date: Tue, 27 Jan 2026 16:05:10 -1000 [thread overview]
Message-ID: <a16cc5a7a8f6db10763e0347a0f3759a@kernel.org> (raw)
In-Reply-To: <20260123032605.49140-4-emil@etsalapatis.com>
[This is a AI generated review by Claude Opus 4.5]
> + pos = idx & mask;
> + data = chunk->data[pos];
> + if (likely(data)) {
> + data[pos] = (struct sdt_data) {
> + .tid.genn = data->tid.genn + 1,
> + };
data already points to chunk->data[pos], so data[pos] double-indexes and
writes to the wrong memory location. This should be *data. The payload
zeroing loop below correctly uses data->payload[i], so this is just the
struct assignment that's off.
Please send a fix.
next prev parent reply other threads:[~2026-01-28 2:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 3:26 [PATCH v3 0/3] tools/sched_ext: Add example C schedulers Emil Tsalapatis
2026-01-23 3:26 ` [PATCH v3 1/3] tools/sched_ext: add scx_userland scheduler Emil Tsalapatis
2026-01-23 3:26 ` [PATCH v3 2/3] tools/sched_ext: add scx_pair scheduler Emil Tsalapatis
2026-01-23 3:26 ` [PATCH v3 3/3] tools/sched_ext: add arena based scheduler Emil Tsalapatis
2026-01-28 2:05 ` Tejun Heo [this message]
2026-01-28 2:05 ` [PATCH v3 0/3] tools/sched_ext: Add example C schedulers Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a16cc5a7a8f6db10763e0347a0f3759a@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=emil@etsalapatis.com \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.