From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E5A3C2D0A8 for ; Mon, 28 Sep 2020 10:27:47 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 080A6206C9 for ; Mon, 28 Sep 2020 10:27:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 080A6206C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E37071D6F8; Mon, 28 Sep 2020 12:27:44 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 594161D6F4 for ; Mon, 28 Sep 2020 12:27:43 +0200 (CEST) IronPort-SDR: sZggcPVZ4RovJT+aS5SKU3SLz3sXMpS49vpyGpCdotjCzSwGiJgOVSC3cAdYa+ZLxJKQqsfC3J 5YNd6gK0Tj4g== X-IronPort-AV: E=McAfee;i="6000,8403,9757"; a="149634728" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="149634728" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 03:27:40 -0700 IronPort-SDR: +AaS8b68/7WVG2QgfGdeCrujXqMppb5w6hJ8sYUTaN8iya+RMgJe7aCKJ5JBo8c1QXGP+kvlFW wZI7c/H8x2HQ== X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="456771546" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.193.117]) ([10.213.193.117]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 03:27:38 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: thomas@monjalon.net, linuxarm@huawei.com, konstantin.ananyev@intel.com, arybchenko@solarflare.com References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1601023147-57193-1-git-send-email-humin29@huawei.com> <5c2f80f1-dce7-a3cb-9a5f-2879d27ed76e@huawei.com> From: Ferruh Yigit Message-ID: Date: Mon, 28 Sep 2020 11:27:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <5c2f80f1-dce7-a3cb-9a5f-2879d27ed76e@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH V13 0/3] add FEC support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/27/2020 8:08 AM, Min Hu (Connor) wrote: > Hello, >     Are there any suggustions for this set patches ? > > > 在 2020/9/25 16:39, Min Hu (Connor) 写道: >> This series add FEC support for ethdev. >> >> Min Hu (Connor) (3): >>    ethdev: introduce FEC API >>    net/hns3: support FEC >>    app/testpmd: add FEC command >> >>   app/test-pmd/cmdline.c                   | 223 +++++++++++++++++++ >>   app/test-pmd/config.c                    |  91 ++++++++ >>   app/test-pmd/testpmd.h                   |   2 + >>   doc/guides/rel_notes/release_20_11.rst   |  10 + >>   drivers/net/hns3/hns3_cmd.h              |  19 +- >>   drivers/net/hns3/hns3_ethdev.c           | 356 +++++++++++++++++++++++++++++++ >>   drivers/net/hns3/hns3_ethdev.h           |   1 + >>   lib/librte_ethdev/rte_ethdev.c           |  43 ++++ >>   lib/librte_ethdev/rte_ethdev.h           |  94 ++++++++ >>   lib/librte_ethdev/rte_ethdev_driver.h    |  80 +++++++ >>   lib/librte_ethdev/rte_ethdev_version.map |   3 + >>   11 files changed, 921 insertions(+), 1 deletion(-) >> Hi Connor, Can you please make a new version addressing the minor issues Andrew highlighted and including his ack? Thanks, ferruh