From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:cf90:b0:9bd:85f7:2662 with SMTP id um16csp771039ejb; Thu, 19 Oct 2023 13:20:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1NG2LFPBZdfsx0vQb3QNv4QIhdPeIHHNzfmJ8ONScZa8ShCCOJkjjDKVUVuFdjvO+y1pi X-Received: by 2002:a05:620a:1a0b:b0:774:1c60:4b16 with SMTP id bk11-20020a05620a1a0b00b007741c604b16mr3902293qkb.49.1697746819112; Thu, 19 Oct 2023 13:20:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697746819; cv=none; d=google.com; s=arc-20160816; b=cTQyLwbib25/wB3/DaottTye+VWfF/UPPcLo1ZPWvMu0u5VFYBGKvoo8Rw+nP83LNg 9iZkIsL/j5JGNcklLp/81Fh02bvjCgdfvyETP9iFjLQU6A6ka8HgtXFvdoFkCqpRmFoo ZPT1vGTXYwfcBuiORa5PpXsEq0ZSzyT5xKp8QTJHErRbJXjPjr/jlu5QaTUCogIPr2Lh UIfTesaHqBczYsVvmn2fAGubnjGttnldAIShpXOB4/6vQJMNU3oLqhymubEy8nxVs/TC 8Ttw/FbM8y4g4j0LuSjCjktbaFETKgu2lDLBu+VVoU1AL+hLuw3j3XloHOxDV8srDoxE R7rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=V3UMxFvfmv7WSj9863Vfdwh+2Pd4meyaFjMizB3RxYM=; fh=nDcgOyJ5wI4ec5cBWrHogeHeYCn4pzALdxpM3FX1gnA=; b=GDlOyc3LH1tWEQMINOtoxNm2FhcRl97lc5yCg3bRJ7PPvo/rAxOoltZWxRn8ZbPFAG 9V/YissT0WzRAWx9YNwKCwmrsEbCYKhOMQYk2geNFhbW0I51ttY6MLulzH70xICyz/3s zMUb4M5ShvIgHGd/pKl5ssyHx+tcEX3fsVmTZxkc0yypl8pMVLnQnhULEBJ5IcyLCbAv bL4Ry/VGj3pt+RlOrBmz5USrY3dmYK2L3+4cF1IpELBM8c4AqTEvfjfeZV8P2rCuPRcq OcpNE6c9+9D2LBqx9Qoxm6LziRspDkWNYaiNMHbdSIFS7+QI9T7xKa4TGSaBWQNZ4Ciy sOxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=MPvP5od1; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id az42-20020a05620a172a00b0077424168fa1si180597qkb.629.2023.10.19.13.20.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 19 Oct 2023 13:20:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=MPvP5od1; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtZUb-0004FI-5q; Thu, 19 Oct 2023 16:19:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtZUZ-0004ER-Mc; Thu, 19 Oct 2023 16:19:39 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtZUY-0007wq-2f; Thu, 19 Oct 2023 16:19:39 -0400 Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39JKHN2h026647; Thu, 19 Oct 2023 20:19:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=V3UMxFvfmv7WSj9863Vfdwh+2Pd4meyaFjMizB3RxYM=; b=MPvP5od1EE3mDkoIx6Ou5dRgxHH0flYdsjD5EKdhGAY2RifSQ3+q3yevWM4Di0SkZT4v 5nIr+6XcQOFL2uFFWF6kSuACT5CUfFAb4earxGT40t6a5axiOlsiOjvpgctibUWZ+04Y JqwwRi648yUyqZ3uZFGweGnqsDVNsunz5D3o9yK9zRRtSIJUsGSZGtdV0LL/thQPjU6R rlHtyTNqgHc0HKLPQQ+nz/wmwLPq/TVurCIFuWFI29TlkqGKcYQDwUY0VyBmxpr/YD0F iGzNg3ZeyQmSrWZs+MJMtiWHcjttZ4fcPhUzwtkiC55x8Fpzt7FdbK+iE4kBLM9MX1Lv sQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tubc202gs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 20:19:25 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39JKHgFn027362; Thu, 19 Oct 2023 20:19:24 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3tubc202fg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 20:19:24 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 39JIIU1I026885; Thu, 19 Oct 2023 20:19:22 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3tr5asum40-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Oct 2023 20:19:22 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 39JKJLIp63308050 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Oct 2023 20:19:21 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1DFB458058; Thu, 19 Oct 2023 20:19:21 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C45358057; Thu, 19 Oct 2023 20:19:19 +0000 (GMT) Received: from [9.47.158.152] (unknown [9.47.158.152]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTPS; Thu, 19 Oct 2023 20:19:18 +0000 (GMT) Message-ID: Date: Thu, 19 Oct 2023 16:19:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 03/13] migration: Use vmstate_register_any() for isa-ide Content-Language: en-US To: Juan Quintela , qemu-devel@nongnu.org Cc: Stefan Berger , Marcel Apfelbaum , qemu-ppc@nongnu.org, Nicholas Piggin , qemu-s390x@nongnu.org, Gerd Hoffmann , Corey Minyard , Samuel Thibault , Richard Henderson , David Hildenbrand , Ilya Leoshkevich , Fabiano Rosas , Eric Farman , Peter Xu , Harsh Prateek Bora , John Snow , qemu-block@nongnu.org, Mark Cave-Ayland , Christian Borntraeger , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Stefan Weil , qemu-arm@nongnu.org, Jason Wang , Corey Minyard , Leonardo Bras , Thomas Huth , Peter Maydell , "Michael S. Tsirkin" , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , David Gibson , Halil Pasic , Daniel Henrique Barboza References: <20231019190831.20363-1-quintela@redhat.com> <20231019190831.20363-4-quintela@redhat.com> From: Stefan Berger In-Reply-To: <20231019190831.20363-4-quintela@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4vZb2HZePsoFrpXybNHZtgRLMw8irLVl X-Proofpoint-ORIG-GUID: HoppaDRofukUo8kjS8npJ0gcpVtbz1iq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-19_20,2023-10-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=0 clxscore=1015 mlxscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310190173 Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -52 X-Spam_score: -5.3 X-Spam_bar: ----- X-Spam_report: (-5.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.339, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: +paK+Fk4gW6S On 10/19/23 15:08, Juan Quintela wrote: > Otherwise qom-test fails. > > ok 4 /i386/qom/x-remote > qemu-system-i386: savevm_state_handler_insert: Detected duplicate SaveStateEntry: id=isa-ide, instance_id=0x0 > Broken pipe > ../../../../../mnt/code/qemu/full/tests/qtest/libqtest.c:195: kill_qemu() tried to terminate QEMU process but encountered exit status 1 (expected 0) > Aborted (core dumped) > $ > > Signed-off-by: Juan Quintela Reviewed-by: Stefan Berger > --- > hw/ide/isa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/ide/isa.c b/hw/ide/isa.c > index 95053e026f..ea60c08116 100644 > --- a/hw/ide/isa.c > +++ b/hw/ide/isa.c > @@ -73,7 +73,7 @@ static void isa_ide_realizefn(DeviceState *dev, Error **errp) > ide_bus_init(&s->bus, sizeof(s->bus), dev, 0, 2); > ide_init_ioport(&s->bus, isadev, s->iobase, s->iobase2); > ide_bus_init_output_irq(&s->bus, isa_get_irq(isadev, s->irqnum)); > - vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_isa, s); > + vmstate_register_any(VMSTATE_IF(dev), &vmstate_ide_isa, s); > ide_bus_register_restart_cb(&s->bus); > } >