From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 10/11] drm/i915: Use a preemption timeout to enforce interactivity Date: Tue, 27 Mar 2018 09:57:48 +0100 Message-ID: References: <20180326115044.2505-1-chris@chris-wilson.co.uk> <20180326115044.2505-11-chris@chris-wilson.co.uk> <3df73d2a-c55e-3e0f-0670-6a263a134199@linux.intel.com> <152213995398.10679.16049410664145277095@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E72A6E5A7 for ; Tue, 27 Mar 2018 08:57:51 +0000 (UTC) In-Reply-To: <152213995398.10679.16049410664145277095@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI3LzAzLzIwMTggMDk6MzksIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTAzLTI3IDA5OjM1OjE3KQo+Pgo+PiBPbiAyNi8wMy8yMDE4IDEyOjUw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBVc2UgYSBsaWJlcmFsIHRpbWVvdXQgb2YgMjBtcyB0 byBlbnN1cmUgdGhhdCB0aGUgcmVuZGVyaW5nIGZvciBhbgo+Pj4gaW50ZXJhY3RpdmUgcGFnZWZs aXAgaXMgc3RhcnRlZCBpbiBhIHRpbWVseSBmYXNoaW9uLCBhbmQgdGhhdAo+Pj4gdXNlciBpbnRl cmFjdGlvbiBpcyBub3QgYmxvY2tlZCBieSBHUFUsIG9yIENQVSwgaG9ncy4gVGhpcyBpcyBhdCB0 aGUgY29zdAo+Pj4gb2YgcmVzZXR0aW5nIHdob2V2ZXIgd2FzIGJsb2NraW5nIHRoZSBwcmVlbXB0 aW9uLCBsaWtlbHkgbGVhZGluZyB0byB0aGF0Cj4+PiBjb250ZXh0L3Byb2Nlc3MgYmVpbmcgYmFu bmVkIGZyb20gc3VibWl0dGluZyBmdXR1cmUgcmVxdWVzdHMuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiAtLS0KPj4+ICAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggICAgICB8ICAzICsrLQo+Pj4gICAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgIHwgMTggKysrKysrKysrKy0tLS0tLS0t Cj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxOCArKysrKysr KysrKysrKysrKy0KPj4+ICAgIDMgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgMTAg ZGVsZXRpb25zKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+PiBpbmRleCA4MDAy MzBiYTFjM2IuLjg3Mzg4ZmViOTczZCAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK Pj4+IEBAIC0zMTUwLDggKzMxNTAsOSBAQCBpbnQgaTkxNV9nZW1fb2JqZWN0X3dhaXQoc3RydWN0 IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgIHN0 cnVjdCBpbnRlbF9ycHNfY2xpZW50ICpycHMpOwo+Pj4gICAgaW50IGk5MTVfZ2VtX29iamVjdF93 YWl0X3ByaW9yaXR5KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4+PiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgZmxhZ3MsCj4+PiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGludCBwcmlvcml0eSk7Cj4+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGludCBwcmlvcml0eSwgdW5zaWduZWQgaW50IHRpbWVvdXQpOwo+ Pj4gICAgI2RlZmluZSBJOTE1X1BSSU9SSVRZX0RJU1BMQVkgSTkxNV9QUklPUklUWV9NQVgKPj4+ ICsjZGVmaW5lIEk5MTVfUFJFRU1QVElPTl9USU1FT1VUX0RJU1BMQVkgKDIwICogMTAwMCAqIDEw MDApIC8qIDIwIG1zICovCj4+PiAgICAKPj4+ICAgIGludCBfX211c3RfY2hlY2sKPj4+ICAgIGk5 MTVfZ2VtX29iamVjdF9zZXRfdG9fd2NfZG9tYWluKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0 ICpvYmosIGJvb2wgd3JpdGUpOwo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+PiBpbmRleCA2 NzVkNmJiNTkzMzcuLjI1MmM2YjU4ZTczOSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPj4+IEBAIC00NjksNyArNDY5LDggQEAgaTkxNV9nZW1fb2JqZWN0X3dhaXRfcmVzZXJ2YXRp b24oc3RydWN0IHJlc2VydmF0aW9uX29iamVjdCAqcmVzdiwKPj4+ICAgICAgICByZXR1cm4gdGlt ZW91dDsKPj4+ICAgIH0KPj4+ICAgIAo+Pj4gLXN0YXRpYyB2b2lkIF9fZmVuY2Vfc2V0X3ByaW9y aXR5KHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlLCBpbnQgcHJpbykKPj4+ICtzdGF0aWMgdm9pZCBf X2ZlbmNlX3NldF9wcmlvcml0eShzdHJ1Y3QgZG1hX2ZlbmNlICpmZW5jZSwKPj4+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpbnQgcHJpbywgdW5zaWduZWQgaW50IHRpbWVvdXQpCj4+ PiAgICB7Cj4+PiAgICAgICAgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnE7Cj4+PiAgICAgICAgc3Ry dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+Pj4gQEAgLTQ4MiwxMSArNDgzLDEyIEBAIHN0 YXRpYyB2b2lkIF9fZmVuY2Vfc2V0X3ByaW9yaXR5KHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlLCBp bnQgcHJpbykKPj4+ICAgIAo+Pj4gICAgICAgIHJjdV9yZWFkX2xvY2soKTsKPj4+ICAgICAgICBp ZiAoZW5naW5lLT5zY2hlZHVsZSkKPj4+IC0gICAgICAgICAgICAgZW5naW5lLT5zY2hlZHVsZShy cSwgcHJpbywgMCk7Cj4+PiArICAgICAgICAgICAgIGVuZ2luZS0+c2NoZWR1bGUocnEsIHByaW8s IHRpbWVvdXQpOwo+Pj4gICAgICAgIHJjdV9yZWFkX3VubG9jaygpOwo+Pj4gICAgfQo+Pj4gICAg Cj4+PiAtc3RhdGljIHZvaWQgZmVuY2Vfc2V0X3ByaW9yaXR5KHN0cnVjdCBkbWFfZmVuY2UgKmZl bmNlLCBpbnQgcHJpbykKPj4+ICtzdGF0aWMgdm9pZCBmZW5jZV9zZXRfcHJpb3JpdHkoc3RydWN0 IGRtYV9mZW5jZSAqZmVuY2UsCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBw cmlvLCB1bnNpZ25lZCBpbnQgdGltZW91dCkKPj4+ICAgIHsKPj4+ICAgICAgICAvKiBSZWN1cnNl IG9uY2UgaW50byBhIGZlbmNlLWFycmF5ICovCj4+PiAgICAgICAgaWYgKGRtYV9mZW5jZV9pc19h cnJheShmZW5jZSkpIHsKPj4+IEBAIC00OTQsMTYgKzQ5NiwxNiBAQCBzdGF0aWMgdm9pZCBmZW5j ZV9zZXRfcHJpb3JpdHkoc3RydWN0IGRtYV9mZW5jZSAqZmVuY2UsIGludCBwcmlvKQo+Pj4gICAg ICAgICAgICAgICAgaW50IGk7Cj4+PiAgICAKPj4+ICAgICAgICAgICAgICAgIGZvciAoaSA9IDA7 IGkgPCBhcnJheS0+bnVtX2ZlbmNlczsgaSsrKQo+Pj4gLSAgICAgICAgICAgICAgICAgICAgIF9f ZmVuY2Vfc2V0X3ByaW9yaXR5KGFycmF5LT5mZW5jZXNbaV0sIHByaW8pOwo+Pj4gKyAgICAgICAg ICAgICAgICAgICAgIF9fZmVuY2Vfc2V0X3ByaW9yaXR5KGFycmF5LT5mZW5jZXNbaV0sIHByaW8s IHRpbWVvdXQpOwo+Pj4gICAgICAgIH0gZWxzZSB7Cj4+PiAtICAgICAgICAgICAgIF9fZmVuY2Vf c2V0X3ByaW9yaXR5KGZlbmNlLCBwcmlvKTsKPj4+ICsgICAgICAgICAgICAgX19mZW5jZV9zZXRf cHJpb3JpdHkoZmVuY2UsIHByaW8sIHRpbWVvdXQpOwo+Pj4gICAgICAgIH0KPj4+ICAgIH0KPj4+ ICAgIAo+Pj4gICAgaW50Cj4+PiAgICBpOTE1X2dlbV9vYmplY3Rfd2FpdF9wcmlvcml0eShzdHJ1 Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqLAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB1bnNpZ25lZCBpbnQgZmxhZ3MsCj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg aW50IHByaW8pCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50IHByaW8sIHVuc2ln bmVkIGludCB0aW1lb3V0KQo+Pj4gICAgewo+Pj4gICAgICAgIHN0cnVjdCBkbWFfZmVuY2UgKmV4 Y2w7Cj4+PiAgICAKPj4+IEBAIC01MTgsNyArNTIwLDcgQEAgaTkxNV9nZW1fb2JqZWN0X3dhaXRf cHJpb3JpdHkoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwKPj4+ICAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIHJldDsKPj4+ICAgIAo+Pj4gICAgICAgICAgICAgICAgZm9yIChp ID0gMDsgaSA8IGNvdW50OyBpKyspIHsKPj4+IC0gICAgICAgICAgICAgICAgICAgICBmZW5jZV9z ZXRfcHJpb3JpdHkoc2hhcmVkW2ldLCBwcmlvKTsKPj4+ICsgICAgICAgICAgICAgICAgICAgICBm ZW5jZV9zZXRfcHJpb3JpdHkoc2hhcmVkW2ldLCBwcmlvLCB0aW1lb3V0KTsKPj4+ICAgICAgICAg ICAgICAgICAgICAgICAgZG1hX2ZlbmNlX3B1dChzaGFyZWRbaV0pOwo+Pj4gICAgICAgICAgICAg ICAgfQo+Pj4gICAgCj4+PiBAQCAtNTI4LDcgKzUzMCw3IEBAIGk5MTVfZ2VtX29iamVjdF93YWl0 X3ByaW9yaXR5KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4+PiAgICAgICAgfQo+ Pj4gICAgCj4+PiAgICAgICAgaWYgKGV4Y2wpIHsKPj4+IC0gICAgICAgICAgICAgZmVuY2Vfc2V0 X3ByaW9yaXR5KGV4Y2wsIHByaW8pOwo+Pj4gKyAgICAgICAgICAgICBmZW5jZV9zZXRfcHJpb3Jp dHkoZXhjbCwgcHJpbywgdGltZW91dCk7Cj4+PiAgICAgICAgICAgICAgICBkbWFfZmVuY2VfcHV0 KGV4Y2wpOwo+Pj4gICAgICAgIH0KPj4+ICAgICAgICByZXR1cm4gMDsKPj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+IGluZGV4IDRjMzBjN2MwNGY5Yy4uODMwZjJkNGU1NDBm IDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+IEBAIC0xMjc4 Niw3ICsxMjc4NiwyMyBAQCBpbnRlbF9wcmVwYXJlX3BsYW5lX2ZiKHN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lLAo+Pj4gICAgCj4+PiAgICAgICAgcmV0ID0gaW50ZWxfcGxhbmVfcGluX2ZiKHRvX2lu dGVsX3BsYW5lX3N0YXRlKG5ld19zdGF0ZSkpOwo+Pj4gICAgCj4+PiAtICAgICBpOTE1X2dlbV9v YmplY3Rfd2FpdF9wcmlvcml0eShvYmosIDAsIEk5MTVfUFJJT1JJVFlfRElTUExBWSk7Cj4+PiAr ICAgICAvKgo+Pj4gKyAgICAgICogUmVzY2hlZHVsZSBvdXIgZGVwZW5kZW5jaWVzLCBhbmQgZW5z dXJlIHdlIHJ1biB3aXRoaW4gYSB0aW1lb3V0Lgo+Pj4gKyAgICAgICoKPj4+ICsgICAgICAqIE5v dGUgdGhhdCBpZiB0aGUgdGltZW91dCBpcyBleGNlZWRlZCwgdGhlbiB3aG9ldmVyIHdhcyBydW5u aW5nIHRoYXQKPj4+ICsgICAgICAqIHByZXZlbnRlZCB1cyBmcm9tIGFjcXVpcmluZyB0aGUgR1BV IGlzIGRlY2xhcmVkIHJvZ3VlIGFuZCByZXNldC4gQW4KPj4+ICsgICAgICAqIHVucmVzcG9uc2l2 ZSBwcm9jZXNzIHdpbGwgdGhlbiBiZSBiYW5uZWQgaW4gb3JkZXIgdG8gcHJlc2VydmUKPj4+ICsg ICAgICAqIGludGVyYWN0aXZpdHkuIFNpbmNlIHRoaXMgY2FuIGJlIHNlZW4gYXMgYSBiaXQgaGVh dnktaGFuZGVkLCB3ZQo+Pj4gKyAgICAgICogc2VsZWN0IGEgdGltZW91dCBmb3Igd2hlbiB0aGUg ZHJvcHBlZCBmcmFtZXMgc3RhcnQgdG8gYmVjb21lIGEKPj4+ICsgICAgICAqIG5vdGljZWFibGUg bnVpc2FuY2UgZm9yIHRoZSB1c2VyICgyMCBtcywgaS5lLiBwcmVlbXB0aW9uIHdhcyBibG9ja2Vk Cj4+PiArICAgICAgKiBmb3IgbW9yZSB0aGFuIGEgZnJhbWUpLiBOb3RlLCB0aGlzIGlzIG9ubHkg YSB0aW1lb3V0IGZvciBhIGRlbGF5IGluCj4+PiArICAgICAgKiBwcmVlbXB0aW5nIHRoZSBjdXJy ZW50IHJlcXVlc3QgaW4gb3JkZXIgdG8gcnVuIG91ciBkZXBlbmRlbmN5IGNoYWluLAo+Pj4gKyAg ICAgICogb3VyIGRlcGVuZGVuY3kgY2hhaW4gbWF5IGl0c2VsZiB0YWtlIGEgbG9uZyB0aW1lIHRv IHJ1biB0byBjb21wbGV0aW9uCj4+PiArICAgICAgKiBiZWZvcmUgd2UgY2FuIHByZXNlbnQgdGhl IGZyYW1lYnVmZmVyLgo+Pj4gKyAgICAgICovCj4+PiArICAgICBpOTE1X2dlbV9vYmplY3Rfd2Fp dF9wcmlvcml0eShvYmosIDAsCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBJOTE1X1BSSU9SSVRZX0RJU1BMQVksCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBJOTE1X1BSRUVNUFRJT05fVElNRU9VVF9ESVNQTEFZKTsKPj4KPj4gQVBJIHNpZ25h dHVyZSBjaGFuZ2VzIHRvIGFsbG93IHRpbWVvdXRzIGFyZSBmaW5lLCBidXQgSSB0aGluayB0aGlz IGh1bmsKPj4gc2hvdWxkIGJlIHNlcGFyYXRlIHBhdGNoIGF0IHRoZSBlbmQgb2YgdGhlIHNlcmll cy4gKFNpbmNlIGl0IGhhcyB0aGUKPj4gcG90ZW50aWFsIHRvIG1ha2UgdGhpbmdzIHdoaWNoIHVz ZWQgdG8gd29yaywgYWxiZWl0IHN0dXR0ZXJpbmdseSAoPyksCj4+IHN0YXJ0IGNyYXNoaW5nLgo+ IAo+IEl0IGlzIGF0IHRoZSBlbmQgYXMgYSBzZXBhcmF0ZSBwYXRjaC4gV2hhdCBhbSBJIG1pc3Np bmc/Cj4gKFRoZSBvbmx5IHRoaW5nIGFmdGVyIGl0IGlzIGV4cG9zaW5nIGEgcGFyYW0gdG8gdXNl cnNwYWNlLikKCk15IGJhZCwgSSBhc3N1bWVkIHRoYXQgbGFzdCBvbmUgZGVwZW5kcyBvbiBBUEkg c2lnbmF0dXJlIGNoYW5nZXMgZnJvbSAKdGhpcyBvbmUuCgpSZWdhcmRzLAoKVHZydGtvCgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=