Re: [PATCH v4] mptcp: push queued data on passive TFO subflows becoming established

[Matthieu Baerts <matttbe@kernel.org>]

On 08/10/2026 15:06, T S Rameshkumar wrote:
> Thank you for the detailed feedback and guidance on the workflow!
> I apologize for sending revisions too quickly without giving enough time
> for review and discussion. I will make sure to pace subsequent
> submissions properly, base patches on top of the MPTCP "export" branch,
> increment version tags (v2, v3, etc.), and include changelogs using b4.

Thank you!

Please keep the discussions on the ML (and reply in plain text, and no
top-post [1]).

[1] https://subspace.kernel.org/etiquette.html

> Regarding your technical questions:
> 
>  1.
>     Clearing is_mptfo:
>      1.
>         You are completely right. An automated bot flagged a potential
>         bitfield data race if is_mptfo were cleared concurrently.
>         However, since check_fully_established() is only evaluated once
>         upon receiving the MPC third-ACK, clearing is_mptfo is not
>         needed at all. Since is_mptfo is only read after subflow
>         creation, leaving it in the bitfield and uncleared (exactly as
>         Petar drafted) is completely race-free and clean.

Thanks!

Please also send a regression test for this, ideally with Packetdrill:

 https://lore.kernel.org/bfd64e10-7f1e-41f6-ad12-12f06c4d2880@kernel.org

>  2.
>     Attribution:
>      1.
>         I will definitely add "Suggested-by: Petar Sakic
>         <petar.sakic@ink.fish>".
> 
> I will wait for Petar's response and any further review comments before
> submitting v2 on top of the export branch.

Sounds good to be. But it will be a "v6" then.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.