Re: [PATCH] tests/xe_pmu: Ensure consistent GPU frequency comparison

["Koppuravuri, Ravi Kishore" <ravi.kishore.koppuravuri@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1573 bytes --]

Hi,

On 20-05-2025 22:46, sk.anirban@intel.com wrote:
> From: Sk Anirban<sk.anirban@intel.com>
>
> Fetch the minimum frequency only once during GPU frequency restoration.
> This avoids inconsistencies caused by potential changes in the minimum
> frequency between multiple fetches.
>
> Signed-off-by: Sk Anirban<sk.anirban@intel.com>
> ---
>   tests/intel/xe_pmu.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
> index c49cceff5..f830c5de8 100644
> --- a/tests/intel/xe_pmu.c
> +++ b/tests/intel/xe_pmu.c
> @@ -390,6 +390,7 @@ static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci)
>   	uint32_t gt = eci->gt_id;
>   	uint32_t orig_min = xe_gt_get_freq(fd, eci->gt_id, "min");
>   	uint32_t orig_max = xe_gt_get_freq(fd, eci->gt_id, "max");
> +	uint32_t current_min;
>   	uint32_t orig_rpe;
>   	uint32_t vm;
>   	int pmu_fd[2];
> @@ -440,8 +441,8 @@ static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci)
>   	 */
>   	igt_assert(xe_gt_set_freq(fd, gt, "min", orig_min) > 0);
>   	orig_rpe = xe_gt_get_freq(fd, gt, "rpe");
> -	igt_assert(xe_gt_get_freq(fd, gt, "min") == orig_min ||
> -		   xe_gt_get_freq(fd, gt, "min") == orig_rpe);
> +	current_min = xe_gt_get_freq(fd, gt, "min");
> +	igt_assert(current_min == orig_min || current_min == orig_rpe);
>   
>   	igt_info("Minimum frequency: requested %.1f, actual %.1f\n",
>   		 min[0], min[1]);

It looks good to me.

Reviewed-by: Ravi Kishore Koppuravuri <ravi.kishore.koppuravuri@intel.com>

[-- Attachment #2: Type: text/html, Size: 2927 bytes --]