From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: fio max blocksize References: <15f67a56-7f53-cfca-f4e6-289e1d6c2b14@kernel.dk> <4c57a31e-7955-d0b2-ed27-9d494f090651@kernel.dk> From: Jens Axboe Message-ID: Date: Fri, 13 Jul 2018 21:05:33 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit To: Jeff Furlong , "fio@vger.kernel.org" List-ID: On 7/13/18 5:59 PM, Jeff Furlong wrote: > I fixed the buflen issue (just keep peeling the onion back and > updating all associated vars), fixed bsrange, fixed "auto" tabs, and > did some simple tests: > # fio --name=test --ioengine=libaio --direct=1 --rw=trim --iodepth=1 --bs=4g --filename=/dev/nvme1n1 --number_ios=1 > # fio --name=test --ioengine=libaio --direct=1 --rw=trim --iodepth=1 --bs=1t --filename=/dev/nvme1n1 --number_ios=1 > # fio --name=test --ioengine=libaio --direct=1 --rw=trim --iodepth=1 --bsrange=4g-8g --filename=/dev/nvme1n1 --number_ios=2 > > The open issue I have is parsing bssplit. I plumbed out bssplit.bs as > a 64 bit value, but using the existing value_pair helpers (32 bit) > seem to conflict. Don’t really want to duplicate chunks of code, so > open to ideas there. I'd just convert those helpers to deal with unsigned long long always, that should work fine for the uint case. Just a note that I'll be out all of next week, so you'll have plenty of time to make this perfect before I get back :-) -- Jens Axboe