From: Chris Mason <clm@fb.com>
To: Liu Bo <bo.li.liu@oracle.com>, <linux-btrfs@vger.kernel.org>
Cc: David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH v3] Btrfs: fix eb memory leak due to readpage failure
Date: Mon, 11 Jul 2016 14:27:39 -0400 [thread overview]
Message-ID: <a24aa67a-1880-64d5-1e09-7682e838141a@fb.com> (raw)
In-Reply-To: <1468258747-19617-1-git-send-email-bo.li.liu@oracle.com>
On 07/11/2016 01:39 PM, Liu Bo wrote:
> eb->io_pages is set in read_extent_buffer_pages().
>
> In case of readpage failure, for pages that have been added to bio,
> it calls bio_endio and later readpage_io_failed_hook() does the work.
>
> When this eb's page (couldn't be the 1st page) fails to add itself to bio
> due to failure in merge_bio(), it cannot decrease eb->io_pages via bio_endio,
> and ends up with a memory leak eventually.
>
> This lets __do_readpage propagate errors to callers and adds the
> 'atomic_dec(&eb->io_pages)'.
Thanks for looking at this Liu, how is it currently being tested?
-chris
next prev parent reply other threads:[~2016-07-11 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 19:08 [PATCH v2] Btrfs: fix eb memory leak due to readpage failure Liu Bo
2016-06-13 15:36 ` David Sterba
2016-07-08 16:01 ` David Sterba
2016-07-08 21:23 ` Liu Bo
2016-07-11 17:39 ` [PATCH v3] " Liu Bo
2016-07-11 18:27 ` Chris Mason [this message]
2016-07-11 22:48 ` Liu Bo
2016-07-11 22:54 ` Chris Mason
2016-07-11 23:04 ` Liu Bo
2016-07-12 17:30 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a24aa67a-1880-64d5-1e09-7682e838141a@fb.com \
--to=clm@fb.com \
--cc=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.