From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [PATCH v3 1/4] net/i40e: fix bitmask of supported Tx flags
Date: Tue, 7 Feb 2017 16:01:00 +0000 [thread overview]
Message-ID: <a2620157-6ac0-73fc-2af7-126cd6ec97fc@intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810CD5CA6@SHSMSX103.ccr.corp.intel.com>
On 2/7/2017 3:45 PM, Wu, Jingjing wrote:
>>> +#ifdef RTE_LIBRTE_IEEE1588
>>> +#define I40E_TX_IEEE1588_TMST PKT_TX_IEEE1588_TMST #else #define
>>> +I40E_TX_IEEE1588_TMST 0 #endif
>>> +
>>> #define I40E_TX_CKSUM_OFFLOAD_MASK ( \
>>> PKT_TX_IP_CKSUM | \
>>> PKT_TX_L4_MASK | \
>>> @@ -87,7 +93,9 @@
>>> PKT_TX_OUTER_IP_CKSUM | \
>>> PKT_TX_TCP_SEG | \
>>> PKT_TX_QINQ_PKT | \
>>> - PKT_TX_VLAN_PKT)
>>> + PKT_TX_VLAN_PKT | \
>>> + PKT_TX_TUNNEL_MASK | \
>>> + I40E_TX_IEEE1588_TMST)
>>
>> PKT_TX_IEEE1588_TMST added into I40E_TX_OFFLOAD_MASK, but not into
>> PKT_TX_OFFLOAD_MASK (patch 4/4)
>>
>> Shouldn't PKT_TX_OFFLOAD_MASK be a super set of driver ones. Otherwise
>> PKT_TX_IEEE1588_TMST will be marked as not supported according below
>> XOR logic.
>>
>
> Yes, you are right. Should I send a new version patch set? Or just update the [4/4]?
Please send a new version of the set.
Thanks,
ferruh
next prev parent reply other threads:[~2017-02-07 16:01 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 11:50 [PATCH 1/2] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-01-24 11:50 ` [PATCH 2/2] net/i40e: fix bitmask of supported Tx flags Jingjing Wu
2017-01-26 14:19 ` [PATCH 1/2] mbuf: fix bitmask of Tx offload flags Ferruh Yigit
2017-02-04 3:36 ` [PATCH v2 0/5] fix bitmask of supported Tx flags Jingjing Wu
2017-02-04 3:36 ` [PATCH v2 1/5] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-02-04 3:36 ` [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags Jingjing Wu
2017-02-05 10:28 ` Ferruh Yigit
2017-02-06 3:02 ` Wu, Jingjing
2017-02-06 10:28 ` Olivier Matz
2017-02-07 2:30 ` Wu, Jingjing
2017-02-06 10:26 ` Olivier Matz
2017-02-07 2:30 ` Wu, Jingjing
2017-02-04 3:36 ` [PATCH v2 3/5] net/ixgbe: " Jingjing Wu
2017-02-05 11:59 ` Ananyev, Konstantin
2017-02-05 12:10 ` Ananyev, Konstantin
2017-02-06 8:53 ` Wu, Jingjing
2017-02-06 12:11 ` Ananyev, Konstantin
2017-02-07 2:29 ` Wu, Jingjing
2017-02-08 0:34 ` Ananyev, Konstantin
2017-02-04 3:36 ` [PATCH v2 4/5] net/e1000: " Jingjing Wu
2017-02-04 3:36 ` [PATCH v2 5/5] net/fm10k: " Jingjing Wu
2017-02-07 3:22 ` [PATCH v3 0/4] " Jingjing Wu
2017-02-07 3:22 ` [PATCH v3 1/4] net/i40e: " Jingjing Wu
2017-02-07 13:48 ` Ferruh Yigit
2017-02-07 15:45 ` Wu, Jingjing
2017-02-07 16:01 ` Ferruh Yigit [this message]
2017-02-07 3:22 ` [PATCH v3 2/4] net/ixgbe: " Jingjing Wu
2017-02-07 3:22 ` [PATCH v3 3/4] net/e1000: " Jingjing Wu
2017-02-07 3:22 ` [PATCH v3 4/4] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-02-08 5:05 ` [PATCH v4 0/4] fix bitmask of supported Tx flags Jingjing Wu
2017-02-08 5:05 ` [PATCH v4 1/4] net/i40e: " Jingjing Wu
2017-02-08 5:05 ` [PATCH v4 2/4] net/ixgbe: " Jingjing Wu
2017-02-08 5:05 ` [PATCH v4 3/4] net/e1000: " Jingjing Wu
2017-02-08 5:05 ` [PATCH v4 4/4] mbuf: fix bitmask of Tx offload flags Jingjing Wu
2017-02-08 16:27 ` Olivier MATZ
2017-02-08 16:32 ` [PATCH v4 0/4] fix bitmask of supported Tx flags Ferruh Yigit
2017-02-09 1:13 ` Wu, Jingjing
2017-02-08 16:46 ` Ananyev, Konstantin
2017-02-09 14:37 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2620157-6ac0-73fc-2af7-126cd6ec97fc@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.