From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA83C433E0 for ; Sun, 5 Jul 2020 20:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25A582068F for ; Sun, 5 Jul 2020 20:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJPduT76" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728347AbgGEUqm (ORCPT ); Sun, 5 Jul 2020 16:46:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728243AbgGEUql (ORCPT ); Sun, 5 Jul 2020 16:46:41 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF8E4C061794 for ; Sun, 5 Jul 2020 13:46:41 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id f2so14524598plr.8 for ; Sun, 05 Jul 2020 13:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8fHalzuFbxhtFhTMEYCEmd4Gg+v/Uji4N2EwSMY2D2Y=; b=ZJPduT76pPVSt6chwJr4EGWNeYXaQUsiqLZnqy2m23dBJXOcqGxLyWk/7wST8BgHUq Fg4MhHxewvN5Ib2+NpEGtFkBELVpKBDmAoVUYGSVxQ8E6uk4/kDYShlb23PYaAYoFlC2 pee1nBjW04pcWKLbyzqJ6v1wyDl30dX11c2kta4f1GHHZkifxFXkt5Zfh8QVkMsb4Jvw /5TmixyrhR/ccQW0xDZDZZ30V2rh9DGnEWCxwcvdwTB8vaJn5+JENCNgdkmnQLXvAR6g aM5HCy22nYNyGwI1nEWZS2Z/lU7ZeGhOgMHE8y/JlnxWWt6YaqvB8lqueFKeYqsKZ+3r wysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8fHalzuFbxhtFhTMEYCEmd4Gg+v/Uji4N2EwSMY2D2Y=; b=DjUotoJgK8khkvjXt+kW7d1BjqZRYq836XQidTPgpvL+7HKw9vvkbNDmylo13/v0KE mIzDU4o+bQURpnJA/CBTdfTMcZIofmPmBIi35y+0zaTwW4xjh0vRgoWHWVVIAaxkeRSh MJczAe+uh8krjqhRSTz8vNVE8FjZXtgfczU6Xfjy/H4NYIolbfJbV9/G6V6vYW/E2RB5 RmsWxPw8TiPuNC5A7Bj+2cIvZsiQndia29UPyFF/+1imDBOWfDXkTWrpMqm6WG1sKXvM +frJV2LGvs1yTzV7OnK+vAheIDmhVtgStbHpfHML2keJGyqHX1VIopO0T9YCkIu0aUZf uejQ== X-Gm-Message-State: AOAM533Id5W/ldT0yAI7mLIegVq38sqpnTyJpPksH+QnG9yBUaWOLh+9 9lw29gLxdt8igEqBF8nRYTU= X-Google-Smtp-Source: ABdhPJxdYGCKPYyrbH+E6q9xAaL5xCxBGw9t+9FF+c7k0ogBAwZVgROtyoXLfyOeoPwhBq+t2usZgA== X-Received: by 2002:a17:902:e783:: with SMTP id cp3mr37384540plb.265.1593982001399; Sun, 05 Jul 2020 13:46:41 -0700 (PDT) Received: from ?IPv6:2001:470:67:5b9:5dec:e971:4cde:a128? ([2001:470:67:5b9:5dec:e971:4cde:a128]) by smtp.gmail.com with ESMTPSA id h7sm17438329pfq.15.2020.07.05.13.46.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Jul 2020 13:46:40 -0700 (PDT) Subject: Re: [PATCH net-next 6/7] net: phy: cavium: Improve __iomem mess To: Andrew Lunn , David Miller Cc: netdev , Heiner Kallweit , Sunil Goutham , Robert Richter References: <20200705182921.887441-1-andrew@lunn.ch> <20200705182921.887441-7-andrew@lunn.ch> From: Florian Fainelli Message-ID: Date: Sun, 5 Jul 2020 13:46:37 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200705182921.887441-7-andrew@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/5/2020 11:29 AM, Andrew Lunn wrote: > The MIPS low level register access functions seem to be missing > __iomem annotation. This cases lots of sparse warnings, when code s/cases/causes/g > casts off the __iomem. Make the Cavium MDIO drivers cleaner by pushing > the casts lower down into the helpers, allow the drivers to work as > normal, with __iomem. > > bus->register_base is now an void *, rather than a u64. So forming the > mii_bus->id string cannot use %llx any more. Use %px, so this kernel > address is still exposed to user space, as it was before. > > Cc: Sunil Goutham > Cc: Robert Richter > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli -- Florian